From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41F36C7EE32 for ; Thu, 26 Jun 2025 23:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sds+EnePYO1cZCHbAHOJn503ulI/pwm3RK5XFeMRA7A=; b=xEFBp+8I58zprV9ywhsXqIbUPK NAFHs1HusjMt5MbNalVbe/HDLqUJ0N+yrqSavgSqvBy5VSVvdL59vVzsSgJf5ymOcmt1oou3q5kHf O5ll+P20stW1okbVnvlq6hf57zBRlYel5ulDbZ+Kot+4Jy27aOKGrphnZeLxhQuBhdnvURb9wvxqs 2U8nOlwzbXXEF9d1POQnWzOTVQJ6wkPYpgSlqN56LIs8shSSFmUFDIWBU2k/UpZqGbW6XFkSRZy0N qPud3NP8UCOoAQXVhRuYq/gYzaR6JhcxmXxABTpRiLEU78YwRvIMXGasYzkvsbhzS7Phz796/ArbP ll7Tyyzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUwJi-0000000D5yG-48nj; Thu, 26 Jun 2025 23:47:42 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUuWl-0000000CsPL-2sDH for linux-arm-kernel@lists.infradead.org; Thu, 26 Jun 2025 21:53:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750974782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sds+EnePYO1cZCHbAHOJn503ulI/pwm3RK5XFeMRA7A=; b=A+oK8OwhDDjk1ZIpY/GmClNu+li9P7YpgJTIK/Df5CAC4LcrU+hJvt59PzojWGlR00fcla NRkNDt4xyyc9MY+LuRT+MgXb1oRZVNJNkQX+EPa8VqWXFczx0SYcOBq0CXnC5efOVs+ssC PskomFyGwh3z0gbCqC82vNBxK0t1RZo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510--C6FdKiaPwe90esugMXWWQ-1; Thu, 26 Jun 2025 17:52:54 -0400 X-MC-Unique: -C6FdKiaPwe90esugMXWWQ-1 X-Mimecast-MFC-AGG-ID: -C6FdKiaPwe90esugMXWWQ_1750974774 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f8fd1847so558611f8f.1 for ; Thu, 26 Jun 2025 14:52:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750974773; x=1751579573; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Sds+EnePYO1cZCHbAHOJn503ulI/pwm3RK5XFeMRA7A=; b=IS3etxc/fiatXVcjeO85IJCFEdpBb+aJJFvY4kE4mPpOzFRCVk+/gobS6uxMvZLB3C bZG7iRvrIRJD9Brt3XXbvu9Yr7IaCYjNnexG5rRQTAD+d5/ZHHe/XpVOyGFNuXXZpe4U dEgbbeRHbbTL3/ZH6g2tm89E0bRPPa6UCbg80mfwJlTbUlxdciHLGkJrzWoL7YNCLuc9 bezUmKLwNHyFLe1tRf/1xe2nJQIPXFUlwD10UcN/UKsrztJnRM0M0EVW4T1JObVsCdKc LwPeWWpOgmDoa9+pSq0DvAPcUyH4+rjFiWK702no2GzY2BJEi77LCeP1yI2rcVzjcWJX 253A== X-Forwarded-Encrypted: i=1; AJvYcCWxlnpGRz/52Q+RiqKB/oIhZSknmtN7PwmrusDOKH+EqLYux5or92ZfbPIviHIW3rOyScu4y+Pupvk8qYCUeedv@lists.infradead.org X-Gm-Message-State: AOJu0YwPMpczkQoy9OsxsGYo1h5jJhlSATzvRUG2UTv+Ot4OheAaArIu i+92GiZZtv77pa3FBG8kz6c8hMF/vny1Gi1VLOWWwKmACOUlUlzOsiI0uJO5tAModZna7t/HKw6 V7ATTN4rhKUZGuG/9LWUtcT4sWqofKa2GmYUjXzIpPOf75EZJb6E8wq/MSNhvey80qiF7YpvMZL WF X-Gm-Gg: ASbGnct4bew3qn5OcJJHy5W9y1s8EUxNmjRkvXNrhAMLmr0a77cBJqni7rES/YWkdrI La0voFQCUNxeVUGAeCNbjzk1fy557yG3ZXK9Fix4OIbxSJvNvwonhqUANoNF5lKNTX//cjA2tyx gPXVDNPBXFQUfoOvnDkkz5lYa6Mrytpw14WnKk4DLEzDYeSDCoZT2aCa9IWPSbvJHP5bM4IvRJM M7XrHDJ4Jdhym4nAA+8sW5l2w+Q8T2NPbAQJJotUox+Tn9lyhwMBNVcSOiqt3VnFmeR3DuBBLkj XSsjM09IRXTHsWGByBT7rTxQRMSZrFY9LXD5wjidVs1cgnU+/SwzQRTxBoI2mUkePmLLkzEnGyY 7pagHwsSRbgf4FhVWWyE23n9Q74dSRWSu0eP8/X7kkUL5yZgn0Q== X-Received: by 2002:adf:b60f:0:b0:3a6:d296:feaf with SMTP id ffacd0b85a97d-3a8fe985feamr656658f8f.24.1750974773619; Thu, 26 Jun 2025 14:52:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF91pFzkN010jPQk8nO4iHG/+bQ0g3gbQdu1CsS5nqxXRrx9a1rGPo2RPO9VipXGBPN3oatgg== X-Received: by 2002:adf:b60f:0:b0:3a6:d296:feaf with SMTP id ffacd0b85a97d-3a8fe985feamr656645f8f.24.1750974773213; Thu, 26 Jun 2025 14:52:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:2f00:8afc:23fe:3813:776c? (p200300d82f3c2f008afc23fe3813776c.dip0.t-ipconnect.de. [2003:d8:2f3c:2f00:8afc:23fe:3813:776c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7fadf3sm958775f8f.34.2025.06.26.14.52.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 14:52:52 -0700 (PDT) Message-ID: <4856517e-fb68-436f-8130-b7eb5749b7c0@redhat.com> Date: Thu, 26 Jun 2025 23:52:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Barry Song <21cnbao@gmail.com>, Lance Yang Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, lance.yang@linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com References: <20250626092905.31305-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RwiOwG_XTKDA5ZiBrRBy-zvYO4jMZ3XbkVp7DOaYOQs_1750974774 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250626_145303_794905_0C2B58E1 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26.06.25 23:46, Barry Song wrote: > On Thu, Jun 26, 2025 at 9:29 PM Lance Yang wrote: >> > [...] >> + >> + /* >> + * If we are sure that we batched the entire folio and cleared >> + * all PTEs, we can just optimize and stop right here. >> + */ >> + if (nr_pages == folio_nr_pages(folio)) > > David also mentioned if (nr_pages > 1 && nr_pages == folio_nr_pages(folio)). > I assume it’s still fine when nr_pages == 1 for small folios? No? Yeah, as raised I think it is fine. We should never have any folio page mapped multiple times into the same VMA in any case. (excluding KSM pages, but they are handled differenty, using a specialized rmap walk) -- Cheers, David / dhildenb