* [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
@ 2023-12-19 9:02 Alexander Stein
2023-12-19 9:09 ` Andrew Lunn
2023-12-20 2:27 ` Ying Liu
0 siblings, 2 replies; 5+ messages in thread
From: Alexander Stein @ 2023-12-19 9:02 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-phy, linux-arm-kernel
Devicetree spec lists only dashes as valid characters for alias names.
Table 3.2: Valid characters for alias names, Devicee Specification,
Release v0.4
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
index e625b32889bf..0928a526e2ab 100644
--- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
+++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
@@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device *pdev)
return ret;
}
- priv->id = of_alias_get_id(np, "mipi_dphy");
+ priv->id = of_alias_get_id(np, "mipi-dphy");
if (priv->id < 0) {
dev_err(dev, "Failed to get phy node alias id: %d\n",
priv->id);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
2023-12-19 9:02 [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
@ 2023-12-19 9:09 ` Andrew Lunn
2023-12-19 9:13 ` Alexander Stein
2023-12-20 2:27 ` Ying Liu
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2023-12-19 9:09 UTC (permalink / raw)
To: Alexander Stein
Cc: Vinod Koul, Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer,
Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team, linux-phy,
linux-arm-kernel
On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote:
> Devicetree spec lists only dashes as valid characters for alias names.
> Table 3.2: Valid characters for alias names, Devicee Specification,
> Release v0.4
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> index e625b32889bf..0928a526e2ab 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device *pdev)
> return ret;
> }
>
> - priv->id = of_alias_get_id(np, "mipi_dphy");
> + priv->id = of_alias_get_id(np, "mipi-dphy");
Are there any in tree DT blobs using mipi_dphy which are going to
break because of this change?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
2023-12-19 9:09 ` Andrew Lunn
@ 2023-12-19 9:13 ` Alexander Stein
2023-12-19 11:59 ` Vladimir Oltean
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Stein @ 2023-12-19 9:13 UTC (permalink / raw)
To: Andrew Lunn
Cc: Vinod Koul, Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer,
Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team, linux-phy,
linux-arm-kernel
Hi Andrew,
Am Dienstag, 19. Dezember 2023, 10:09:24 CET schrieb Andrew Lunn:
> On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote:
> > Devicetree spec lists only dashes as valid characters for alias names.
> > Table 3.2: Valid characters for alias names, Devicee Specification,
> > Release v0.4
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index
> > e625b32889bf..0928a526e2ab 100644
> > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device
> > *pdev)>
> > return ret;
> >
> > }
> >
> > - priv->id = of_alias_get_id(np, "mipi_dphy");
> > + priv->id = of_alias_get_id(np, "mipi-dphy");
>
> Are there any in tree DT blobs using mipi_dphy which are going to
> break because of this change?
You are right, I should have mentioned that already.
The alias is only used when used on a combo-PHY, which is only i.MX8QXP. Up
until now there is no DT node in-kernel which uses the fsl,imx8qxp-mipi-dphy
compatible. So no there should be no blobs at all using the old alias name.
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
2023-12-19 9:13 ` Alexander Stein
@ 2023-12-19 11:59 ` Vladimir Oltean
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Oltean @ 2023-12-19 11:59 UTC (permalink / raw)
To: Alexander Stein, Liu Ying
Cc: Andrew Lunn, Vinod Koul, Kishon Vijay Abraham I, Shawn Guo,
Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team,
NXP Linux Team, linux-phy, linux-arm-kernel
On Tue, Dec 19, 2023 at 10:13:03AM +0100, Alexander Stein wrote:
> Hi Andrew,
>
> Am Dienstag, 19. Dezember 2023, 10:09:24 CET schrieb Andrew Lunn:
> > On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote:
> > > Devicetree spec lists only dashes as valid characters for alias names.
> > > Table 3.2: Valid characters for alias names, Devicee Specification,
> > > Release v0.4
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >
> > > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index
> > > e625b32889bf..0928a526e2ab 100644
> > > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device
> > > *pdev)>
> > > return ret;
> > >
> > > }
> > >
> > > - priv->id = of_alias_get_id(np, "mipi_dphy");
> > > + priv->id = of_alias_get_id(np, "mipi-dphy");
> >
> > Are there any in tree DT blobs using mipi_dphy which are going to
> > break because of this change?
>
> You are right, I should have mentioned that already.
> The alias is only used when used on a combo-PHY, which is only i.MX8QXP. Up
> until now there is no DT node in-kernel which uses the fsl,imx8qxp-mipi-dphy
> compatible. So no there should be no blobs at all using the old alias name.
>
> Best regards,
> Alexander
This seems correct. The NXP kernels have this revert commit which
reinforces the fact that this driver does not probe on the
"fsl,imx8qxp-mipi-dphy" compatible string even downstream.
https://github.com/nxp-imx/linux-imx/commit/daf4e70d081a2672ac4a22ff39f6712798a0cc3b
Adding Liu Ying.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
2023-12-19 9:02 [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
2023-12-19 9:09 ` Andrew Lunn
@ 2023-12-20 2:27 ` Ying Liu
1 sibling, 0 replies; 5+ messages in thread
From: Ying Liu @ 2023-12-20 2:27 UTC (permalink / raw)
To: Alexander Stein, Vinod Koul, Kishon Vijay Abraham I, Shawn Guo,
Sascha Hauer, Fabio Estevam
Cc: Pengutronix Kernel Team, dl-linux-imx,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
On Tuesday, December 19, 2023 5:03 PM, Alexander Stein <alexander.stein@ew.tq-group.com> wrote:
> Devicetree spec lists only dashes as valid characters for alias names.
This saying is not accurate because it lists digit, lowercase letter and
dash characters.
> Table 3.2: Valid characters for alias names, Devicee Specification,
> Release v0.4
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
It makes sense to add a Fixes tag:
Fixes: 3fbae284887d ("phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support")
Regards,
Liu Ying
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-20 2:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-19 9:02 [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
2023-12-19 9:09 ` Andrew Lunn
2023-12-19 9:13 ` Alexander Stein
2023-12-19 11:59 ` Vladimir Oltean
2023-12-20 2:27 ` Ying Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).