From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B39C5C46CD2 for ; Tue, 30 Jan 2024 19:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fBS3A1YcbxZonsz/AJEvHp6qUIfC3C6IgWulvUVyakE=; b=UZvQ8UurZMAOQR pfVpfDFlGpsJrO0hMPa2mynBBHvlv5xRcLiV1chwGhLwm3rnCAUMghL0zUclz/0QdWNewpSMR732d JY4k6QvVCL9ZxCoFhPl0p0eGJJRAGk90Fho5ygw2AhoLr3d9VWorcr63yGX8wkkji0LnxE00+vhoE q166x4rYJIcC4FwN1BnJtCFd2w5o5FY4HHecULpJyUZA3HVKb/kgN11+44d41GGmmMVtYhPIZKuWT yMBhwuJXCpa849wCZpAN/jXcF8jDbIEUNNJrNUKF2O/JY+GtkNwWiMY3jckRTnr2jj0OS33Yh7059 u9/p5JvwD7zb4VXDp8Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUtyy-00000000Myt-3KOw; Tue, 30 Jan 2024 19:41:20 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUtyw-00000000MyD-0l9b for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 19:41:19 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-55f2b0c5ae9so2204127a12.2 for ; Tue, 30 Jan 2024 11:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706643676; x=1707248476; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tV2jTL1wgNtNZ2OFkWSlg5EStCwbj+Bl8szw2VZf79I=; b=aZ4ZiVloldpmDHJNEZyUDSZ97OsUfMo2XwG8bjhp4/pkkjAjJMA0YA58FE9E6gjT3I xWpU5anskmK+s+QEI9n0xsbmHTsdeTknV2wrGu9hpfEYYXL5wKapzPPp3B4urut087iR yacy7I5uKCatzjuzCeAowUnCEiMdU0kCyo7sjXzPAuWKNmbNVj8mHILfuVc5aCjWkgtt 69iomgUdokLNkn2t3yobsX1PAAxPaPjtlz4dwJJMMWMwbUTXEhx/XNyqm5tZOWEIyusW qzJVrdOl6nZQ6DL964lrnYYDvMFc5NsX20o3mRrOTLcMjLdxXAstAzLNy20tIZYtN36+ PEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706643676; x=1707248476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tV2jTL1wgNtNZ2OFkWSlg5EStCwbj+Bl8szw2VZf79I=; b=UJ7AcVY/i18J8ArWCMdAleVKCflJKXS+P/SpJbpDBPh1ySybJCBfl1O0gPzNGQeEGj LXYH0ViXFFMgU9esX5Zqm1FP6ONgQ5vq1tkUeBBtEp6qur6lFbMSH4IryCoq+Ood6TlL YxAGiBSU9xaQfr9EzBqaHcbIwSwPfukj4rcKeHxSXVFq7h7NSrbQrfb7znCPjsCzM6d2 wjT+e5iO4nizVHE9q9qYAwfV4RTSAi0PslU8z47YoDGfMI068W/APmnF4mBiYpq9Gc4D NiZ8qSeToVJjfZrtOFzoEoHXWo18bddvw9+JRMWIO3lstd5vfT/y5/38vowXkL1OmXw0 7VaQ== X-Gm-Message-State: AOJu0Yw7tAxgBHtF1C7dRHe5SM7HYeKaM05EWgDPXB4UvUBl1P60MX1r L8kb5hGzL3ClzlAhv1n7U/VikgWhxW6AAo2XTzIr2Q9jEVKoltpX X-Google-Smtp-Source: AGHT+IEVIjesSyztYMsiKeNJdYkDMf1U0WWfhSyU1fnCnWNWHFxpNaNAcQzT6VdSd3W0piensaNZ3A== X-Received: by 2002:a05:6402:40c4:b0:55f:7a8:fdf1 with SMTP id z4-20020a05640240c400b0055f07a8fdf1mr4814703edb.29.1706643676208; Tue, 30 Jan 2024 11:41:16 -0800 (PST) Received: from jernej-laptop.localnet (86-58-14-70.dynamic.telemach.net. [86.58.14.70]) by smtp.gmail.com with ESMTPSA id i36-20020a0564020f2400b0055effc1e4basm2448375eda.24.2024.01.30.11.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 11:41:15 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Aren Moynihan Cc: Miles Alan , Ondrej Jirman , Aren Moynihan , Chen-Yu Tsai , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Date: Tue, 30 Jan 2024 20:41:14 +0100 Message-ID: <4864457.GXAFRqVoOG@jernej-laptop> In-Reply-To: <20240128204740.2355092-3-aren@peacevolution.org> References: <20240128204740.2355092-1-aren@peacevolution.org> <20240128204740.2355092-3-aren@peacevolution.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_114118_254451_223C8EC9 X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 28. januar 2024 ob 21:45:09 CET je Aren Moynihan napisal(a): > The red, green, and blue leds currently in the device tree represent a > single rgb led on the front of the PinePhone. > > Signed-off-by: Aren Moynihan > --- > > .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > index ad2476ee01e4..6eab61a12cd8 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > @@ -39,21 +39,21 @@ chosen { > leds { > compatible = "gpio-leds"; > > - led-0 { > + led0: led-0 { > function = LED_FUNCTION_INDICATOR; > color = ; > gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ > retain-state-suspended; > }; > > - led-1 { > + led1: led-1 { > function = LED_FUNCTION_INDICATOR; > color = ; > gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ > retain-state-suspended; > }; > > - led-2 { > + led2: led-2 { > function = LED_FUNCTION_INDICATOR; > color = ; > gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ > @@ -61,6 +61,13 @@ led-2 { > }; > }; > > + multi-led { > + compatible = "leds-group-multicolor"; > + color = ; > + function = LED_FUNCTION_INDICATOR; Does it make sense to have function specified here and above? Example specifies it only in multi-led node. Best regards, Jernej > + leds = <&led0>, <&led1>, <&led2>; > + }; > + > reg_ps: ps-regulator { > compatible = "regulator-fixed"; > regulator-name = "ps"; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel