From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: fix clock gate for rk3188 spdif_pre
Date: Sun, 23 Nov 2014 01:58:24 +0100 [thread overview]
Message-ID: <4871254.UVsZ9NLXxR@diego> (raw)
In-Reply-To: <1416562062-14286-1-git-send-email-julien.chauveau@neo-technologies.fr>
Am Freitag, 21. November 2014, 10:27:41 schrieb Julien CHAUVEAU:
> In rk3188 clock branches, spdif_pre gate was set to RK2928_CLKGATE_CON(13)
> bit 13. This appears to be a copy-paste error because such a register does
> not exist. We correct it to RK2928_CLKGATE_CON(0) and find out that the
> rk3188 spdif clock is the same as the rk3066 spdif clock, so we move it to
> the common clock branches.
>
> Signed-off-by: Julien CHAUVEAU <julien.chauveau@neo-technologies.fr>
applied to my clk branch for 3.19 after verifying the manual-values
Thanks
Heiko
> ---
> drivers/clk/rockchip/clk-rk3188.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3188.c
> b/drivers/clk/rockchip/clk-rk3188.c index b0293c4..725d841 100644
> --- a/drivers/clk/rockchip/clk-rk3188.c
> +++ b/drivers/clk/rockchip/clk-rk3188.c
> @@ -330,6 +330,15 @@ static struct rockchip_clk_branch common_clk_branches[]
> __initdata = { RK2928_CLKSEL_CON(24), 8, 8, DFLAGS,
> RK2928_CLKGATE_CON(2), 8, GFLAGS),
>
> + COMPOSITE_NOMUX(0, "spdif_pre", "i2s_src", 0,
> + RK2928_CLKSEL_CON(5), 0, 7, DFLAGS,
> + RK2928_CLKGATE_CON(0), 13, GFLAGS),
> + COMPOSITE_FRAC(0, "spdif_frac", "spdif_pll", 0,
> + RK2928_CLKSEL_CON(9), 0,
> + RK2928_CLKGATE_CON(0), 14, GFLAGS),
> + MUX(SCLK_SPDIF, "sclk_spdif", mux_sclk_spdif_p, 0,
> + RK2928_CLKSEL_CON(5), 8, 2, MFLAGS),
> +
> /*
> * Clock-Architecture Diagram 4
> */
> @@ -577,14 +586,6 @@ static struct rockchip_clk_branch
> rk3066a_clk_branches[] __initdata = { RK2928_CLKGATE_CON(0), 12, GFLAGS),
> MUX(SCLK_I2S2, "sclk_i2s2", mux_sclk_i2s2_p, 0,
> RK2928_CLKSEL_CON(4), 8, 2, MFLAGS),
> - COMPOSITE_NOMUX(0, "spdif_pre", "i2s_src", 0,
> - RK2928_CLKSEL_CON(5), 0, 7, DFLAGS,
> - RK2928_CLKGATE_CON(0), 13, GFLAGS),
> - COMPOSITE_FRAC(0, "spdif_frac", "spdif_pll", 0,
> - RK2928_CLKSEL_CON(9), 0,
> - RK2928_CLKGATE_CON(0), 14, GFLAGS),
> - MUX(SCLK_SPDIF, "sclk_spdif", mux_sclk_spdif_p, 0,
> - RK2928_CLKSEL_CON(5), 8, 2, MFLAGS),
>
> GATE(HCLK_I2S1, "hclk_i2s1", "hclk_cpu", 0, RK2928_CLKGATE_CON(7), 3,
> GFLAGS), GATE(HCLK_I2S2, "hclk_i2s2", "hclk_cpu", 0, RK2928_CLKGATE_CON(7),
> 4, GFLAGS), @@ -675,14 +676,6 @@ static struct rockchip_clk_branch
> rk3188_clk_branches[] __initdata = { RK2928_CLKGATE_CON(0), 10, GFLAGS),
> MUX(SCLK_I2S0, "sclk_i2s0", mux_sclk_i2s0_p, 0,
> RK2928_CLKSEL_CON(3), 8, 2, MFLAGS),
> - COMPOSITE_NOMUX(0, "spdif_pre", "i2s_src", 0,
> - RK2928_CLKSEL_CON(5), 0, 7, DFLAGS,
> - RK2928_CLKGATE_CON(13), 13, GFLAGS),
> - COMPOSITE_FRAC(0, "spdif_frac", "spdif_pll", 0,
> - RK2928_CLKSEL_CON(9), 0,
> - RK2928_CLKGATE_CON(0), 14, GFLAGS),
> - MUX(SCLK_SPDIF, "sclk_spdif", mux_sclk_spdif_p, 0,
> - RK2928_CLKSEL_CON(5), 8, 2, MFLAGS),
>
> GATE(0, "hclk_imem0", "hclk_cpu", 0, RK2928_CLKGATE_CON(4), 14, GFLAGS),
> GATE(0, "hclk_imem1", "hclk_cpu", 0, RK2928_CLKGATE_CON(4), 15, GFLAGS),
prev parent reply other threads:[~2014-11-23 0:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 9:27 [PATCH] clk: rockchip: fix clock gate for rk3188 spdif_pre Julien CHAUVEAU
2014-11-23 0:58 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4871254.UVsZ9NLXxR@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox