From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02938C48BF6 for ; Sat, 16 Mar 2024 18:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6xym7CvTJaUOzbDHL9RBscNuvWWOZWYQAjQbH8ogxmc=; b=YfcevE7htW7NIZ 9YHYZ4uDeB8NeCcVHcKn0RZ/D3JsH/NLru45nLxzlUo5MqPbAG4itrfxNZSiO4Y3yhs8C6XoqDXuW OhyOu73eFR9uYobE6VEuxYdEO3hghhrCZ24CYb/YuPKDvQ84I+yWDpwT9VHVaFEIGxF+TBqcBBbrh jaYRcNeSub/peLBOr7w6ypyAkgRi2UgsKz45QlyU7PkgfZUsfLPKgzsCKrCGScScIG5R3FyGW/Pjh EW9AdiK8iSghALrMTM8QxCLFRs6L8FJjFR2nlOhwkQqjTs3EI24TqGkENrNWFDegL6ZOTsX1pfkb4 UOayOwtktbtBgiCe0qHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlYQx-00000003d8h-1S0F; Sat, 16 Mar 2024 18:07:03 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlYQt-00000003d83-39IS for linux-arm-kernel@lists.infradead.org; Sat, 16 Mar 2024 18:07:01 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-33ececeb19eso1077124f8f.3 for ; Sat, 16 Mar 2024 11:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710612414; x=1711217214; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nkXOvUv3CSNMR4S1kVhCPDF0jvEWGHLqB/wYYzvRGeA=; b=ZnWcwYqkmYjwvl5acijRGdlBvlFiqZ1AQgAryg81X5/6TqQyhKMZhv6QAawq6NiaAq ME/YG6cYf5pi0WgZJFc60OB4PBICnDkB6sJiXxU4a41/QzqOp+qvyldOotQFUyW3J1jl 3/OiMO3TqKwsrUpeEqTmDJqcYJKnUxNazr1P/0PVZNKyBUn9dC1lPNVs9YwC/JyyLpM/ nEQq1PoRLj6f56hWqoxWbDl47qz014usoVWVDtZV5kaCGX+AoNq7gSPZvAbYCzs7OCar axyptwuPZYQpoJmygwML5zO9hf/TFIgSkX4xrrExsj3K776CnOnCREyWUNU6MU62/LUB lGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710612414; x=1711217214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nkXOvUv3CSNMR4S1kVhCPDF0jvEWGHLqB/wYYzvRGeA=; b=H/oitpS0zX8GMSXvIa7/QgmnhD/4N1MqWWjufQbHBTkCZ95Ua2nZm37uLjfGqdtZO0 +8cOulDiDhN5mzSSOp6RKpXSXMKPjVE9MhxY59gogXs4rl1v8NTsoFPOGAtN38eME4/m Uy7cTBMm8aLvVb82N6NvCfJAfeGlRmCRzzSuQCwNPYsrMNfK257epumBWRYlHPaEL+B4 QIcj965NkbEA2sBGaTS1WaDaB6ExAKsykhlcwAyYf770HfflhuwpzoB6q2pAaUXUUfVp 0uAAArFwGDqq7dotQr+6qQC837pth/nEoOIS6Qmbme/7+DMEOGG4E/Wb8uQHKFSQygeU iPSw== X-Forwarded-Encrypted: i=1; AJvYcCX0tvFJ/+srRn6XUdDdE/y655fxpIJ4EAGQwJi0KHuJthcr7RiUjeAkMRvDd9B5qnniNp3mWpHu9/iGLEWQle/DqozJM5OIiRLBg2kZcFgL2wH8dzs= X-Gm-Message-State: AOJu0YyLUWLfUq0LPJcmgnyMmzUcBEp8isgrWZbgUyAZqfwo3yRKDtXY F8BOWeEQxhk5JZp6BA7RXDpp7QQP6DR31hOyn1eC26694Sy4PK97mv1slpHV X-Google-Smtp-Source: AGHT+IGSc8+4gLqhuW2+RC7eeLKzM/1sXFmJ44RO3jrxC607yA6pvzIwN0uty2HMBlnpP8E4Y5aOXQ== X-Received: by 2002:a5d:5412:0:b0:33e:c539:977d with SMTP id g18-20020a5d5412000000b0033ec539977dmr4764352wrv.22.1710612413685; Sat, 16 Mar 2024 11:06:53 -0700 (PDT) Received: from jernej-laptop.localnet ([188.159.248.16]) by smtp.gmail.com with ESMTPSA id r15-20020a5d694f000000b0033ec6a1b37esm5911643wrw.8.2024.03.16.11.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Mar 2024 11:06:53 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Denis Burkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Denis Burkov Subject: Re: [PATCH v2] ARM: dts: sun5i: Add PocketBook 614 Plus support Date: Sat, 16 Mar 2024 19:06:51 +0100 Message-ID: <4874817.GXAFRqVoOG@jernej-laptop> In-Reply-To: <20240316144429.12529-1-hitechshell@mail.ru> References: <4203654.1IzOArtZ34@jernej-laptop> <20240316144429.12529-1-hitechshell@mail.ru> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240316_110659_834231_465D378C X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Denis! Before I review, please resend this series properly. It shouldn't be sent as response to old series, but as a new thread. Also, it has to be complete, in this case with first patch, with review/ack tags where applicable. Best regards, Jernej Dne sobota, 16. marec 2024 ob 15:39:18 CET je Denis Burkov napisal(a): > What works: > > - Serial console > - mmc0, mmc2 (both microSD card slots on the board) > - All buttons (gpio and lradc based) > - Power LED > - PMIC > - RTC > - USB OTG/gadgets mode > > Signed-off-by: Denis Burkov > --- > arch/arm/boot/dts/allwinner/Makefile | 1 + > .../sun5i-a13-pocketbook-614-plus.dts | 215 ++++++++++++++++++ > 2 files changed, 216 insertions(+) > create mode 100644 arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts > > diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/allwinner/Makefile > index 5fbb44ddacd0..6209243ad975 100644 > --- a/arch/arm/boot/dts/allwinner/Makefile > +++ b/arch/arm/boot/dts/allwinner/Makefile > @@ -61,6 +61,7 @@ dtb-$(CONFIG_MACH_SUN5I) += \ > sun5i-a13-olinuxino.dtb \ > sun5i-a13-olinuxino-micro.dtb \ > sun5i-a13-pocketbook-touch-lux-3.dtb \ > + sun5i-a13-pocketbook-614-plus.dtb \ > sun5i-a13-q8-tablet.dtb \ > sun5i-a13-utoo-p66.dtb \ > sun5i-gr8-chip-pro.dtb \ > diff --git a/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts b/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts > new file mode 100644 > index 000000000000..b5449301789a > --- /dev/null > +++ b/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts > @@ -0,0 +1,215 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2024 Denis Burkov > + */ > + > +/dts-v1/; > +#include "sun5i-a13.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > +#include > + > +/ { > + model = "PocketBook 614 Plus"; > + compatible = "pocketbook,614-plus", "allwinner,sun5i-a13"; > + > + aliases { > + serial0 = &uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + led { > + gpios = <&pio 4 8 GPIO_ACTIVE_LOW>; /* PE8 */ > + default-state = "on"; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + key-right { > + label = "Right"; > + linux,code = ; > + gpios = <&pio 6 9 GPIO_ACTIVE_LOW>; /* PG9 */ > + }; > + > + key-left { > + label = "Left"; > + linux,code = ; > + gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 */ > + }; > + }; > + > + reg_3v3_mmc0: regulator-mmc0 { > + compatible = "regulator-fixed"; > + regulator-name = "vdd-mmc0"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 4 4 GPIO_ACTIVE_LOW>; /* PE4 */ > + vin-supply = <®_vcc3v3>; > + }; > +}; > + > +&cpu0 { > + cpu-supply = <®_dcdc2>; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&i2c0 { > + status = "okay"; > + > + axp209: pmic@34 { > + compatible = "x-powers,axp209"; > + reg = <0x34>; > + interrupts = <0>; > + }; > +}; > + > +#include "axp209.dtsi" > + > +&i2c1 { > + status = "okay"; > + > + pcf8563: rtc@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + #clock-cells = <0>; > + }; > +}; > + > +&lradc { > + vref-supply = <®_ldo2>; > + status = "okay"; > + > + button-300 { > + label = "Down"; > + linux,code = ; > + channel = <0>; > + voltage = <300000>; > + }; > + > + button-700 { > + label = "Up"; > + linux,code = ; > + channel = <0>; > + voltage = <700000>; > + }; > + > + button-1000 { > + label = "Left"; > + linux,code = ; > + channel = <0>; > + voltage = <1000000>; > + }; > + > + button-1200 { > + label = "Menu"; > + linux,code = ; > + channel = <0>; > + voltage = <1200000>; > + }; > + > + button-1500 { > + label = "Right"; > + linux,code = ; > + channel = <0>; > + voltage = <1500000>; > + }; > +}; > + > +&mmc0 { > + vmmc-supply = <®_3v3_mmc0>; > + bus-width = <4>; > + cd-gpios = <&pio 6 0 GPIO_ACTIVE_LOW>; /* PG0 */ > + status = "okay"; > +}; > + > +&mmc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc2_4bit_pc_pins>; > + vmmc-supply = <®_vcc3v3>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&otg_sram { > + status = "okay"; > +}; > + > +®_dcdc2 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1500000>; > + regulator-name = "vdd-cpu"; > +}; > + > +®_dcdc3 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + regulator-name = "vdd-int-dll"; > +}; > + > +®_ldo1 { > + regulator-name = "vdd-rtc"; > +}; > + > +®_ldo2 { > + regulator-always-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-name = "avcc"; > +}; > + > +®_usb0_vbus { > + status = "okay"; > + gpio = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > +}; > + > +®_usb1_vbus { > + gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */ > + status = "okay"; > +}; > + > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pg_pins>; > + status = "okay"; > +}; > + > +&usb_otg { > + dr_mode = "otg"; > + status = "okay"; > +}; > + > +&usb_power_supply { > + status = "okay"; > +}; > + > +&battery_power_supply { > + status = "okay"; > +}; > + > +&usbphy { > + usb0_id_det-gpios = <&pio 6 2 GPIO_ACTIVE_HIGH>; /* PG2 */ > + usb0_vbus_det-gpios = <&axp_gpio 1 GPIO_ACTIVE_HIGH>; > + usb0_vbus-supply = <®_usb0_vbus>; > + usb1_vbus-supply = <®_usb1_vbus>; > + status = "okay"; > +}; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel