From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1645DC54E64 for ; Mon, 25 Mar 2024 15:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ohh6olQz/TbLFQe2Mc9AeUnSvciS9IsavGwnYXmWL6s=; b=RuintmqPgzc2Dq T/KM9POuO9X8hSOiCTsXdZuzV+6JlcM6q5wm5kceHRp8YfKrru/GXHlskdR3x9kCCRE4Z4Lt464R6 1DsNYbQwp272z/mBkq2qzaHeVp/rxaDsl1PuMFEsPyoZeoeGFeclNY7GMr4kOKNJwqK3fraNhdukp lJ2SXDXRdSDOsw5nAMi1I4Dh9lnTPUbd2VtOHkAhr7EB7yRpc5cSEJahKvs7iJjhFCtH+6RKvnObQ SOpqHz38Av1PabDZ/VITEVMa5pJ/gjbnhWwPfc9bM/U+SyCqk2l6NZz4/CF3NMbatQvE0ec1HLVwI KU6rslTWogdVpJPVr9Eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1romch-00000000bUd-0ZCD; Mon, 25 Mar 2024 15:52:31 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1romcb-00000000bPv-0oyr for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2024 15:52:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1711381945; x=1742917945; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QtCjA8jF6LdIH1jHhbsQNsROhaw0D6l+AUhvNB1YUh4=; b=U0Ekhwr3FDMvYGkNcr3Kk5/gklshgzq+X0Z1XBGh65kc3k4xmzxDIJ1v xRkJagoo5a8wP1s0xexo4B6x+xukg0rj7T+KDmtn2/tijBGt1k2pMD34+ 0HJp1pZmFnqSEw70554wQiX6n4KI9g7gdm7sDvNIEBOFdWA0oBea6Sf+k 2a+599AYUuXrjVYbRgG3j7jC6tYCIm6lQ1ywiVaMonLUTIOhQsvksavCp WWlkFqNNygzdGJZFaY6Opbf60Kjpr66ms75K8ITABNbBewM4NfHxDFUST 4hzSAn1aTg3aYUTKwV2U9k5NyPGtHevjDXUogeZc7YFDKDjtSCvpVzkh2 Q==; X-IronPort-AV: E=Sophos;i="6.07,153,1708383600"; d="scan'208";a="36084202" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 25 Mar 2024 16:52:20 +0100 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 43E5B160A85; Mon, 25 Mar 2024 16:52:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1711381936; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=QtCjA8jF6LdIH1jHhbsQNsROhaw0D6l+AUhvNB1YUh4=; b=bAOTpY5jeZxEyk1N5ffRgkuPA+mQKdjnHFCeTHgLr26+KFrqRQ3Vr141ZwYVr41U4oRcuO St+eFfnSAypOBgpZXiFxGQuVOY6/M31vwbD/bjAaN2DlTeQQcbjU5pZwWH8fB/E+8evECo BlbUwvf6XxHCOgI5/vP3wV4NE76RK8OsGDXVgQPowYs86Ckn3B9Fz6WsIAxTIKMeHdjLQW p0uJi/AbRclSTD26bxDrTaAGBDilGnqB0BATMPmPfutN/KnKX+KXhNfcimuyMbWpylI3sJ xqo7itoUJI5XzHxYZwS0wUzk15TxJisYMDjXX3yzBQcFHHhdeO3cBtPT3LLCRQ== From: Alexander Stein To: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Laurent Pinchart Cc: Paul Elder , Adam Ford , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Marek Vasut , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mp: Add DT nodes for the two ISPs Date: Mon, 25 Mar 2024 16:52:21 +0100 Message-ID: <4879631.GXAFRqVoOG@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240325151339.19041-1-laurent.pinchart@ideasonboard.com> References: <20240325151339.19041-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240325_085227_531239_4F027EC2 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Montag, 25. M=E4rz 2024, 16:13:39 CET schrieb Laurent Pinchart: > From: Paul Elder > = > The ISP supports both CSI and parallel interfaces, where port 0 > corresponds to the former and port 1 corresponds to the latter. Since > the i.MX8MP's ISPs are connected by the parallel interface to the CSI > receiver, set them both to port 1. > = > Signed-off-by: Paul Elder > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > = > - Fix clock ordering > - Add #address-cells and #size-cells to ports nodes > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 50 +++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > = > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/= dts/freescale/imx8mp.dtsi > index bfc5c81a5bd4..1d2670b91b53 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1616,6 +1616,56 @@ isi_in_1: endpoint { > }; > }; > = > + isp_0: isp@32e10000 { > + compatible =3D "fsl,imx8mp-isp"; > + reg =3D <0x32e10000 0x10000>; > + interrupts =3D ; > + clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; > + clock-names =3D "isp", "aclk", "hclk"; > + assigned-clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP>; > + assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL2_500M>; > + assigned-clock-rates =3D <500000000>; > + power-domains =3D <&media_blk_ctrl IMX8MP_MEDIABLK_PD_ISP>; > + fsl,blk-ctrl =3D <&media_blk_ctrl 0>; > + status =3D "disabled"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@1 { > + reg =3D <1>; > + }; > + }; > + }; > + > + isp_1: isp@32e20000 { > + compatible =3D "fsl,imx8mp-isp"; > + reg =3D <0x32e20000 0x10000>; > + interrupts =3D ; > + clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > + <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; > + clock-names =3D "isp", "aclk", "hclk"; > + assigned-clocks =3D <&clk IMX8MP_CLK_MEDIA_ISP>; > + assigned-clock-parents =3D <&clk IMX8MP_SYS_PLL2_500M>; > + assigned-clock-rates =3D <500000000>; > + power-domains =3D <&media_blk_ctrl IMX8MP_MEDIABLK_PD_ISP>; > + fsl,blk-ctrl =3D <&media_blk_ctrl 1>; > + status =3D "disabled"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@1 { > + reg =3D <1>; > + }; > + }; > + }; > + The patch itself is okay. But you might not be able to configure the parent of IMX8MP_CLK_MEDIA_ISP if dewarp is enabled before. This is due to IMX8MP_CLK_MEDIA_ISP_ROOT being enabled in 'pgc_ispdwp' power domain. Reparenting is not possible anymore in this case. Something like ---8<--- --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1837,11 +1837,13 @@ media_blk_ctrl: blk-ctrl@32ec0000 { <&clk IMX8MP_CLK_MEDIA_AP= B>, <&clk IMX8MP_CLK_MEDIA_DI= SP1_PIX>, <&clk IMX8MP_CLK_MEDIA_DI= SP2_PIX>, + <&clk IMX8MP_CLK_MEDIA_IS= P>, <&clk IMX8MP_VIDEO_PLL1>; assigned-clock-parents =3D <&clk IMX8MP_SYS= _PLL2_1000M>, <&clk IMX8MP_SYS_P= LL1_800M>, <&clk IMX8MP_VIDEO= _PLL1_OUT>, - <&clk IMX8MP_VIDEO= _PLL1_OUT>; + <&clk IMX8MP_VIDEO= _PLL1_OUT>, + <&clk IMX8MP_SYS_P= LL2_500M>; assigned-clock-rates =3D <500000000>, <2000= 00000>, <0>, <0>, <103950000= 0>; #power-domain-cells =3D <1>; ---8<--- is needed. Best regards, Alexander > dewarp: dwe@32e30000 { > compatible =3D "nxp,imx8mp-dw100"; > reg =3D <0x32e30000 0x10000>; > = > base-commit: 4cece764965020c22cff7665b18a012006359095 > = -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel