From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C7EBC001DF for ; Fri, 20 Oct 2023 14:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ooBPdeud8ebsEZ+jNEuq8DF+bC2xrLykV26gXFXd5Og=; b=Opo+rNjK7aO90e ApN4KVEKIoN+qNCtiMh/EqqxCgBAENh9J2T7EtgUfDf/yf1LkWYUnKqqxTCOPecxX4//fRcFToQgt 9NQAqF2LJNjtWZ5LDix+8rxpKxrVGf5hizMugyO5cwTVMHy7+N3FVn2PpmWlpFYBR5uMjnNxaQ/bA dkauATh2o7OrmecohPRks5VSYij6u4Np0ddCyDAO+X7MSTo/ZQARZU/Gd9GWJJ6RlISyypZIugaFb uX+DtwHCsEGKbEvGxn3NFDms6qvL7TkBshD9FLF1RwiakBW3/5Pxb+OFc/x0c1HTjh7ASSvLYEx+6 rNwz6VeHueJwUDwCiPeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtqBA-002SQn-2s; Fri, 20 Oct 2023 14:08:44 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtqB8-002SQM-02 for linux-arm-kernel@lists.infradead.org; Fri, 20 Oct 2023 14:08:43 +0000 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso12815301fa.0 for ; Fri, 20 Oct 2023 07:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697810918; x=1698415718; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JMflfsDmr9yqToB8PqgOeqaiOA6GNOMvcqe9gF64FHI=; b=JESRH3bM5mR47ecCfeGn2oN0pzJJxnnX2r12Grc3D4BwPsh7eOlkhZQ8AviykiwGdy 44ERDs8EB4vqzu3/qI2L6TwGjnqRZhqaC3ShA08nKeTArK2rGI/Qfa3I19QqeprLaQwD bwPzodxDaNhK7JQXq+MR45kJ+KJ1kz/vlcGLr2RZzVpiP+ROJaAF7B4gGqnd9ZOPp12R 3x5vq9X1q0RYbcPlbxhGiS5y0RwnKo+FyzBcnL5NJ4/3uT5IQAaGiVPzhe6/fqm1Onff 6T0zJ3O+xjECcJQHkEWaDcNoSdGtHwGeI6hrC0XkQQd9vqDzdTzSavPNS0b8odq53XhW CMYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697810918; x=1698415718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JMflfsDmr9yqToB8PqgOeqaiOA6GNOMvcqe9gF64FHI=; b=ddpi9V7dEw+vY4uIqyWNBp5P4rZ+MoR5WQD5MGm3z+ydYHjJ3hQHxIdPPDPL/WusiZ yFQJKdEJPJD01zNENPZOuQONZ3JygWgCY5M3QIxB70qX3w5kCIqq6D6Eo6OqGTH+g2uY o9HOWEvB7HTo+rEbVq/8ipW5Fh9W+C+ogisQOujmkgjVBLSA/MvIixcnVyrgnbJpS2ZK 7nyMhdEX8eTIoT9hfn4yjenWI4UTGpm4fb6gPio9EBFtY9nBWA2dAB25iA4scPmvo00Q rRI4GpgODbK/jo2Y9AbgjEPedUFxJIFkGkVsPseS3MmUR0AQhtul8Z0++cfh6DWkLUD2 yhDQ== X-Gm-Message-State: AOJu0YyHXzguzjUin8sJYllEExy4d9nHp/uWrcgU6me/Fx2auXCvVTwl ykC1ZrUzXnIofgLpsTUAR9A= X-Google-Smtp-Source: AGHT+IEtk/yAj3a8PCb0KZzldeCx2CbR79ZxGh0hDIudcXsx+etyQ8nDzlijIASYKTsxGNlegWLaLA== X-Received: by 2002:a2e:9a8a:0:b0:2bf:b133:dd65 with SMTP id p10-20020a2e9a8a000000b002bfb133dd65mr1330993lji.38.1697810917790; Fri, 20 Oct 2023 07:08:37 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id j14-20020a05600c130e00b0040772934b12sm6964862wmf.7.2023.10.20.07.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 07:08:37 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Herbert Xu , "David S. Miller" , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Corentin Labbe , Chen-Yu Tsai , Samuel Holland , Jonathan Corbet , Rob Herring , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 01/42] crypto: sun4i-ss - Convert to platform remove callback returning void Date: Fri, 20 Oct 2023 16:08:35 +0200 Message-ID: <4886899.31r3eYUQgx@jernej-laptop> In-Reply-To: <20231020075521.2121571-45-u.kleine-koenig@pengutronix.de> References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-45-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_070842_083830_185B0A63 X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 20. oktober 2023 ob 09:55:23 CEST je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- Reviewed-by: Jernej Skrabec Best regards, Jernej > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/= crypto/allwinner/sun4i-ss/sun4i-ss-core.c > index 3bcfcfc37084..ba80878e2df5 100644 > --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c > +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c > @@ -509,7 +509,7 @@ static int sun4i_ss_probe(struct platform_device *pde= v) > return err; > } > = > -static int sun4i_ss_remove(struct platform_device *pdev) > +static void sun4i_ss_remove(struct platform_device *pdev) > { > int i; > struct sun4i_ss_ctx *ss =3D platform_get_drvdata(pdev); > @@ -529,7 +529,6 @@ static int sun4i_ss_remove(struct platform_device *pd= ev) > } > = > sun4i_ss_pm_exit(ss); > - return 0; > } > = > static const struct of_device_id a20ss_crypto_of_match_table[] =3D { > @@ -545,7 +544,7 @@ MODULE_DEVICE_TABLE(of, a20ss_crypto_of_match_table); > = > static struct platform_driver sun4i_ss_driver =3D { > .probe =3D sun4i_ss_probe, > - .remove =3D sun4i_ss_remove, > + .remove_new =3D sun4i_ss_remove, > .driver =3D { > .name =3D "sun4i-ss", > .pm =3D &sun4i_ss_pm_ops, > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel