From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 690B9C3DA7F for ; Wed, 7 Aug 2024 21:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H/bmxju7ZLwzIAH8jlEDDreLMssuhznvKRpLl5JRJbc=; b=qySDZCO9FBzclCvYbg/4cG7GR/ XtS8CYz8FS8XK2VXaLoRepYkWNhqgpi43sqOwqeEihHrCnTWMOPLAz66s9BasPm0md8IHa5VE4sAN y2zLc1q+X/UwhH220TqYJ71SbDAE+9qCPmnem7kXqFsWPEnEF/xxyIif5Fkqw11csooCPPCeT1gek +V+UuDicFvYiFmlcGGVAfyziv9IhOOoIlSIvExjXZg+zYtWitbXkyOxt81W2zbMenxtTCMef8qIhD 7raDkc3ugxZjrvCm7F7dNAB7wNDNC5m+Hdxx38Wlyz6C/JFIhJ5Q00C6aBwhWamfcRU3WOuy6tTzy xr+FiaLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbnyL-00000006HdE-3ZHz; Wed, 07 Aug 2024 21:13:30 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbnxj-00000006HML-2UFu; Wed, 07 Aug 2024 21:12:52 +0000 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ef2d96164aso2321791fa.3; Wed, 07 Aug 2024 14:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723065169; x=1723669969; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/bmxju7ZLwzIAH8jlEDDreLMssuhznvKRpLl5JRJbc=; b=QE0sIj8gkNT2rrXA2GGIFNbADoDPAulZxc+dYP7HX6FQ+2W4AdlFbKSQokdyynzg87 z91f7kvoyixG5xtFPwZlmHTlFqM4hJ6JTyHtzW11Xv0JOk9Kci+zLCHVPXd5UDwVttAZ Tp4OdYzplupnMsdKPGoplcMtgiXfxiR3UDVejxC48yrxbYivbo3molhajapsAWqAViTT dS3bvJDL5P0G7/GIMAwwICbJ2KGNi9m9Sy3xZkth9Yqs+UF6sCDj1l4M3IajHulGcebb eicpt8/JRg+UJZMBkVdGTl2jV/+B8aKYNCRiaWrw8SGlzp4kP3A4qD8uXxEZYEcqQ9/L fExA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723065169; x=1723669969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H/bmxju7ZLwzIAH8jlEDDreLMssuhznvKRpLl5JRJbc=; b=SXwf0p875XmcfQDlcQ8UXSTf86aG5sgOrEhkUf3qpRGAFFPmXC+v3KfEmt2TAjnbKZ s+gCl/mWGgbg9+19W7O3yXFvB1uzVSUjkcTy5wnXks35+fgiioa2QsnyWVIimRdqnntP UoXV2td5sn0NHoVqxdyL9E3F6HCvoz9eLpSBxQ7wi75rm/sA/49NejKCdj38rsPd9tLm m1TF9tz6pUWLwG33Y3SXyzqzDkOtN7fR+3huFYtZYyjNujzlKaqVC/hpXoRcZhmEncgm dYzhCf9aqE5x8TwOHar6Gv9cOTqU8xA6S2E3jc+8XCfuPPDsbboL7nY3O9z985zqNVan DO7Q== X-Forwarded-Encrypted: i=1; AJvYcCWSUkYzm9Ev9GTzJrgKAQxMpH+ZK021PAVIoY1imrWXUXx01yf+Os0Q0iTZ1eyMejXKHLtRJCo6hU6v/T3AXbY=@lists.infradead.org, AJvYcCWzWJDNO5c2ihEuwylc0hitoYrdD20AZy4MmwNaWEdMnQ50oZ4YwhvYuC5bkdm5kKAFjF3u7txUlkZTC8QRnwfY@lists.infradead.org X-Gm-Message-State: AOJu0Yw9A1icz0THuD1zFGNpFLS1KTSNmqvIFhAIww2S3abYIE/baSln A1XJ+L8sC6QYU/5a6K38jvKBc7LwMGKyq/4GkNfKe4hI6Me2p69H X-Google-Smtp-Source: AGHT+IHY8G93+4dqsOW2PvS20aHLKtl2r2rEMnKjeoACncKdu2CAA+R9R8DzuDfiVZbRYFJwm7/qJg== X-Received: by 2002:a2e:3002:0:b0:2f0:2833:efaa with SMTP id 38308e7fff4ca-2f15aac3960mr127650011fa.25.1723065168562; Wed, 07 Aug 2024 14:12:48 -0700 (PDT) Received: from latitude-fedora.localnet ([31.173.83.209]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f15e1adf63sm19884571fa.40.2024.08.07.14.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 14:12:47 -0700 (PDT) From: Alexey Charkov To: Florian Klink , linux-rockchip@lists.infradead.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Kever Yang , Muhammed Efe Cetin , FUKAUMI Naoki , =?utf-8?B?VGFtw6FzIFN6xbFjcw==?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dragan Simic Subject: Re: [PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus Date: Thu, 08 Aug 2024 00:12:46 +0300 Message-ID: <4888470.OV4Wx5bFTl@latitude-fedora> In-Reply-To: <1b2e1b1b321f84f5cbff2ae18c3eba2e@manjaro.org> References: <20240807162001.1737829-1-flokli@flokli.de> <1b2e1b1b321f84f5cbff2ae18c3eba2e@manjaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_141251_655592_1A741D04 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday, August 7, 2024 9:32:51=E2=80=AFPM GMT+3 Dragan Simic wrote: > On 2024-08-07 20:14, Florian Klink wrote: > > On Wed, Aug 07, 2024 at 07:24:27PM GMT, Dragan Simic wrote: > >> On 2024-08-07 19:00, Florian Klink wrote: > >>> This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: > >>> add > >>> rfkill node for M.2 Key E WiFi on rock-5b"). > >>>=20 > >>> On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi > >>> enable signal inside the M.2 Key E slot. > >>>=20 > >>> The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 > >>> kernel > >>> rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable` > >>> node referencing RK_PC4 on &gpio0. > >>>=20 > >>> Signed-off-by: Florian Klink > >>> Tested-by: Florian Klink > >>=20 > >> I forgot to mention that providing a Tested-by tag is redundant when > >> there's already a Signed-off-by tag, because the latter already > >> implies > >> the former. > >=20 > > This came after I sent the v3. Generally I wish people would test > > things > > - though too often it's not. I explicitly tested this to work (with a > > wifi module added to that slot being unblock-able afterwards), and > > wanted to point that out, thus adding the Tested-by. >=20 > In general, some time should be allowed between sending consecutive > versions of the same patch, so people can provide their feedback. >=20 > When it comes to testing the submitted patches, please note that signing > off a patch implies that the signer has already, to the best of their > abilities, made sure that the patch works as described and expected. >=20 > With all that in mind, please allow me to repeat that a Tested-by tag > should not be provided from the same person that the Signed-off-by tag > is already coming from. It's simply redundant. Just two cents: perhaps dropping the tag and expanding the commit message a= =20 bit could be the best of both worlds. Just state that you tested it with su= ch=20 and such module, observing such and such results. That would also help if f= or=20 example another user tries a different module and that fails due to some=20 quirks: it's easier to debug a potential issue when one knows a working=20 configuration to compare a non-working one against. Best regards, Alexey