From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19D10C4167B for ; Sat, 25 Nov 2023 19:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/c4463a2/CZVL4jT4tI2lu0FqMrqbAbijBjweUNWE9Q=; b=Gi/IHUeTNjuN/pQHmphD3Cxnj/ QvhuBB63uyUKlBEmfzldPuOREYM+eLBE1Mc14kES5vG0jqiQz3n72b0bCndBA8bpsixzsbH/+Ioxg kRQ+2N0/Ova+/hhxLwFtwK1tPcMx2ecM+DvTPBesiN/3xSGhDBgfRUKgHePKtQQdBOQzVJ2jXfXwF C/AYa9IZmczFEBg3gLeAt2AyDqMN6NSfEu93sg9GjjtOUlen34b0CatXva8eq1X7JXBsKxbozXBwH DG23VShPeC8EAPEF2TrfNDQji1qirnxuXk3ep299MuzUZjs0rMgnMwdsMIp9JJWhp5i2udX5e8C/t CUYN5kCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6yTc-009ina-0U; Sat, 25 Nov 2023 19:38:04 +0000 Received: from out-175.mta0.migadu.com ([2001:41d0:1004:224b::af]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6yTY-009ilW-2a for linux-arm-kernel@lists.infradead.org; Sat, 25 Nov 2023 19:38:02 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1700941074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H5f532XiEqN+dHjGZRkOt1oPFlKTC6DZJMlN+VbFtsU=; b=ufYkpuee0qkj86lH4MdGhj+LWt9I/eUDyQDn8dwJNlku1uKFyM7lZqGgMMHB/bvSEMIs/J m/UUjHpywGLEilnS7PmNmJIr5I2R54dcDuNwe5S0PG992f2fP3wbiS6gUHDsK/cQSACrkz LIpseWwAcag9x51yEk9XLvyryvbYMorpXpupKxelNZI6nD5rrjXOK6GIpBNUxz5nQ0aaMc 5+luFjm1guQTM512p7hnsUfPBIDjJSoIHmzQ6aeoN/h9PVGLhkfKuEZOqrdayT417aX6KU qlz2kPJqLncwRd6Y2NvhzzVV+5GtVDHMrm93qKMEh6JGsoU0o5xYFspQDQRRwA== From: Diederik de Haas To: Heiko Stuebner , Catalin Marinas , Will Deacon , Jagan Teki , Lorenz Brun Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3] arm64: defconfig: Enable GPIO_SYSCON Date: Sat, 25 Nov 2023 20:37:44 +0100 Message-ID: <4890462.KFe8axKcMy@bagend> Organization: Connecting Knowledge In-Reply-To: <20230719102427.3617577-1-jagan@amarulasolutions.com> References: <20230719102427.3617577-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231125_113801_045896_EC6D3421 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2048342870168746162==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2048342870168746162== Content-Type: multipart/signed; boundary="nextPart4424799.KjT0GdQ6BB"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart4424799.KjT0GdQ6BB Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Diederik de Haas Subject: Re: [PATCH v3] arm64: defconfig: Enable GPIO_SYSCON Date: Sat, 25 Nov 2023 20:37:44 +0100 Message-ID: <4890462.KFe8axKcMy@bagend> Organization: Connecting Knowledge In-Reply-To: <20230719102427.3617577-1-jagan@amarulasolutions.com> References: <20230719102427.3617577-1-jagan@amarulasolutions.com> MIME-Version: 1.0 On Wednesday, 19 July 2023 12:24:27 CET Jagan Teki wrote: > roc-rk3328-cc board has vcc_sdio regulator controlled by a special > output only gpio pin. This special pin can now be reference as > <&grf_gpio 0> via gpio-syscon driver, as mentioned in below commit. > > commit <99165b93dafe> ("arm64: dts: rockchip: add sdmmc UHS support for > roc-rk3328-cc") > > So, enable bydefault on the defconfig. > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 6cbf6eb59378..70cffd87aa36 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -619,6 +619,7 @@ CONFIG_GPIO_PCA953X_IRQ=y > CONFIG_GPIO_BD9571MWV=m > CONFIG_GPIO_MAX77620=y > CONFIG_GPIO_SL28CPLD=m > +CONFIG_GPIO_SYSCON=y > CONFIG_POWER_RESET_MSM=y > CONFIG_POWER_RESET_QCOM_PON=m > CONFIG_POWER_RESET_XGENE=y On my Rock64 (rk3328-rock64) I was getting the following error message: gpio-syscon ff100000.syscon:gpio: can't read the data register offset! Doing a `git bisect` led me to this commit. I can show the `git bisect` log, but I don't think it adds any value. This commit didn't cause the error ofc, but merely exposed an existing issue. I did see that rk3328-roc-cc.dts has an `vcc_sdio: sdmmcio-regulator` node which rk3328-rock64.dts doesn't have, but I have no idea if that should be added to Rock64's dts file. (Or how this issue can/should be fixed in general) For a long time I thought that the following error (in `dmesg`) is connected to it, as they (initially) show up together, but I'm not sure anymore. The compatible string which made me propose to add GPIO_SYSCON to Debian's kernel, is close to the `power-domain@RK3328_PD_HEVC` node in rk3328.dtsi. But after building a kernel without GPIO_SYSCON enabled, I still got (at least 1 time) the following error message: rockchip-pm-domain ff100000.syscon:power-controller: failed to get ack on domain 'hevc', val=0x88220 This error doesn't always show up, so maybe there's a timing issue involved? Cheers, Diederik --nextPart4424799.KjT0GdQ6BB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZWJNCAAKCRDXblvOeH7b bq50AQDMLSiBBI62SmPvF6rTId4Cwxyc/DHC2YdMI0kskXfKgAEA6BWNIoJDOoQ6 aB/ophkmojp+SgucLdV55g+Ek6LhNA0= =RFOm -----END PGP SIGNATURE----- --nextPart4424799.KjT0GdQ6BB-- --===============2048342870168746162== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2048342870168746162==--