From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29214C433E7 for ; Thu, 3 Sep 2020 04:53:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E51B620758 for ; Thu, 3 Sep 2020 04:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gM6D/uuZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BVmje1L0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E51B620758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bqW/fmYvsVWP3HhEIEDdsHrrPkmq40vM56idjMkq754=; b=gM6D/uuZpX3Qj9 wT6SrH2KBlfE3SGQGXEXAUh2gSBr2Eplbkb1G/v5Cex34kMsOwljj6oAEKyXazbtmGF6XaA3O2PwE DEzzFdaP1VaAnPMLKbRuu6w0Durpoq3jIHIJpFvZurgUdCCi9vym0PWQ1id73H4YAgOtC1PlmmgMW 1nQYs3+0cCBzXCRSk0faun6QG4lCUkmX82eBzD6nU2nOqDWKOllKDiivM7ciM2o6iqiwakhx+/zir /4Akqj6qw7UiuMOFoivfkzQyCRHNjG6yIUsScVxZVM8ZU5VzRiBYGUFgsU/UlxPN4giEs8DT1BmbS 2G9DwoQCMaHgdTXLiPoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDhEm-0005id-Hw; Thu, 03 Sep 2020 04:52:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDhEk-0005i5-DC for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 04:52:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599108757; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VWOp+tbzrhGchlgmDS2K9OH8i1hhwUvJ5w+LB5PcuWs=; b=BVmje1L0Cu/aRwOXELiAGoPntiiKl4RrlKVlFwsN+FbVFWp0nukop32xlfyx1NfBoGUgtJ AlsbIgCV8OClSyz3z1qS1zvnf5/2UgLXJgz0LqZqb/K3is3wN9sUxDEb8mz970EGEeXC3w oFOVbKFLqrIi31pIyKheDstP2vfZVe4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-RQqsrtfFMC6ObPdVPUm_cQ-1; Thu, 03 Sep 2020 00:52:36 -0400 X-MC-Unique: RQqsrtfFMC6ObPdVPUm_cQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FB201005E66; Thu, 3 Sep 2020 04:52:34 +0000 (UTC) Received: from [10.64.54.159] (vpn2-54-159.bne.redhat.com [10.64.54.159]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 112685D6C4; Thu, 3 Sep 2020 04:52:31 +0000 (UTC) Subject: Re: [PATCH v3 15/21] KVM: arm64: Convert memslot cache-flushing code to generic page-table API To: Will Deacon , kvmarm@lists.cs.columbia.edu References: <20200825093953.26493-1-will@kernel.org> <20200825093953.26493-16-will@kernel.org> From: Gavin Shan Message-ID: <48972757-449f-292e-3b56-86a67549dbb9@redhat.com> Date: Thu, 3 Sep 2020 14:52:30 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20200825093953.26493-16-will@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=gshan@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_005238_517376_07ACA672 X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Cc: Suzuki Poulose , Marc Zyngier , Quentin Perret , James Morse , Catalin Marinas , kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On 8/25/20 7:39 PM, Will Deacon wrote: > From: Quentin Perret > > Convert stage2_flush_memslot() to call the kvm_pgtable_stage2_flush() > function of the generic page-table code instead of walking the page-table > directly. > > Cc: Marc Zyngier > Signed-off-by: Quentin Perret > Signed-off-by: Will Deacon > --- > arch/arm64/kvm/mmu.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > Reviewed-by: Gavin Shan > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index ca2c37c91e0b..d4b0716a6ab4 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -455,21 +455,10 @@ static void stage2_flush_p4ds(struct kvm_s2_mmu *mmu, pgd_t *pgd, > static void stage2_flush_memslot(struct kvm *kvm, > struct kvm_memory_slot *memslot) > { > - struct kvm_s2_mmu *mmu = &kvm->arch.mmu; > phys_addr_t addr = memslot->base_gfn << PAGE_SHIFT; > phys_addr_t end = addr + PAGE_SIZE * memslot->npages; > - phys_addr_t next; > - pgd_t *pgd; > - > - pgd = mmu->pgd + stage2_pgd_index(kvm, addr); > - do { > - next = stage2_pgd_addr_end(kvm, addr, end); > - if (!stage2_pgd_none(kvm, *pgd)) > - stage2_flush_p4ds(mmu, pgd, addr, next); > > - if (next != end) > - cond_resched_lock(&kvm->mmu_lock); > - } while (pgd++, addr = next, addr != end); > + stage2_apply_range_resched(kvm, addr, end, kvm_pgtable_stage2_flush); > } > > /** > Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel