[PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

[PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

[Arınç ÜNAL via B4 Relay]

From: Arınç ÜNAL <arinc.unal@arinc9.com>

The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
findings that support this. There's no bootstrapping option to change the
PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
address of the switch. So the reg property on the device tree is currently
ignored by the Linux driver.

Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
has this switch.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 7b5f3904ef61..03d6d920446a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -525,9 +525,9 @@ &mdio0 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-	switch@0 {
+	switch@1f {
 		compatible = "mediatek,mt7531";
-		reg = <0>;
+		reg = <0x1f>;
 
 		ports {
 			#address-cells = <1>;

---
base-commit: 0276d797531ea2d1865a04fbe54c659608f5788f
change-id: 20240314-for-rockchip-mt7531-phy-address-ba6c2fff485f

Best regards,
-- 
Arınç ÜNAL <arinc.unal@arinc9.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

[Heiko Stübner]

Am Donnerstag, 14. März 2024, 13:24:35 CET schrieb Arınç ÜNAL via B4 Relay:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
> findings that support this. There's no bootstrapping option to change the
> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
> address of the switch. So the reg property on the device tree is currently
> ignored by the Linux driver.
> 
> Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
> has this switch.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Fixes: c1804463e5c6 ("arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board")

> ---
>  arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 7b5f3904ef61..03d6d920446a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -525,9 +525,9 @@ &mdio0 {
>  	#address-cells = <1>;
>  	#size-cells = <0>;
>  
> -	switch@0 {
> +	switch@1f {
>  		compatible = "mediatek,mt7531";
> -		reg = <0>;
> +		reg = <0x1f>;
>  
>  		ports {
>  			#address-cells = <1>;
> 
> ---
> base-commit: 0276d797531ea2d1865a04fbe54c659608f5788f
> change-id: 20240314-for-rockchip-mt7531-phy-address-ba6c2fff485f
> 
> Best regards,
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

[Heiko Stübner]

Hey,

Am Donnerstag, 14. März 2024, 13:37:19 CET schrieb Arınç ÜNAL:
> Hello Heiko.
> 
> On 14.03.2024 15:31, Heiko Stübner wrote:
> > Am Donnerstag, 14. März 2024, 13:24:35 CET schrieb Arınç ÜNAL via B4 Relay:
> >> From: Arınç ÜNAL <arinc.unal@arinc9.com>
> >>
> >> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
> >> findings that support this. There's no bootstrapping option to change the
> >> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
> >> address of the switch. So the reg property on the device tree is currently
> >> ignored by the Linux driver.
> >>
> >> Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
> >> has this switch.
> >>
> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> > 
> > Fixes: c1804463e5c6 ("arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board")
> 
> Do I need to resubmit with this added, or would you add it while applying
> the patch?

nope, all good. b4 am should just pick up this trailer when it downloads
the patch from lore.kernel.org.

That's the reason I added it as a reply, as we're just in the middle of the
merge window right now.

Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

[Heiko Stuebner]

On Thu, 14 Mar 2024 15:24:35 +0300, Arınç ÜNAL wrote:
> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
> findings that support this. There's no bootstrapping option to change the
> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
> address of the switch. So the reg property on the device tree is currently
> ignored by the Linux driver.
> 
> Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
> has this switch.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f
      commit: a2ac2a1b02590a22a236c43c455f421cdede45f5

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel