From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8764C48BC4 for ; Wed, 14 Feb 2024 09:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zAZCgx1fjfVLoxxxtSaAeNHAAh8qyHG6TvXFAZNYsjo=; b=bUgRCLQFTlVSy0 qT16rcoO9PPU/y2VFzZ/2frDLNqyouywXtqDrywKdSHlJ77eyhsN48xb+b4kTD8DHITS+9Jp0ASD2 tlgteT2cGo3KZiGGMXQMf6Ke35p868C4sNylMv4OSI8NjhlShN3DuibpdRoRYQKlSux1GzakamSOl Qc8xepU8yMlOGI6UPNWZYVSFs3tyeRiO7mkEwCia6M/xmcVsEI0WbuowXVzMP/cxDW3TAs1UHGgTY HRMcs8Mzb0LsH67dnY7+JPwk2+gHmNgRgjqMF23VZRPEnLaNTeriyqSjXpjUN/FruLyXqv3Ke73nF 32rrUQtjsOE7jJGXsmMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raC0Y-0000000CSaf-22E6; Wed, 14 Feb 2024 09:56:50 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raC0V-0000000CSYH-2M2v for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 09:56:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1707904607; x=1739440607; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p01ow5ep8fwBVxzZbzIDQJc3KANZTUhx4PNf1N4cNa8=; b=lhtgQv0dW5LT008bibYsWqZZJyoOD/JHq+0t37mkOGiDcdI7f2JGEE3c t3BLv0Tlf6kGi8FaoI760trYnvUFxWaK6LDHxmEH56/POVd4QNU0Q8pO2 x4Wp9GdcUgS7Fxcv7s38W8OuPDbW6+JscyVuaeoYdoRhhXxeXOdrqtsH/ pl/tuX7GJXSpztgSmzrAMtogAy+rAMsD0xUb/4is6vz5c9shM9TM2oJ9W pCkNMGf+3Ps7OzMrDTyp0gxF0cDU7lst3W9NM99Zku87dI5nQaBOoPOWA WD9AGx5+98P5Cltw5iNNcPcmJT8c+FW2IunjQsBpGMJm0antZNy8xWLiV A==; X-IronPort-AV: E=Sophos;i="6.06,159,1705359600"; d="scan'208";a="35399440" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 14 Feb 2024 10:56:43 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id EFAB0280075; Wed, 14 Feb 2024 10:56:42 +0100 (CET) From: Alexander Stein To: Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com Subject: Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible Date: Wed, 14 Feb 2024 10:56:44 +0100 Message-ID: <4899550.31r3eYUQgx@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240212223501.GA2674720-robh@kernel.org> References: <20240110100526.478771-1-alexander.stein@ew.tq-group.com> <20240212223501.GA2674720-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_015647_996377_9D1FE56D X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, thanks for the feedback. Am Montag, 12. Februar 2024, 23:35:01 CET schrieb Rob Herring: > On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > > Now that there is a dedicated compatible for the idendification page use > > that instead. This also allows the removal the size and pagesize > > properties. > = > This commit message fails to answer Why? The original DT entry using the regular "atmel,24c64" compatible is just a = workaround. The size and pagesize properties are added to match that dedica= ted = memory block. > And fails to mention the ABI break. Can you elaborate the ABI break? > = > > Signed-off-by: Alexander Stein > > --- > > = > > arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > = > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi index > > f6e422dc2663e..9d2328c185c90 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { > > = > > /* protectable identification memory (part of M24C64-D @57) */ > > eeprom@5f { > > = > > - compatible =3D "st,24c64", "atmel,24c64"; > > + compatible =3D "atmel,24c64d-wl"; > = > This compatible is not documented. Please add it to schema. It already is. Please refer to commit 0997ff1fc1436 ("dt-bindings: at24: ad= d = ST M24C64-D Additional Write lockable page"). Thanks, Alexander > > reg =3D <0x5f>; > > = > > - size =3D <32>; > > - pagesize =3D <32>; > > = > > vcc-supply =3D <®_v3v3>; > > = > > }; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel