From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD30C433E2 for ; Tue, 8 Sep 2020 08:40:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14BCB215A4 for ; Tue, 8 Sep 2020 08:40:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yNc+P5eX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ABlmjheu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14BCB215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BuvpkI0aPA1bOergWWlg4LlcE0ZSSZoM50ZpyigCdjE=; b=yNc+P5eXrPHTLp/BqBoNuWylV x0d44OdzTfH0sLlOMaq0s6vmUU4arLNBYte5CQqqCkx1ZkpbYJSMpwMEog3TiYvuzsxWzpUq7n99t rccVJGhftVJBNs/R/tzuaWQvtP2bzbTQMEuIugvooV0kDX5PpwUQXasFvxxuLpg4HUgLoyJ1wcdgU lk39wuI2xMjQuNyQD0ypjyzFCAE6UOw6gIzNWXfP2DzR3MyWb6ajv7IbFJo9seW8G4fy61B9X4RcK c3bdXUf6AteI8iU+VtGl5nCPi15PY/e+rqFqg8CzFB0xA4LEsbKKIdgqXeMYsFqjQXfkPJ8VbZIZu iYGylGIbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFZ9U-0007g4-LT; Tue, 08 Sep 2020 08:38:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFZ9R-0007f1-Pp for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 08:38:54 +0000 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A582215A4; Tue, 8 Sep 2020 08:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599554331; bh=9MbsarOq+P/4I79z3A+fJ+J72iGu7faVW8HMRIAC4yg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ABlmjheudFWqMnnqN7fkj7Y8fpGWpqp+Q+5bztrxFGYwdt/wYgY/MV7PHBbVNqkon YKpo8TUVTX6CKqR+9LMrE0vMFmrIIsUlMMIhexMaoFG+3MN9Tu7yuOd+G3uin4Mt/h ku2dg3SQDqNkWUHQcVwN7jdxOTn9U8cssWk6hieU= Subject: Re: [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells To: Krzysztof Kozlowski , Jonathan Bakker References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-10-krzk@kernel.org> <20200908065321.GB24227@pi3> From: Sylwester Nawrocki Message-ID: <48aa966f-d3b8-7e4a-36aa-aed4630d331a@kernel.org> Date: Tue, 8 Sep 2020 10:38:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200908065321.GB24227@pi3> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_043853_904146_B8E6EF08 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-samsung-soc@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Jonathan Cameron , =?UTF-8?Q?Pawe=c5=82_Chmiel?= Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/8/20 08:53, Krzysztof Kozlowski wrote: > On Mon, Sep 07, 2020 at 04:55:26PM -0700, Jonathan Bakker wrote: >> Sadly, this is causing issues for me. The machine driver is no longer probing correctly >> on the Galaxy S. >> >> The failing call in sound/soc/samsung/aries_wm8994.c is >> >> /* Set CPU of_node for BT DAI */ >> aries_dai[2].cpus->of_node = of_parse_phandle(cpu, >> "sound-dai", 1); >> >> where cpus->of_node is not set properly. Which is definitely weird because it doesn't >> look like this should affect that. >> >> Let me know if there's any specific test that you want me to do. > Thanks for the tests. I wonder now if this was working before because > really my change should not break it... I'll think more about it. I think of_parse_phandle_with_args() needs to be used instead of just of_parse_phandle() for that to work, as AFAICS the latter assumes the cells count == 0. We would need first to update the driver and then dts. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel