From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD85C433E0 for ; Thu, 28 May 2020 13:32:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1042A20721 for ; Thu, 28 May 2020 13:32:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oFGC8IvA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1042A20721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EMNCrLE8hVHubg88NpArr6Z8tPQvNbxqxhb5BRz4IR0=; b=oFGC8IvADiZups QX/IKYWospvrz+FcqNM3UM9H6R8idjlNay4OkPcCYYlaPFENA2o4F1DkqIvtQ5e3Q3hay+zmwDg7K yVs0d+HP+xMHPBEFzYTFYkrd7XijABGcgb9SYu3ylSA8cGqbRT9s9st8tyAr3a9e4kXn2yGxleyEh pCxG6rO+B2BmFpQm04m40f0fvCR3HA9jFiPUUJmNntQcmNysmN6eNoYSM8jHiM7vGalPD2l4MlWL7 ETiv85IY9n9V1c7Ek2g2Vkk1Tp5GxXOH/0tckti6chLjVzVOdtOXjhu39B6fQyFKuxIbw69vmJcF2 RYboby04K1jHmXsPPfdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeIdW-0004BQ-Gc; Thu, 28 May 2020 13:31:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeIdT-0004AW-Ij for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 13:31:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5687DD6E; Thu, 28 May 2020 06:31:49 -0700 (PDT) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34C4B3F52E; Thu, 28 May 2020 06:31:48 -0700 (PDT) Subject: Re: [PATCH v3 04/20] arm64: dts: arm: vexpress: Move fixed devices out of bus node To: Guenter Roeck References: <20200513103016.130417-1-andre.przywara@arm.com> <20200513103016.130417-5-andre.przywara@arm.com> <20200528024810.GA232303@roeck-us.net> From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Organization: ARM Ltd. Message-ID: <48afb8bb-a22a-54df-7751-55b7b84c3c88@arm.com> Date: Thu, 28 May 2020 14:30:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200528024810.GA232303@roeck-us.net> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_063151_713665_A252647A X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Lorenzo Pieralisi , devicetree@vger.kernel.org, Liviu Dudau , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/05/2020 03:48, Guenter Roeck wrote: Hi Guenter, > On Wed, May 13, 2020 at 11:30:00AM +0100, Andre Przywara wrote: >> The devicetree compiler complains when DT nodes without a reg property >> live inside a (simple) bus node: >> Warning (simple_bus_reg): Node /bus@8000000/motherboard-bus/refclk32khz >> missing or empty reg/ranges property >> >> Move the fixed clocks, the fixed regulator, the leds and the config bus >> subtree to the root node, since they do not depend on any busses. >> >> Signed-off-by: Andre Przywara > > This patch results in tracebacks when booting the vexpress-a15 machine > with vexpress-v2p-ca15-tc1 devicetree file in qemu. Reverting it as well > as the subsequent patches affecting the same file (to avoid revert > conflicts) fixes the problem. Many thanks for the heads up! I was able to reproduce it here. On the first glance it looks like the UART is probed before the clocks now, because the traversal of the changed DT leads to a different probe order. I will look into how to fix this. Cheers, Andre > > Guenter > > --- > [ 12.744248] ------------[ cut here ]------------ > [ 12.744562] WARNING: CPU: 0 PID: 20 at drivers/tty/serial/serial_core.c:471 uart_get_baud_rate+0x100/0x154 > [ 12.744607] Modules linked in: > [ 12.744785] CPU: 0 PID: 20 Comm: kworker/0:1 Not tainted 5.7.0-rc7-next-20200526 #1 > [ 12.744818] Hardware name: ARM-Versatile Express > [ 12.745021] Workqueue: events amba_deferred_retry_func > [ 12.745155] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 12.745206] [] (show_stack) from [] (dump_stack+0xc8/0xdc) > [ 12.745239] [] (dump_stack) from [] (__warn+0xdc/0xf4) > [ 12.745270] [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) > [ 12.745302] [] (warn_slowpath_fmt) from [] (uart_get_baud_rate+0x100/0x154) > [ 12.745336] [] (uart_get_baud_rate) from [] (pl011_set_termios+0x48/0x32c) > [ 12.745367] [] (pl011_set_termios) from [] (uart_set_options+0x124/0x164) > [ 12.745404] [] (uart_set_options) from [] (pl011_console_setup+0x214/0x230) > [ 12.745438] [] (pl011_console_setup) from [] (try_enable_new_console+0x98/0x138) > [ 12.745469] [] (try_enable_new_console) from [] (register_console+0xe8/0x304) > [ 12.745499] [] (register_console) from [] (uart_add_one_port+0x4c0/0x504) > [ 12.745529] [] (uart_add_one_port) from [] (pl011_register_port+0x5c/0xac) > [ 12.745568] [] (pl011_register_port) from [] (amba_probe+0x9c/0x110) > [ 12.745602] [] (amba_probe) from [] (really_probe+0x218/0x348) > [ 12.745632] [] (really_probe) from [] (driver_probe_device+0x5c/0xb4) > [ 12.745662] [] (driver_probe_device) from [] (bus_for_each_drv+0x58/0xb8) > [ 12.745692] [] (bus_for_each_drv) from [] (__device_attach+0xd4/0x140) > [ 12.745721] [] (__device_attach) from [] (bus_probe_device+0x88/0x90) > [ 12.745751] [] (bus_probe_device) from [] (device_add+0x3d4/0x6e8) > [ 12.745782] [] (device_add) from [] (amba_device_try_add+0x50/0x2d4) > [ 12.745812] [] (amba_device_try_add) from [] (amba_deferred_retry+0x3c/0x98) > [ 12.745847] [] (amba_deferred_retry) from [] (amba_deferred_retry_func+0x8/0x40) > [ 12.745881] [] (amba_deferred_retry_func) from [] (process_one_work+0x2b8/0x6e8) > [ 12.745912] [] (process_one_work) from [] (worker_thread+0x44/0x540) > [ 12.745942] [] (worker_thread) from [] (kthread+0x16c/0x178) > [ 12.745973] [] (kthread) from [] (ret_from_fork+0x14/0x2c) > [ 12.746041] Exception stack(0xc73abfb0 to 0xc73abff8) > [ 12.746181] bfa0: 00000000 00000000 00000000 00000000 > [ 12.746302] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 12.746397] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 12.746651] ---[ end trace 2a3f61da56bd8a49 ]--- > > --- > # bad: [b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8] Add linux-next specific files for 20200526 > # good: [9cb1fd0efd195590b828b9b865421ad345a4a145] Linux 5.7-rc7 > git bisect start 'next-20200526' 'v5.7-rc7' > # bad: [0c7351ad83670964e48cb9a098ad732c1ecbf804] Merge remote-tracking branch 'crypto/master' > git bisect bad 0c7351ad83670964e48cb9a098ad732c1ecbf804 > # bad: [42e11d9b4682229fa7187d129758b8c382f8cd5d] Merge remote-tracking branch 'jc_docs/docs-next' > git bisect bad 42e11d9b4682229fa7187d129758b8c382f8cd5d > # bad: [ab6f501559e9efa687c711a781243cf6651a82d3] Merge remote-tracking branch 'm68k/for-next' > git bisect bad ab6f501559e9efa687c711a781243cf6651a82d3 > # bad: [44aaa516ca63b3ab2da8ae81e9c6a58656e6acb5] Merge branch 'arm/drivers' into for-next > git bisect bad 44aaa516ca63b3ab2da8ae81e9c6a58656e6acb5 > # good: [1cb00f8c3b36e6ae026fb58d1cd2ccd78b81aa9f] Merge tag 'qcom-arm64-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux into arm/dt > git bisect good 1cb00f8c3b36e6ae026fb58d1cd2ccd78b81aa9f > # bad: [ed0c25932fbfafdfe37e9633dee21770d3c5a306] Merge branch 'arm/defconfig' into for-next > git bisect bad ed0c25932fbfafdfe37e9633dee21770d3c5a306 > # bad: [9eddc06a3bc79402f50176703237ed045ae77b16] Merge branch 'mmp/fixes' into arm/dt > git bisect bad 9eddc06a3bc79402f50176703237ed045ae77b16 > # bad: [87b990ab62722a8a3cb0691107971ab1bd7bddb5] Merge tag 'mvebu-dt64-5.8-1' of git://git.infradead.org/linux-mvebu into arm/dt > git bisect bad 87b990ab62722a8a3cb0691107971ab1bd7bddb5 > # bad: [94cc3f1baabac5e5c4dcc6c2f070353f8315d0ee] arm64: dts: juno: Fix SCPI shared mem node name > git bisect bad 94cc3f1baabac5e5c4dcc6c2f070353f8315d0ee > # bad: [a78aee9e434932a500db36cc6d88daeff3745e9f] arm64: dts: juno: Fix GIC child nodes > git bisect bad a78aee9e434932a500db36cc6d88daeff3745e9f > # bad: [feebdc3f7950d7e44e914e821f6c04e58e292c74] arm64: dts: fvp: Move fixed clocks out of bus node > git bisect bad feebdc3f7950d7e44e914e821f6c04e58e292c74 > # good: [849bfc3dfc13cde6ec04fbcf32af553ded9f7ec3] arm64: dts: fvp: Move fixed devices out of bus node > git bisect good 849bfc3dfc13cde6ec04fbcf32af553ded9f7ec3 > # bad: [d9258898ad49cbb46caffe23af0d4f0b766e67a2] arm64: dts: vexpress: Move fixed devices out of bus node > git bisect bad d9258898ad49cbb46caffe23af0d4f0b766e67a2 > # first bad commit: [d9258898ad49cbb46caffe23af0d4f0b766e67a2] arm64: dts: vexpress: Move fixed devices out of bus node > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel