From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7408DC433EF for ; Thu, 3 Feb 2022 00:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JX97JP2yEkxCdcoO/cMV5J/ZYflwIMDyN81R36gv8yo=; b=ZiE6EbSkK3t9XA hZw3kjV3dH9EI0Y1u/qrAcSRwfBfqg4ioII+n1cQPVg6uMKERZUS6Z43oLWUmp28eziNG9Ib2tu24 2/wDZim3epabHuu3KC2GJpI/wfb2ai3rsgPqV3lgqOgH+ebp6Ut0tzxrQe+jrOR8f0ciScWSiGbG0 KAkZ9zd7A66Qfb9a2ao+Pb+ZcwaBJhf/razcEADdQE2zD38kaeOq1zpk6s7U16XVhDsbpd8ZtR/Lb WCGlFe6TQqkMu+Bdsx1Fxu/YkFQwHXRT6PS4y/ONu4G9PFz+SFWYxNlG0sLJrVV3Wnaaw5tOoXidg AHs4+P98dM1SF2O+dNpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFQ5P-00HD7C-B7; Thu, 03 Feb 2022 00:34:55 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFQ5F-00HD4a-Rx for linux-arm-kernel@lists.infradead.org; Thu, 03 Feb 2022 00:34:52 +0000 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id 4FACC20B6C61; Wed, 2 Feb 2022 16:34:44 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4FACC20B6C61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1643848485; bh=TjbaCOX1e+7kp6KBiMIW8p0ZetHxMvPlcN36NQSGfd8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OG2cZ3FvG/7uQ//KPclVZf3jhyGwkIT5ljzlF1WNcH6aZbAg3BwMcPW2ABT0w+LSY FttKV2YwhAqg/erVC/bVzcWNjEN4xop5Pz5rZFgUjBNOUsM5erWh3K9Ya8/4IFn/90 cxZIjo+GEM0Cc0wWvwTjs5lTeTdwdlIW8v1xf1vM= Message-ID: <48b17c52-58d6-0df5-a50b-35a8ea408998@linux.microsoft.com> Date: Wed, 2 Feb 2022 18:34:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() Content-Language: en-US To: Mark Brown Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <95691cae4f4504f33d0fc9075541b1e7deefe96f> <20220117145608.6781-1-madvenka@linux.microsoft.com> <20220117145608.6781-7-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220202_163446_012669_DEEFE0B8 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/2/22 12:46, Mark Brown wrote: > On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Rename the arguments to unwind() for better consistency. Also, use the >> typedef stack_trace_consume_fn for the consume_entry function as it is >> already defined in linux/stacktrace.h. > > Consistency with...? But otherwise: Naming consistency. E.g., the name consume_entry is used in a lot of places. This code used to use fn() instead of consume_entry(). arch_stack_walk() names the argument to consume_entry as cookie. This code calls it data instead of cookie. That is all. It is minor in nature. But I thought I might as well make it conform while I am at it. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel