From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 597AEC74A5B for ; Wed, 29 Mar 2023 20:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HtNtg1SQ9Fj/dmRkW4tkR9DO1767CF5VacEoQZL5W6w=; b=jkBLA9y+KTxLvK VT3rE16OAkRoEutXoPGh/MYO94tSghHLOwyfVh9l81HKtMk2FIctPH55W88ObLbL/2zjlrVUSU3LQ rIgW8gL8RY9F8JtMjeVZdd8epQ5wFVttnsEvujsX8kFblT7nyZYpD4a4wFrpTdna1eswYTPRU/UDr 0R8KKES4KKG7Br52x+rGaeA32fK7INg77OeMbjQq10rbl+fOLaW/jB5+L7MQ+/gF9zI+eHI7ta6Iu a3EnhCxCnENwE1KI/rrSK7amdgph/qpmnbhDyJVhdVk8QhcMewNXrrphvtQlbKd5TfSymrNiq05fX TyrUZkTLzUjWLaeEPOaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phcGo-001kif-1s; Wed, 29 Mar 2023 20:19:46 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phcGl-001kgA-2X for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 20:19:45 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32TKJYro047752; Wed, 29 Mar 2023 15:19:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680121174; bh=T+Eko+LLwZmsGd120Z+3Lj9F1hIzzlrX0hwtefoHhpw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=AkSpg4dwQ0o+NnHt6qWUFm7i/Oh/O0SCDZDY1zxM9usBpUECpx21wdCoIHkuFTD9P wbLSWN/rLzeMmp003zvxBImG7hyX5sChYqjaXHodp0Xt4nClhtW4ER3s04U14sPD3S qA6MV02JIBsQ7yz43A5YVFgsfyGruOv9kU6UFNlw= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32TKJYOw010119 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Mar 2023 15:19:34 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 29 Mar 2023 15:19:34 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 29 Mar 2023 15:19:34 -0500 Received: from [10.249.48.175] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32TKJYRY021351; Wed, 29 Mar 2023 15:19:34 -0500 Message-ID: <48c03b5a-6557-9eee-8b85-24d72cfbfcd1@ti.com> Date: Wed, 29 Mar 2023 15:19:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add MAIN domain R5F cluster nodes To: Nishanth Menon CC: , , , , , , References: <20230329093627.30719-1-hnagalla@ti.com> <20230329093627.30719-2-hnagalla@ti.com> <20230329125247.w45k5fjzmcgjdyso@delicate> Content-Language: en-US From: Hari Nagalla In-Reply-To: <20230329125247.w45k5fjzmcgjdyso@delicate> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230329_131943_971323_D28936AE X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/29/23 07:52, Nishanth Menon wrote: >> MAIN R5FSS0 Core0: j784s4-main-r5f0_0-fw (both in LockStep and Split modes) >> MAIN R5FSS0 Core1: j784s4-main-r5f0_1-fw (needed only in Split mode) >> MAIN R5FSS1 Core0: j784s4-main-r5f1_0-fw (both in LockStep and Split modes) >> MAIN R5FSS1 Core1: j784s4-main-r5f1_1-fw (needed only in Split mode) >> MAIN R5FSS2 Core0: j784s4-main-r5f2_0-fw (both in LockStep and Split modes) >> MAIN R5FSS2 Core1: j784s4-main-r5f2_1-fw (needed only in Split mode) > Why are the patches split up into main and mcu - if you are adding r5f > cores, do them as a single patch. > Thought would be cleaner with separated patches for resolving potential merge conflicts. But, can combine into one for v2. >> + >> + main_r5fss0: r5fss@5c00000 { >> + compatible = "ti,j721s2-r5fss"; >> + ti,cluster-mode = <1>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x5c00000 0x00 0x5c00000 0x20000>, >> + <0x5d00000 0x00 0x5d00000 0x20000>; >> + power-domains = <&k3_pds 336 TI_SCI_PD_EXCLUSIVE>; >> + >> + main_r5fss0_core0: r5f@5c00000 { >> + compatible = "ti,j721s2-r5f"; >> + reg = <0x5c00000 0x00010000>, >> + <0x5c10000 0x00010000>; >> + reg-names = "atcm", "btcm"; >> + ti,sci = <&sms>; >> + ti,sci-dev-id = <339>; >> + ti,sci-proc-ids = <0x06 0xff>; >> + resets = <&k3_reset 339 1>; >> + firmware-name = "j784s4-main-r5f0_0-fw"; >> + ti,atcm-enable = <1>; >> + ti,btcm-enable = <1>; >> + ti,loczrama = <1>; >> + status = "disabled"; > Why are these disabled by default? Well, the idea is to let the board specific device tree enable needed remote core nodes in *-evm/sk.dts and disable by default in SoC device tree files by default. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel