From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74AADC43334 for ; Mon, 6 Jun 2022 09:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IHMd/+FXe9vLvMlA+nPmMh9ej7wYXdoU1vFeAgOAA1A=; b=MmOM3FzSXo7+F7 znz2OQvVDwQh8dFlujRkYSgFgM5Ae5wHm66BrhXXdhzkx9GIkeCeqhgM/jaDx5ihaEnf5wNZXNgTa dL3FK+185F/74qPLxvrtS0WV4LY0h/lidhPu0tN3tmPf2OwsooKtwJ8fO8fSse29Qwo7mH3BUR+lK X1uLkL2gKFwluoZT/EUlXfPJDtza89ZhjxMitDNHYbeftZL4Of6ZYbWapWVH6/F/xVU3te+dw20Ij DKfjleg1F9XA3vxvTXxoRuuwC9pU3LwYD7oKswKsS20eZxU7P0MC3JdN04X0C9rrySCD92mqHa4It Cmvb36mzbFGt/08s/EIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8bp-000Iej-2d; Mon, 06 Jun 2022 09:01:13 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8bl-000IdO-9m for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 09:01:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1654506069; x=1686042069; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=YIpkd5IIKg1ixiCTgqY6C0MBrqnJfOwDDlB7m1AdhWk=; b=vlPeLZOsrCS2d6EwcmUM88ic2UlBkuEMV1pmlqkB8+pHFxhMryGUUmxh AM+D1D7gFQqdaLNocVCY2Wy2qQCtMt54lCQ5EGEOjlEv1txSFcGf/h1ri 3UcfvbhnhaUI4vGFmVtohZc6+XO2ML4ppYgb9yy6XhvNjND0wcZbIAc86 cJPqNWxnVxwzkzC/A6KTt+GjwSIoPSo14O5duifIv3HeAregw2evqPFKG gIW79D8sPnZ2L7DKhp9N98Jo4EQgJZr5A7naG1lmi/ryB/kPqfYzWw3Kj N3HjNWgXQR4BTxKYNue9M7ltZiOuMBrY+7GujeMrRZJjXSHdVDZk+WYHn A==; X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="98706450" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 06 Jun 2022 02:00:58 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 6 Jun 2022 02:00:58 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Mon, 6 Jun 2022 02:00:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZ9Ou+52XRqHuOwONv35r3bmart+NaP9y07mAx4uEXA/tSZQzyF5+qWnrHuw9bkbhrytOPXgXFX/MBMK22F7zyovoBa7LeSJLwURUJmsLFFBlRumnEV+5PwLRwWWtAlBM7X7xKuf3tBdpEGvdMlcc6gA8+lrL5PJUr93jiS4HbNCxU9z0QQ/kqlxTRJWBItBh/ddzr0GSf8nljQhCIMpNvJ1taIDBYcG10fwXP/OiDkPxiu7UkZomM4Omwt/Zp4Bf5Ifs1KMAGevKgOHYUhjR/ETEl6vLreOQHSraQC0L2duAqCwCLLGhUYEaIRg9IzYj2NSULyOwa5svDzJUFLtEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YIpkd5IIKg1ixiCTgqY6C0MBrqnJfOwDDlB7m1AdhWk=; b=FjlqLeVLORqWtEWte9nFtjNuil2nmFhxngAimp2m6v0Adenp4cF+4eB4WCCqtfeRepNoxLgoHl4X0aInXE3IYJJdkG8iQI5uUVwozNmR3umgZ03vKUv9qdZ5UlQA7YJPeNfFmI5pVpsy2few8YRpKmlhk1L14n3iHYAD/wuygTh0WhiqmmTNjsSY2ZNHkD687CdrpFhaKwmAfTCIeGXW5ledX9o9UB+MTMLLz1HEfXKDTRSrCtzw6YBEhfQaDNEMiEgMI4bFnWaWYOQCHl+s2/WELM/nPmlwD88/QLOuTbgEVaa8EWKH3dxe2+xB+okhMgHsvRrHZXjK/VtUYoa7Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YIpkd5IIKg1ixiCTgqY6C0MBrqnJfOwDDlB7m1AdhWk=; b=hDOH35VITYiqx5b2aGWuHA5z/H0ltDf85cHML3WYtaLHwtFR9mkIJg27yAmmEn6UWE4BQeXxvUChy3r2hUeUXUQe42k+gIEmqUuCe0w3drtbDYjGyUVviOprubLnK8I37wSp3MvJN+NB2JF1OPfUN3lesbntavk0+zL3140YO/8= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by MN2PR11MB4287.namprd11.prod.outlook.com (2603:10b6:208:189::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Mon, 6 Jun 2022 09:00:52 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::8dbc:9dd0:ba2:e99]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::8dbc:9dd0:ba2:e99%10]) with mapi id 15.20.5314.019; Mon, 6 Jun 2022 09:00:52 +0000 From: To: , , , , , , Subject: Re: [PATCH] drivers: soc: atmel: Fix refcount leak in atmel_soc_device_init Thread-Topic: [PATCH] drivers: soc: atmel: Fix refcount leak in atmel_soc_device_init Thread-Index: AQHYeYPrugHoQ5HOEU+fRh0sGrrd8g== Date: Mon, 6 Jun 2022 09:00:52 +0000 Message-ID: <48c19453-984b-c3ae-b62b-2f0455330084@microchip.com> References: <20220605084035.27127-1-linmq006@gmail.com> In-Reply-To: <20220605084035.27127-1-linmq006@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d6057ba-9d8c-4180-7e09-08da479b0ef9 x-ms-traffictypediagnostic: MN2PR11MB4287:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WOyE2nMDg7hpxOliOAwa1L7iqdCu65mjB81mYxwVxLFd8yCu6CZ5bbNPC+HR1Jheq/oRxyuCmA55D8OoEETdgC9XicojLbM5utFL/wio5xIi/prMcF7cWzBMEEQJ/BLIAIs5np9waY0lH1I5rJF2ENbRsimE4z2G/3K2R8Ahllgfs/Im0sSNZ5ofzc+gM4Y+l5PhfF5RSMi9yU7/YPzL1SNEIkABosPyYmwXXrGqYtW1DqC8eHlepGa4JgbN0OACazM1pYuzZteBOZXpL0i26ktGe75dSQG1NYsLuhvpDe3pU1NsVrxXUiLbM8OSBoHnYUrp4YpSMzGplDZld1Xow6uI/rve9tkwF+gnoBNHqacudM10TgV8QSUlpu57XSR0xH9pqS8lnqG7wyJORF2Fav9g/9AsFCGh98v/XY0PKgtKcAGkUJCYY2LYv4LWrdN77QTrUnDuWKVBMT9SRwgEnGKGwumrv4efEBEi0scgUkNcPiTenF/bF1/HFi7o//Vz7+0pnG04Na/JBQG5lGH+a8e9lbY9Wl9yIIPWGoVQU0m++Ea/SQP0xOzoWcFQ9daIDUV1MmJXB1bPiAEQCNnTdxCnj/k16hyjFNkHSTv5GyipjYDhqy4yTjwNnBzEA4c8KL9uUoIDEBBF9n92cXU2LXQGPJROP/DfKiKsjdQgLUZfYYxG0/5wwlXbGVoqBpQL5dwamlFyBGW4dxkdtccmbCendxQLKkPg53dAgyFqph6yjYPj0d3NnWlde4aWk6/GiIxm5RIrdD7lfhdKSnGudA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(83380400001)(186003)(2616005)(6486002)(66946007)(6512007)(26005)(53546011)(6506007)(38070700005)(66556008)(66476007)(110136005)(8936002)(122000001)(38100700002)(86362001)(31696002)(316002)(71200400001)(508600001)(8676002)(91956017)(66446008)(64756008)(5660300002)(76116006)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VDRmL2RMY0RsNVFFWEZSN0xwZkN3M2JMZHB3ZXVVTXhFaG1WU1pYZm1kRHNa?= =?utf-8?B?bDBuN056TUlkVHo4ai9DRGRkcXJ2b1I5SmZ6T01ZWnB0ZDEwQzFZNnMrTWlG?= =?utf-8?B?ekNOUnVyczRHdVVHVlNzUnBmV1ZQVHA2aFl4ZDFxWnpuZnU5cXVvanI5ZE9F?= =?utf-8?B?Sm94RGdoM1VlVkExQlNaSFJ4N1hRSUFxUThYZ2huc3o0SkJKQk9hd0RqbjJZ?= =?utf-8?B?aGQ1bFdXSEFKWnh5UjVpWUorUktvc1VqazVGc09mREoxMWlRUzVjR1NwbXZY?= =?utf-8?B?bHdJbGxzNVd5bUhnaGtWcFJuTll2K2o1TjNpVnF4RUt2YWEyM3VOajdwcnJ5?= =?utf-8?B?VFZSNWdFZ2lzSjdMRkVNei9NdGkxalNhTGo4T09yRkQzdzJiTW5hQVBock1W?= =?utf-8?B?WDhUa3U0OEFia3Y4TE8zbHBaSitLT0NkYjcrQ3ZiMzNMUldkVHNGbGN4NXZX?= =?utf-8?B?STJtZE9rZHU0cHlYczA3VjdpY25MTWF0RVNlaTQ4VXJ1UXRoZWJGZVV1dHpD?= =?utf-8?B?bjU4a2RYeUNhZW1YWDR5TGNkZnRCRXQzbGo5NnJNazZpbUhsa1NURC9BbjZV?= =?utf-8?B?V0hLZzdHcnYwUUZvZmxtTkhMa2JENE0rQ0tIWTAvcmZwc2lSenJwMzJQbWZO?= =?utf-8?B?cnJrcElvT0ZYZU9VVVgwYW1TUEl4T2J4cGFOb2pKbVFpelpRdDlpQUtUOEhR?= =?utf-8?B?WW14ZGlhYkNua1g0SWREZDlUS05jV2VCV25NQzJwZmVSWWpUTkRjK3REYjhB?= =?utf-8?B?NHVaL1ZqUG4yVTVWZDAzVCt6ekVxcGxIbm9IOXpUeHhPTmhvbzJvZFJvTDYv?= =?utf-8?B?dVA2d0RvbmpIL3pVejh1Z092SWMzbzJVN2pwWUNIcFFPM0Y2a2N4cTZTbit4?= =?utf-8?B?MGNKMEVPV1ExRmI4c3dOSy9aSjJMWUIyQ1d5UjJha0hscER5YW1ZOWJEbjNu?= =?utf-8?B?K3hpS2tCUkxZSnZ4VHBNTVBLU3VjUWN3YTA2cHNxc3NUUENUcC9XempXekE1?= =?utf-8?B?MmlJalBkTm16YlBxUVFmWWdpVVN3UEJ1YlgrdldjNU1sR0dXVFRwTnlwY2pB?= =?utf-8?B?Unlta0pPQUt6NDVuWmRvYk1WVFRSdlNnQVVRc0F6RzlwdDFmTERhNXhmdDJU?= =?utf-8?B?eU1TVVo3RjVwSjlsaHhMdHlwN0hKSWU1ZW5nTy84cWZzbjNqZnlVRTd6WDRj?= =?utf-8?B?aFJqNXpybjhEck9IUFRiYXUrMDNSamhQekJrRXV0czNKWjY2V2VFT0h5d1ZH?= =?utf-8?B?VG9nLzZSalJRWTFpKzg2M0xhSmVCSUNsS0RFUkl2S2N1NHZUY0hwakhOYXlt?= =?utf-8?B?OWNFOWhTalU3clNXTlFJN050TDMwQ1pYREIzbThVRU9KdER2OVhuanB5a3Y0?= =?utf-8?B?QU14RHdLUnlYZnc4Y3pFbnYzY1Nnc3BlSU5FRTBET1IzN1dKQWljeC9DQWxx?= =?utf-8?B?WXd0SU5sbG5Cc3FMdStEN0VXU3phOEpoZVkwSTQwK0oyd0NralJNQklmN0xS?= =?utf-8?B?dXdSRy9oakpPcUlYZE13T0hFdnU2UTZQTVc0WWNuSHFsTGtmT3NjM3ZiQnl2?= =?utf-8?B?QzlSekljbFM0RERsM3pLSFYvMVg3dFQ4M0RsV0tzRU5rMVZPdWFDdi81akI2?= =?utf-8?B?RVk4ZUhNM1ErakYybXZDbCtqNm9iczNjLy9rUmJJTVdnaEJhc0kveGZkV24x?= =?utf-8?B?LzlCMytTT2dlQ1hOZnRmdk1xOWlMOGRZL3pOOTR5Yko5WkFkN0xmZHVrYzY1?= =?utf-8?B?V2h2a29yMktOL3crL3ZVczI4Q2p0ZFhCdVN3UmtvYjJXOVBPUE9PNjlNb2hn?= =?utf-8?B?WkRJZzRhWVpVQ0VwNGdCUXkydUJIeHhnaFRERjFWOFdEQTdWQ0NORll1NXYw?= =?utf-8?B?blc4Z0Q1YnNjbEFRTi95a0ZHT2x1bHJpK29BaVVtbHJxZW9qck5jc0h0T0pN?= =?utf-8?B?SEp5VVJqOFhjMFMrUHFpMDZaR1dLZWhsUjd1UUtjS3hKbGpRQ296TkwxY0Nz?= =?utf-8?B?cS82S0x1ZG9Ic2JBMEFhMHNmSURUSWNCc3YrUndMWTgyMVNmbVpmTm1jQU9U?= =?utf-8?B?VTJXbklCdkJCVGhMOU5EMjdLeEFkb3ZBUHVvcUowckFRUG90R2RXR2hVaW1X?= =?utf-8?B?R2pkYURpalkzbGI1ZzFpRS9QbUppVmtaS2dwb1lnL1czcFRBSG03N3BJcGlz?= =?utf-8?B?TWs5bGdoeTdRMk5NTU9pQmhPc2xXcnNSWkVOZHk0SVpJZW0zSWc2SjgvOXlt?= =?utf-8?B?OVcyN3NnOC9sN1k5c0t5UUVma3R1bkM0NitCRXhBbWkrazNCcER4blNWbmNJ?= =?utf-8?B?emJNbi9sZXFJYW1aaHpWb2dnQ2JUbTdBeklJblFiT3pwZ21SMEpGditxK1Ju?= =?utf-8?Q?2FapY0lqr7JIiBck=3D?= Content-ID: <532EB6CE8F719F4D9EC136FF2A13EFA2@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6057ba-9d8c-4180-7e09-08da479b0ef9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2022 09:00:52.2456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y8KCPtC+vzvMrBCJXK6302lDDddZ9+xS7ktwiLLr1YZ074HUPDd9B7xi6ic/dE2hodLNdXAGAgmTEyXNpuO/ZDpUgMCV8nrSc/2wAEhwSDo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4287 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_020109_477898_327C5D52 X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05.06.2022 11:40, Miaoqian Lin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > of_find_node_by_path() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 960ddf70cc11 ("drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs") > Signed-off-by: Miaoqian Lin > --- > drivers/soc/atmel/soc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c > index b2d365ae0282..46dfa24c52fb 100644 > --- a/drivers/soc/atmel/soc.c > +++ b/drivers/soc/atmel/soc.c > @@ -369,10 +369,13 @@ static int __init atmel_soc_device_init(void) > { > struct device_node *np = of_find_node_by_path("/"); > What about having it like this: const struct of_device_id *of_id; of_id = of_match_node(at91_soc_allowed_list, np); of_node_put(np); if (!of_id) return 0; And everything else the same? > - if (!of_match_node(at91_soc_allowed_list, np)) > + if (!of_match_node(at91_soc_allowed_list, np)) { > + of_node_put(np); > return 0; > + } > > at91_soc_init(socs); > + of_node_put(np); > > return 0; > } > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel