From: Peng Fan <peng.fan@oss.nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: djakov@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, abelvesa@kernel.org,
abailon@baylibre.com, l.stach@pengutronix.de,
laurent.pinchart@ideasonboard.com, marex@denx.de,
paul.elder@ideasonboard.com, Markus.Niebel@ew.tq-group.com,
aford173@gmail.com, devicetree@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 6/7] arm64: dts: imx8mp: add interconnects for media blk ctrl
Date: Fri, 8 Jul 2022 08:06:54 +0800 [thread overview]
Message-ID: <48cb64bd-fc0c-a385-f1b0-765ca17cfbbb@oss.nxp.com> (raw)
In-Reply-To: <20220707113851.khi42m7pgx23d26u@pengutronix.de>
On 7/7/2022 7:38 PM, Marco Felsch wrote:
> Hi,
>
> thanks for your patch and the work on this.
>
> On 22-07-03, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Add interconnect property for media blk ctrl
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> index 13a2ee77d3c6..08bd57742294 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>
> Can you please add:
>
> #include <dt-bindings/interconnect/fsl,imx8mp.h>
>
> else this won't compile.
oh, ICC maintainer asked me to drop this header when adding
NoC node, and I need to add this header when there
is user. Here it is, I will add it and post a V4.
Thanks,
Peng.
>
> Regards,
> Marco
>
>> @@ -1066,6 +1066,18 @@ media_blk_ctrl: blk-ctrl@32ec0000 {
>> "lcdif1", "isi", "mipi-csi2",
>> "lcdif2", "isp", "dwe",
>> "mipi-dsi2";
>> + interconnects =
>> + <&noc IMX8MP_ICM_LCDIF_RD &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_LCDIF_WR &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_ISI0 &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_ISI1 &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_ISI2 &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_ISP0 &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_ISP1 &noc IMX8MP_ICN_MEDIA>,
>> + <&noc IMX8MP_ICM_DWE &noc IMX8MP_ICN_MEDIA>;
>> + interconnect-names = "lcdif-rd", "lcdif-wr", "isi0",
>> + "isi1", "isi2", "isp0", "isp1",
>> + "dwe";
>> clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>,
>> <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
>> <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
>> --
>> 2.25.1
>>
>>
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-08 0:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 9:14 [PATCH V3 0/7] imx: blk-ctrl: Add interconnect for i.MX8MP Peng Fan (OSS)
2022-07-03 9:14 ` [PATCH V3 1/7] dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk ctrl Peng Fan (OSS)
2022-07-03 9:14 ` [PATCH V3 2/7] dt-bindings: soc: imx: add interconnect property for i.MX8MP hdmi " Peng Fan (OSS)
2022-07-03 9:14 ` [PATCH V3 3/7] dt-bindings: soc: imx: add interconnect property for i.MX8MP hsio " Peng Fan (OSS)
2022-07-03 9:14 ` [PATCH V3 4/7] soc: imx: add icc paths for i.MX8MP media " Peng Fan (OSS)
2022-07-03 9:14 ` [PATCH V3 5/7] soc: imx: add icc paths for i.MX8MP hsio/hdmi " Peng Fan (OSS)
2022-07-03 9:14 ` [PATCH V3 6/7] arm64: dts: imx8mp: add interconnects for media " Peng Fan (OSS)
2022-07-07 11:38 ` Marco Felsch
2022-07-08 0:06 ` Peng Fan [this message]
2022-07-03 9:14 ` [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio " Peng Fan (OSS)
2023-03-27 4:50 ` Greg Ungerer
2023-03-27 6:27 ` Alexander Stein
2023-03-27 7:16 ` Ahmad Fatoum
2023-03-27 8:07 ` Greg Ungerer
2023-03-28 7:33 ` Marco Felsch
2023-03-28 12:58 ` Greg Ungerer
2023-03-28 13:42 ` Marco Felsch
2023-03-28 13:51 ` Marco Felsch
2023-03-28 14:34 ` Greg Ungerer
2023-03-28 15:11 ` Marco Felsch
2023-03-31 5:55 ` Greg Ungerer
2023-03-31 7:45 ` Markus Niebel
2023-03-31 8:11 ` Ahmad Fatoum
2023-03-31 15:09 ` Greg Ungerer
2023-03-27 7:51 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48cb64bd-fc0c-a385-f1b0-765ca17cfbbb@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=abailon@baylibre.com \
--cc=abelvesa@kernel.org \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=paul.elder@ideasonboard.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).