From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6933ECDB465 for ; Thu, 19 Oct 2023 08:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UPNcbY3su/tCzlo5lAtGclkywP8mH0nh260FCiA4H5o=; b=bemuynH5Xxr5S4 UcdzCYhOyfjyC5+0X6QJE/D4DsU3r6SSd/BihQ3zAQeBuNqUnl/bdGyNhBywsq0+v9kpv83FYY+zW 7aHX9OP8amn446GC1TQXze4tKPPseM1BjYuqldD9aQ3NdRWAc92TQlUPC9zCXNU1FW9oIhJNsyUUi iUdLLdjAvPo2uVnPf9bTLqahikySHOLt7dWiH4wPnfdZs58YG2LVprPAb1HPvajFTk++UMNsgyw5p q5qbme5BfXtmFXrJN8nseKVaQjG1ZgN5mA5Ri+55Zdr0b+5mmkd355Z37XoCz4K9tK1jij8fssTUJ 4hfgm1bOANCU2yy9QinQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtOdI-00GkhC-0q; Thu, 19 Oct 2023 08:43:56 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtOdE-00GkgW-2Z for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 08:43:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697705031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNhtEDb46cdwd0UeanpUYMMLzJiY9Fo2EaQX8hX2fF8=; b=EBz+ztq/acAMGjXwbGg5G8UJiOaJ00S7ZECtmuS5nNpghllBuKASRMtQiW1zGRvsgaYzKC +9XJJiR3PI+NhVbOhKXZznLZ10iee/pfcX4DDmdVAFD0M4hBZmFbZqpYNCPnE5TpWee0lB ulmQArzE5CtctdjX2VUnCS8VW5GmWdg= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-0Z3lWc9UMNuIhDoYU8G2aA-1; Thu, 19 Oct 2023 04:43:40 -0400 X-MC-Unique: 0Z3lWc9UMNuIhDoYU8G2aA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-66d857105b6so17550646d6.3 for ; Thu, 19 Oct 2023 01:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697705020; x=1698309820; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sNhtEDb46cdwd0UeanpUYMMLzJiY9Fo2EaQX8hX2fF8=; b=af+hdC/gqMfM3bBsCYP/DVx2F4Vs+ik35o9M/5EDNjU8AQrQabpXGDgC96HrzWbom3 u85jwCmlzuro+f0ZeHe7lZj8Rg2WNSQk49vRs+sR8eSSyvFT9zTidi1NcsS4/wQkDNRt wrF5CDJuslz0gqUsRarqENOP7hL82D/kTaUFa2/ubZTbtyTzbZ50Cou3nReTspX1AUEZ mbXXxUeaaD2LkuLWpcTHeAT2FA+gsqnfu6HpgQ35aBmhXEhH2pf4/6MYfOOILQ4XUnDy P7DCLPb1h3+03NumahMYSaP3mXXUws9i53ueMK99w6Gg7hr8m0/Q653yW2qKTWBDgpoY Cjcw== X-Gm-Message-State: AOJu0Ywn8Z+VdokNsvP/FHJgjZzJzmwGttVxLxTDc+YANPVBRFa/K4ht OKuN4X0ATHcJa3F5n5rISDU/lCW92zK2sZKqo7eMEKmOTiElm0HbR6+e1NUiKrMYJKJa7/iiNza Puy2vl4QJLtvGjkijF14kiiqed9EovSM1zzw= X-Received: by 2002:ad4:5fcd:0:b0:66c:ffe1:e244 with SMTP id jq13-20020ad45fcd000000b0066cffe1e244mr2186152qvb.62.1697705020239; Thu, 19 Oct 2023 01:43:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETbfgv/8+88fGni1xgnaMxsBgnNEdj2B+ZY0ZeQEa62JYNYio5HxIOk7eFGTP20cQ6OiiUgQ== X-Received: by 2002:ad4:5fcd:0:b0:66c:ffe1:e244 with SMTP id jq13-20020ad45fcd000000b0066cffe1e244mr2186118qvb.62.1697705019902; Thu, 19 Oct 2023 01:43:39 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id t6-20020a056214118600b0066d11c1f578sm625981qvv.97.2023.10.19.01.43.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 01:43:39 -0700 (PDT) Message-ID: <48d09c9f-78d9-e5eb-d85a-e75a6df81396@redhat.com> Date: Thu, 19 Oct 2023 10:43:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 4/5] tools headers arm64: Update sysreg.h with kernel sources To: Oliver Upton Cc: Mark Brown , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Marc Zyngier , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra References: <20231011195740.3349631-1-oliver.upton@linux.dev> <20231011195740.3349631-5-oliver.upton@linux.dev> <73b94274-4561-1edd-6b1e-8c6245133af2@redhat.com> <3c5332b0-9035-4cb8-96ce-7a9b8d513c3a@sirena.org.uk> <8baca35a-9154-97e6-d682-032fc69d2da6@redhat.com> From: Eric Auger In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_014352_903987_40DE7416 X-CRM114-Status: GOOD ( 25.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Oliver, On 10/19/23 02:06, Oliver Upton wrote: > Hi Eric, > > Thanks for reviewing the series. > > On Wed, Oct 18, 2023 at 03:06:12PM +0200, Eric Auger wrote: >> Hi Mark, Oliver, >> >> On 10/18/23 14:16, Mark Brown wrote: >>> On Wed, Oct 18, 2023 at 01:57:31PM +0200, Eric Auger wrote: >>>> On 10/11/23 21:57, Oliver Upton wrote: >>> >>>>> #define set_pstate_pan(x) asm volatile(SET_PSTATE_PAN(x)) >>>>> #define set_pstate_uao(x) asm volatile(SET_PSTATE_UAO(x)) >>>>> #define set_pstate_ssbs(x) asm volatile(SET_PSTATE_SSBS(x)) >>>>> +#define set_pstate_dit(x) asm volatile(SET_PSTATE_DIT(x)) >>> >>>> could you comment on the *DIT* addictions, what is it for? >>> >>> DIT is data independent timing, this tells the processor to ensure that >>> instructions take a constant time regardless of the data they are >>> handling. >> >>> >>> Note that this file is just a copy of arch/arm64/include/asm/gpr-num.h, >>> the main purpose here is to sync with the original. >> >> Ah thanks. that's helpful for me to understand where this gpr-num.h >> comes from. This could be documented in the commit msg though. >> >> Something like: >> >> adding tools/arch/arm64/include/asm/gpr-num.h matching linux >> arch/arm64/include/asm/gpr-num.h >> >> and syncing tools/arch/arm64/include/asm/sysreg.h with the fellow header >> in the linux tree. > > Yeah, I could've spelled it out a bit more. I already cracked this off > of an even larger patch from before I picked up the series because the > diff was massive. > >> tbh I did not initially understand that all this diffstat was aimed to >> match the linux arch/arm64/include/asm/sysreg.h. Now diffing both I have >> some diffs. Doesn't it need a refresh? > > I'm worried it is a fool's errand at this point to keep the two in sync, > as I'm sure there will be more in -rc1. The tools copy of sysreg.h isn't > a verbatim copy either, there are some deliberate deletions in there as > well. > > I've taken this as is, we can always come back and update the headers > afterwards if we find a need for it OK np. I did not notice you picked the series up and I jumped in too late. Anyway that was worthwhile for my education ;-) Eric > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel