From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A20FC433F5 for ; Tue, 15 Feb 2022 06:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QbJjfw/dr7qy++8RvNBYxqKYirMUvDWAvVd5i9+dI5s=; b=lRbvtUuqnIh/Xo CN3bjBZXA8EPtpnuRcVmBUYLfk4wKwMR0nImYdHsGG66pnuonO47DhBwUjvm5sqn0cDk+uFQ9/HP/ 154MQ+hKXDORbPOJdTXMu0oo8ySQfxOZfj6qgm93IHHIgCNyKAK6RNb9RVPIxdCpwnxSZgLdVyYXB ZDJd71xfWBT50A7L8qSmHcTQtzbj28DCMb5DItHNfysOWY8v6MPcFTqeWHVnqWahHDLi7HMuSzIDK /fVIyPoafiIx8/8rKIKxPW2ozdxB9szs/SqXDIAt8iJAP2zCAIZF6+qLeveHg+G3v7HIJE1QEpowG 1+7/qj2J9FWLq+vM9rjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrN4-000fbE-7o; Tue, 15 Feb 2022 06:31:30 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrMy-000fYK-Ru; Tue, 15 Feb 2022 06:31:26 +0000 X-UUID: 4d987bebf634468898276fecf3c087f6-20220214 X-UUID: 4d987bebf634468898276fecf3c087f6-20220214 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1441791450; Mon, 14 Feb 2022 23:31:21 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Feb 2022 22:31:20 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Feb 2022 14:31:18 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Feb 2022 14:31:18 +0800 Message-ID: <48eabb5f312bf787eb89996eaa6e7c79f89fb037.camel@mediatek.com> Subject: Re: [PATCH v3 11/31] clk: mediatek: mux: Clean up included headers From: Chun-Jie Chen To: Chen-Yu Tsai , Stephen Boyd , Michael Turquette , Matthias Brugger CC: AngeloGioacchino Del Regno , Miles Chen , , , , Date: Tue, 15 Feb 2022 14:31:18 +0800 In-Reply-To: <20220208124034.414635-12-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-12-wenst@chromium.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_223124_963144_E841003F X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > Some included headers aren't actually used anywhere, while other > headers > with the declaration of functions and structures aren't directly > included. > > Get rid of the unused ones, and add the ones that should be included > directly. > > On the header side, replace headers that are included purely for data > structure definitions with forward declarations. This decreases the > amount of preprocessing and compilation effort required for each > inclusion. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen > --- > drivers/clk/mediatek/clk-mux.c | 11 +++++++---- > drivers/clk/mediatek/clk-mux.h | 8 +++++++- > 2 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mux.c > b/drivers/clk/mediatek/clk-mux.c > index 2d4d8dc0120a..01af6a52711a 100644 > --- a/drivers/clk/mediatek/clk-mux.c > +++ b/drivers/clk/mediatek/clk-mux.c > @@ -4,13 +4,16 @@ > * Author: Owen Chen > */ > > -#include > -#include > -#include > +#include > +#include > +#include > +#include > #include > #include > +#include > +#include > +#include > > -#include "clk-mtk.h" > #include "clk-mux.h" > > struct mtk_clk_mux { > diff --git a/drivers/clk/mediatek/clk-mux.h > b/drivers/clk/mediatek/clk-mux.h > index 38a2b6014b08..903a3c937959 100644 > --- a/drivers/clk/mediatek/clk-mux.h > +++ b/drivers/clk/mediatek/clk-mux.h > @@ -7,7 +7,13 @@ > #ifndef __DRV_CLK_MTK_MUX_H > #define __DRV_CLK_MTK_MUX_H > > -#include > +#include > +#include > + > +struct clk; > +struct clk_onecell_data; > +struct clk_ops; > +struct device_node; > > struct mtk_mux { > int id; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel