From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BEA1C432C3 for ; Thu, 14 Nov 2019 13:02:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43E9C20718 for ; Thu, 14 Nov 2019 13:02:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qDRHarcs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43E9C20718 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ny0Q3er1TNl9TxSsfHs0m4mrTlJZFTG/HW6Nx5OTim4=; b=qDRHarcsBCMr0PHcWTemYV8Ve9 EiCGbDJV85CzpkMNoNahyNfypRnc9b5CZYWbpBSn10CnxBk45oxqtjh065thcHWUmjAy9Qn2NTC5J wrVf1izl6nbmdAmBI+L+1ToyPzE00wTVgAGuSy/0kdX2R+777XbzPIdl46EAmngosH63n/LrgeJ3T I+Pprh9VZ01t03WUmxJL67DpBSfNtL7HWjBWq6JYqhL9qUcCHhG9UY8nRWQ4yvr+EPN9QFQgC9hn1 ihJgdXv+lO8dLYUMIw8PvcH/Bd6wdgRPE0TSH5CTVrDuBqhSzVj59vkOIQbBRAOV6JAGRA5CO0Tzt hIEkHtCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVElw-0007Ns-Ug; Thu, 14 Nov 2019 13:02:52 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVElt-0007Mx-6Z for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2019 13:02:50 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 05:02:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,304,1569308400"; d="scan'208";a="235659969" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.197]) ([10.237.72.197]) by fmsmga002.fm.intel.com with ESMTP; 14 Nov 2019 05:02:46 -0800 Subject: Re: [PATCH] mmc: sdhci-of-at91: fix quirk2 overwrite To: Eugen.Hristev@microchip.com, Ludovic.Desroches@microchip.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1573736352-3597-1-git-send-email-eugen.hristev@microchip.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <48f8d20a-66ad-4c6d-b387-bdcc76fda0c0@intel.com> Date: Thu, 14 Nov 2019 15:01:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1573736352-3597-1-git-send-email-eugen.hristev@microchip.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_050249_251754_F1847608 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/11/19 2:59 PM, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev > > The quirks2 are parsed and set (e.g. from DT) before the quirk for broken > HS200 is set in the driver. > The driver needs to enable just this flag, not rewrite the whole quirk set. > > Fixes: 7871aa60ae00 ("mmc: sdhci-of-at91: add quirk for broken HS200") > Signed-off-by: Eugen Hristev Acked-by: Adrian Hunter > --- > > drivers/mmc/host/sdhci-of-at91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 496844a..5fe6684 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -389,7 +389,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > pm_runtime_use_autosuspend(&pdev->dev); > > /* HS200 is broken at this moment */ > - host->quirks2 = SDHCI_QUIRK2_BROKEN_HS200; > + host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200; > > ret = sdhci_add_host(host); > if (ret) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel