From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44F02CD4F58 for ; Tue, 19 May 2026 06:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qtX47EwXH9Xw59B6eB1b2VBmN1wnu7ZBE05akEL/Pm0=; b=MGbsyXsRw2XpwenQ5H625c0JmF CLD44w//7EIiqTpYmT8m8baA9Vpd2CS1tF8bT/837+tJVWvaoYXJ8GWTHddM9a2vLmVuBhSwLgRR2 VyZpYklt17L6X/aj3a2G/QdZYS6Ogh9mhQhroBxDFvdow/q4UBM2AXqg2ItlEKjo3dug/MhIO3Yei MZbwJDBPSqtTKEVdeljjmPV9edRd19eDCSBHOWVqzJhT5xpDJgQxewnJV732nci4JWdjX6keusLe9 7rm78DU9mKsyCmlLA+H+PXeHNdXNmsJwykOF2RvieDWG80vIR4zvDk8A1cn30/7iNtgIdhI7kw/H1 HRhtbhyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPE4W-00000000Mck-3SEb; Tue, 19 May 2026 06:36:56 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPE4V-00000000Mc7-079c; Tue, 19 May 2026 06:36:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 78EF260052; Tue, 19 May 2026 06:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 915E7C2BCB3; Tue, 19 May 2026 06:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779172614; bh=7AaeSvfyqPMp9R+dhmGlKn/SXtEA+e23F3uNc8wGbDU=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=sxKuhoutbBtK0thy7g5VaN56hzdcLoA0tILrxGQOek5+j+K/xXcdlk7QLBdLhYcJd ON7Izh0cieqjaKKnzTWscuOox14dF0WZROd5EZ1b0Dge0P2DhT+XCTnym3s1ZZjGJX KQHPS3qrU+Z30q3sodjyEBu1OI28g5L1IvExI3ZE0KU8QBGPcSc8drqsaNTsEZ7TWd ycoA5MW5zdgtgaeSr8GQqSNHrnPLUHm5G3x/vzRN6sMUSDJP5qFnWeksX3Sgd5fT/W 238OQVJtmsy0ggkXFLpOOs+8wfxS0WZd62q7RsjV2L8zsYusvz1yKgUQ+c5KZSZShu Gon7WAJKaUpew== Message-ID: <48fdaecd-a8b9-473d-aad2-35f5e459f161@kernel.org> Date: Tue, 19 May 2026 08:36:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans Verkuil Subject: Re: [PATCH 05/13] drm/meson: encoder_hdmi: Use CEC phys addr from display_info To: Jonas Karlman , Neil Armstrong , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-6-jonas@kwiboo.se> Content-Language: en-US, nl In-Reply-To: <20260518194744.2483580-6-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/05/2026 21:47, Jonas Karlman wrote: > The dw-hdmi bridge detect() func now updates EDID for the connector. > Something that ensures that display_info.source_physical_address has an > updated CEC phys addr when the hpd_notify() func is called. > > Change to use display_info source_physical_address directly instead of > re-reading EDID to set the CEC phys addr at HPD interrupt. > > Signed-off-by: Jonas Karlman Acked-by: Hans Verkuil Regards, Hans > --- > drivers/gpu/drm/meson/meson_encoder_hdmi.c | 26 ++++------------------ > 1 file changed, 4 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c > index 55c0601df3c6..1b9a1d9ed3d3 100644 > --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c > @@ -330,28 +330,10 @@ static void meson_encoder_hdmi_hpd_notify(struct drm_bridge *bridge, > if (!encoder_hdmi->cec_notifier) > return; > > - if (status == connector_status_connected) { > - const struct drm_edid *drm_edid; > - const struct edid *edid; > - > - drm_edid = drm_bridge_edid_read(encoder_hdmi->bridge.next_bridge, > - encoder_hdmi->connector); > - if (!drm_edid) > - return; > - > - /* > - * FIXME: The CEC physical address should be set using > - * cec_notifier_set_phys_addr(encoder_hdmi->cec_notifier, > - * connector->display_info.source_physical_address) from a path > - * that has read the EDID and called > - * drm_edid_connector_update(). > - */ > - edid = drm_edid_raw(drm_edid); > - > - cec_notifier_set_phys_addr_from_edid(encoder_hdmi->cec_notifier, edid); > - > - drm_edid_free(drm_edid); > - } else > + if (status == connector_status_connected) > + cec_notifier_set_phys_addr(encoder_hdmi->cec_notifier, > + connector->display_info.source_physical_address); > + else > cec_notifier_phys_addr_invalidate(encoder_hdmi->cec_notifier); > } >