From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C5AEC54E67 for ; Wed, 27 Mar 2024 09:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BxpvD9UMJHjPv3YA875uHBD1qIsvVlYBuHH2uuDVeBE=; b=tStd4wjT8dHHj1 GdBKKPClaN8jnk9Wy/8IP3KEahlWjMHb+ohQmweo8k6A/VrO7zJQCrVx66tULMhXBx3v0T4gDv+ah tDgw9ffvXcYTZDms0U3/0NKPpBzMaZJgFNMq9kMi3z0ldwmCHCrERhRA50UGEJq6U1X9lAa0cNm67 3rBXQHSDbTd4Cb5ucCumDUXsdhmRBZ7vW4hIcLv5kRtBQ09PSjufUN5krbjT53UuZiAm3N21ad8Xa Okz6Em0lfUeljXKMtkokpiPSOJswRjRJcgfXAj3Q9ciAu+7EkKg0S5dF+R+YNO0ZFMZsozyHj+3eu 2hdWqeIUPF7AZJpVBAVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpPcy-00000008Eq6-0mXt; Wed, 27 Mar 2024 09:31:24 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpPcu-00000008EpI-2pmA for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 09:31:22 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42R9VApg033380; Wed, 27 Mar 2024 04:31:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1711531870; bh=mFIeq2rRiY8WqXVke/uUYNI4+SZR1gOPxX20+WHNUgU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=mN+OaX8UTonabTD9IAYNcXY0ilJxstmnMW6DJjXgo23+OYXMoo/1cMTC7MVlPz4WN DzSNuLBzlgtZak4XZLAaxhSURxCUFLQpO0pGgkUzV+8jPn8AhC92sF3pR0wsAjrqP+ Ts0XdYfn2FLlPlIZ0T/jIpNRpXtXm+b3GklR098I= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42R9VA1f067486 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 Mar 2024 04:31:10 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 27 Mar 2024 04:31:10 -0500 Received: from fllvsmtp8.itg.ti.com (10.64.41.158) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 27 Mar 2024 04:31:10 -0500 Received: from localhost (uda0492258.dhcp.ti.com [172.24.227.9]) by fllvsmtp8.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42R9V9Hj001289; Wed, 27 Mar 2024 04:31:09 -0500 Date: Wed, 27 Mar 2024 15:01:08 +0530 From: Siddharth Vadapalli To: Bjorn Helgaas CC: Siddharth Vadapalli , , , , , , , , , , , , , , Subject: Re: [PATCH v6] PCI: keystone: Fix pci_ops for AM654x SoC Message-ID: <49077b26-9ca3-4ef7-8b25-8c58adf95f5d@ti.com> References: <20240326144258.2404433-1-s-vadapalli@ti.com> <20240326232403.GA1502764@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240326232403.GA1502764@bhelgaas> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_023120_924870_5A7B1B56 X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024 at 06:24:03PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 26, 2024 at 08:12:58PM +0530, Siddharth Vadapalli wrote: > > In the process of converting .scan_bus() callbacks to .add_bus(), the > > ks_pcie_v3_65_scan_bus() function was changed to ks_pcie_v3_65_add_bus(). > > The .scan_bus() method belonged to ks_pcie_host_ops which was specific > > to controller version 3.65a, while the .add_bus() method had been added > > to ks_pcie_ops which is shared between the controller versions 3.65a and > > 4.90a. Neither the older ks_pcie_v3_65_scan_bus() method, nor the newer > > ks_pcie_v3_65_add_bus() method is applicable to the controller version > > 4.90a which is present in AM654x SoCs. > > > > Thus, as a fix, move the contents of "ks_pcie_v3_65_add_bus()" to the > > .msi_init callback "ks_pcie_msi_host_init()" which is specific to the > > 3.65a controller. Also, move the definitions of ks_pcie_set_dbi_mode() > > and ks_pcie_clear_dbi_mode() above ks_pcie_msi_host_init() in order to > > avoid forward declaration. > > If it's possible to split this into two patches (one that strictly > *moves* the code without otherwise changing it, and another that makes > the actual fix), it would be easier to review the fix. It's a pain to > have to compare the code in the old location with that in the new > location. Sure. I will do so and post the v7 patch. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel