From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BAF8C98338 for ; Sun, 27 Sep 2026 20:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+rmtSBQ8iEU/mOIOP0F7DWxl8lfXJ0xJmKbLo/9cuX0=; b=PU1mb305Rk3KppXZJi04awXxxI DZZWHSU6yDgSVfL7VnhlfNXgml5vRGzT1sfSUnLqUMtQZMPPQvcNVCbd0tujLFWG1okYL55BDDsNz DbYMqYG6PV3i0NlLGxddPx1k93PP6wL8QQza8y9rNgEd0TuxphJPhI2iAZhbVg+nnJoLhurzqxegq urPjuy5Hd5HDebASt/pc4z1+w0RlI6kaSUGMspaHQAnWpKVzV/5/XYKW2B0+2X8l18x9UuJEZw83+ e4h71wS1ZyzlJP7DrbX4XOJfOpqsmUHDju1hUVCD1xUFj7vdpsQ1eQkSCHDHaxeV63TGVChfjZKs0 LcE2jLMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAvpe-0000000Gqcl-1J7N; Sun, 27 Sep 2026 20:50:46 +0000 Received: from xs1.mindbit.ro ([80.86.107.70] helo=mail.mindbit.ro) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAvpb-0000000GqcG-17Bi for linux-arm-kernel@lists.infradead.org; Sun, 27 Sep 2026 20:50:44 +0000 Received: from dog.kanata.rendec.net (pool-174-112-193-187.cpe.net.cable.rogers.com [174.112.193.187]) by mail.mindbit.ro (Postfix) with ESMTPSA id D13ACD0954; Sun, 27 Sep 2026 23:50:37 +0300 (EEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.mindbit.ro D13ACD0954 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rendec.net; s=default; t=1790542239; bh=+rmtSBQ8iEU/mOIOP0F7DWxl8lfXJ0xJmKbLo/9cuX0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=qXXYO4ECyKgsBW2su65wMyseJRxSfeRrLB7zttnakUSx1jMb8mO1xWATI/R+0+/42 QU3gb0Ey5OSM9rgHPZ/acfoPHxsVvWYATcbJyUBC7pfx05IyzlMuxJ4uyBeu+DVQoE KL33BNaRil5AW5HmJax/VYdO5Y9B+BhDhXVAU3MZtuAFe68VUNfJM1EbIYs+nAr5Rn Sy1i+rzR51igzyRa5Sa09tbEdxoNcpIpfJI6CvvxeXXkMZ0fKjG1KvqEAsTS5maKdV QJsQccQ93mevmYRHl9UKkyI3y3dWAzh5stdyLqbTlKTekxPBZGxhGHK0oN6YTN/hvh ERdw1/BUL++9g== Message-ID: <490d315dc08b25691fce7d0eb440224976e5e953.camel@rendec.net> Subject: Re: [PATCH] irqchip/atmel-aic[5]: Disable interrupts in the irq_pm_shutdown() callbacks From: Radu Rendec To: Karl Mehltretter , Thomas Gleixner Cc: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Boris Brezillon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sun, 27 Sep 2026 16:50:36 -0400 In-Reply-To: <20260926004124.88221-1-kmehltretter@gmail.com> References: <20260926004124.88221-1-kmehltretter@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260927_135043_484173_5E9BA8C3 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2026-09-26 at 02:41 +0200, Karl Mehltretter wrote: > irq_gc_shutdown() calls the irq_pm_shutdown() callbacks from > syscore_shutdown() with interrupts enabled. aic_pm_shutdown() and > aic5_pm_shutdown() take the generic chip lock with raw_spin_lock(), and > irq_gc_eoi() takes the same lock from the interrupt handler. An > interrupt from the chip while the lock is held spins in irq_gc_eoi() > and hangs the reboot. >=20 > Lockdep reports this on every reboot of a SAM9X75 Curiosity board: >=20 > =C2=A0 WARNING: inconsistent lock state > =C2=A0 inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage. > =C2=A0 busybox/101 [HC0[0]:SC0[0]:HE1:SE1] takes: > =C2=A0 c1c2b434 (&gc->lock){?.-.}-{2:2}, at: aic5_pm_shutdown+0x34/0xd8 > =C2=A0 {IN-HARDIRQ-W} state was registered at: > =C2=A0=C2=A0=C2=A0 ... > =C2=A0=C2=A0=C2=A0 irq_gc_eoi+0x28/0x60 > =C2=A0=C2=A0=C2=A0 handle_fasteoi_irq+0x120/0x214 > =C2=A0 ... > =C2=A0=C2=A0 aic5_pm_shutdown from irq_gc_shutdown+0x4c/0x58 > =C2=A0=C2=A0 irq_gc_shutdown from syscore_shutdown+0x5c/0x9c > =C2=A0=C2=A0 syscore_shutdown from kernel_restart+0x34/0x78 > =C2=A0=C2=A0 kernel_restart from sys_reboot+0x180/0x25c >=20 > Use the irqsave guard, as > commit 33517881ede7 ("irqchip/brcmstb-l2: Use _irqsave locking variants i= n non-interrupt code") > did for brcmstb-l2. >=20 > Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") > Cc: stable@vger.kernel.org > Assisted-by: LLM > Signed-off-by: Karl Mehltretter > --- >=20 > Notes: > =C2=A0=C2=A0=C2=A0 Tested on a SAM9X75 Curiosity with v7.2.8 plus this pa= tch, PREEMPT_RT and > =C2=A0=C2=A0=C2=A0 non-RT lockdep builds (clang 22, LLVM=3D1): the report= is gone. On SAM9X60 > =C2=A0=C2=A0=C2=A0 and SAM9X7, lockdep only gets this far once the PIT64B= timer report at > =C2=A0=C2=A0=C2=A0 boot is fixed, which I am sending separately. The irq-= atmel-aic.c change > =C2=A0=C2=A0=C2=A0 is build-tested only. >=20 > =C2=A0drivers/irqchip/irq-atmel-aic.c=C2=A0 | 2 +- > =C2=A0drivers/irqchip/irq-atmel-aic5.c | 2 +- > =C2=A02 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-= aic.c > index 1dcc52760eca..4a7935e75e4d 100644 > --- a/drivers/irqchip/irq-atmel-aic.c > +++ b/drivers/irqchip/irq-atmel-aic.c > @@ -123,7 +123,7 @@ static void aic_pm_shutdown(struct irq_data *d) > =C2=A0{ > =C2=A0 struct irq_chip_generic *gc =3D irq_data_get_irq_chip_data(d); > =C2=A0 > - guard(raw_spinlock)(&gc->lock); > + guard(raw_spinlock_irqsave)(&gc->lock); > =C2=A0 irq_reg_writel(gc, 0xffffffff, AT91_AIC_IDCR); > =C2=A0 irq_reg_writel(gc, 0xffffffff, AT91_AIC_ICCR); > =C2=A0} > diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel= -aic5.c > index 1f14b401f71d..07a317ed06ef 100644 > --- a/drivers/irqchip/irq-atmel-aic5.c > +++ b/drivers/irqchip/irq-atmel-aic5.c > @@ -217,7 +217,7 @@ static void aic5_pm_shutdown(struct irq_data *d) > =C2=A0 struct irq_chip_generic *gc =3D irq_data_get_irq_chip_data(d); > =C2=A0 int i; > =C2=A0 > - guard(raw_spinlock)(&bgc->lock); > + guard(raw_spinlock_irqsave)(&bgc->lock); > =C2=A0 for (i =3D 0; i < dgc->irqs_per_chip; i++) { > =C2=A0 irq_reg_writel(bgc, i + gc->irq_base, AT91_AIC5_SSR); > =C2=A0 irq_reg_writel(bgc, 1, AT91_AIC5_IDCR); Reviewed-by: Radu Rendec