From: Matthias Brugger <matthias.bgg@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Wei Yongjun <weiyongjun1@huawei.com>
Cc: kernel-janitors@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()
Date: Fri, 15 May 2020 16:52:37 +0200 [thread overview]
Message-ID: <490d37e9-3661-ef4b-75bc-8ca7523e5bde@gmail.com> (raw)
In-Reply-To: <923a48d8-eb9e-2729-a4be-dad63a6df28a@collabora.com>
On 06/05/2020 19:24, Enric Balletbo i Serra wrote:
> Hi Wei,
>
> Thank you for your patch.
>
> On 6/5/20 16:13, Wei Yongjun wrote:
>> Add the missing platform_device_unregister() before return
>> from mtk_mmsys_probe() in the error handling case.
>>
>> Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
applied to v5.7-next/soc
Thanks!
>> ---
>> drivers/soc/mediatek/mtk-mmsys.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
>> index 05e322c9c301..05ce4cb464b0 100644
>> --- a/drivers/soc/mediatek/mtk-mmsys.c
>> +++ b/drivers/soc/mediatek/mtk-mmsys.c
>> @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>>
>> drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
>> PLATFORM_DEVID_AUTO, NULL, 0);
>> - if (IS_ERR(drm))
>> + if (IS_ERR(drm)) {
>> + platform_device_unregister(clks);
>> return PTR_ERR(drm);
>> + }
>>
>> return 0;
>> }
>>
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-05-15 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 14:13 [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe() Wei Yongjun
2020-05-06 17:24 ` Enric Balletbo i Serra
2020-05-15 14:52 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490d37e9-3661-ef4b-75bc-8ca7523e5bde@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox