From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB000C2BB1D for ; Mon, 16 Mar 2020 15:37:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77C4120663 for ; Mon, 16 Mar 2020 15:37:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X8yacAn8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77C4120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X4XPF61otE8MmCMQK/neIK+OILW5H9wpanNiHteR67I=; b=X8yacAn84fvyKO kd41guH19NGO+cm0fSLC8/nUXk684IPokkcXRE4EVOnJh2PWgII1LuRV7fyCoLAuypJaQDDhs5i9/ 3YIp1vkPCJgqAi5SWdvh+eVlHOW/ZGYq1xJlTZLScqKMKtLux0D4VzjORAegIJ4wwF3RQH/GvKAY0 Bjil0GzUvtgOWwOFpBCOlHASnrkpS7vo40YXOqc1U0hlMWhNXVcoR9wLAgz6fz8ahPbXdpwJGjMS2 V16Fj0xEkTE1g1+1rBFu4SONaB99t47vvVmQRjhTVUaob/XPtuYp975SnTIbJlpGk5lINMRcRzExp mcAUNtO87QDZXMOWGF3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDrnd-00054F-Fo; Mon, 16 Mar 2020 15:37:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDrna-00053g-7C for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 15:37:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 400A51FB; Mon, 16 Mar 2020 08:37:01 -0700 (PDT) Received: from [10.37.9.38] (unknown [10.37.9.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03C833F534; Mon, 16 Mar 2020 08:36:55 -0700 (PDT) Subject: Re: [PATCH v3 21/26] arm64: Introduce asm/vdso/arch_timer.h To: Catalin Marinas References: <20200313154345.56760-1-vincenzo.frascino@arm.com> <20200313154345.56760-22-vincenzo.frascino@arm.com> <20200315183151.GE32205@mbp> From: Vincenzo Frascino Message-ID: <4914ad9c-3eaf-b328-f31b-5d3077ef272f@arm.com> Date: Mon, 16 Mar 2020 15:37:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200315183151.GE32205@mbp> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_083702_307485_FDF2ED2A X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Dmitry Safonov <0x7f454c46@gmail.com>, linux-mips@vger.kernel.org, Will Deacon , linux-arch@vger.kernel.org, Marc Zyngier , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Kees Cook , Arnd Bergmann , Will Deacon , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Andrei Vagin , Stephen Boyd , Nick Desaulniers , linux-kernel@vger.kernel.org, Mark Salyzyn , Paul Burton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, On 3/15/20 6:32 PM, Catalin Marinas wrote: > On Fri, Mar 13, 2020 at 03:43:40PM +0000, Vincenzo Frascino wrote: >> The vDSO library should only include the necessary headers required for >> a userspace library (UAPI and a minimal set of kernel headers). To make >> this possible it is necessary to isolate from the kernel headers the >> common parts that are strictly necessary to build the library. >> >> Introduce asm/vdso/arch_timer.h to contain all the arm64 specific >> code. This allows to replace the second isb() in __arch_get_hw_counter() >> with a fake dependent stack read of the counter which improves the vdso >> library peformances of ~4.5%. Below the results of vdsotest [1] ran for >> 100 iterations. > > The subject seems to imply a non-functional change but as you read, it > gets a lot more complicated. Could you keep the functional change > separate from the header clean-up, maybe submit it as an independent > patch? And it shouldn't go in without Will's ack ;). > It is fine by me. I will repost the series with the required fixes and without this patch. This will give to me enough time to address Mark's comments as well and to Will to have a proper look. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel