From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DDD6C43381 for ; Sun, 31 Mar 2019 16:20:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D5DF20882 for ; Sun, 31 Mar 2019 16:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GWjmNqvu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D5DF20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qSn7g5MDzEFeCDmQgGyXP01c3likVmzvOgMKP6fFZ0Q=; b=GWjmNqvuOgrjxo wx9ThvFrkrlY/GwC/olSaXspjjeCBvkrLM/pSPdnjimYlHitnXdGddymbUfwBvZnDXmi2cZiNtahK Htxxj+mhmBsd6Fngq8pTY6zGF8BmJRDxLKWXaJUb18eqTsPSAwWnfm3efH4EH6XvqfE9OG+5C+DXC 2/AmpFVqF1LHC5TmaXWfIdFFFUxC7ct7uv3vkHdPi43KUTAwmqgbq9s7HZpl52MALGIn8mAT0q80O AeVKBJ48Do2uxKbqrq/2WQ15PqQraZwp+JrzbqYLbC9TiOxudRvdIJV6CxnjKawtfZmymeb7OHD7b a3ZDdvxTxZB7Yaru6olA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAdBc-00065a-To; Sun, 31 Mar 2019 16:19:56 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAdBZ-00064o-Hl; Sun, 31 Mar 2019 16:19:54 +0000 Received: from p5b1271a2.dip0.t-ipconnect.de ([91.18.113.162] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hAdBS-0000sn-8k; Sun, 31 Mar 2019 18:19:46 +0200 From: Heiko Stuebner To: Johan Jonker Subject: Re: [PATCH v5 5/5] drm: rockchip: add fixed screen size DVI-D support for rk3066 hdmi Date: Sun, 31 Mar 2019 18:19:45 +0200 Message-ID: <4928946.oK5HkskicG@phil> In-Reply-To: <20190321001440.31057-6-jbx6244@gmail.com> References: <20190321001440.31057-1-jbx6244@gmail.com> <20190321001440.31057-6-jbx6244@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_091953_741150_4483AAA1 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, airlied@linux.ie, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johan, Am Donnerstag, 21. M=E4rz 2019, 01:14:40 CEST schrieb Johan Jonker: > Add fixed screen size DVI-D support > for rk3066 hdmi with an extra patch. > = > Signed-off-by: Johan Jonker > +static const struct drm_display_mode edid_cea_modes[] =3D { > + /* 4 - 1280x720@60Hz 16:9 */ > + { DRM_MODE("1280x720", DRM_MODE_TYPE_DRIVER, 74250, 1280, 1390, > + 1430, 1650, 0, 720, 725, 730, 750, 0, > + DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC), > + .vrefresh =3D 60, .picture_aspect_ratio =3D HDMI_PICTURE_ASPECT_16_9,= }, > +}; you already dropped this patch from v6, but just for completeness sake, I don't think there should be a static mode for dvi displays. Similar to hdmi, dvi also can use ddc to read the monitor edid and some sort of static mode might behave badly if for example a display with less than this 720p is connected. I think I remember reading in the Rockchip tree that they added that for the case reading the edid fails, but if that happens the reading should be fixed and not worked around a failure :-) Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel