From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87FBBC433FE for ; Thu, 3 Nov 2022 07:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HXkBDQKYfoim25hZSIA1A7IyIqdL6BRC0Y8T1pCtbGU=; b=WSGQapEt6uQogQ 2HgpHrlsWSuMnk/mRbeldzSaH21241GCsVDfzUffXauREdtERISpn7enH1NkxylDavL7/HfwHDxrP ZKcYjYP4kMuNXtMX+baIo3lSjUjRgOLNbTyU6D88lCFfGbzBpEEwVtYUc6Prd3TykK769dbxt4yE5 SVdZB2O8rdaiDvFJuI6Jnq/IWAq8ThOos69nYXvsXZEkELyCrzAGivZ3aFTxPP5LBY6tmgE6SN1cR 3qehN4GuarBAzju+d2H2G8Rt2nFnczhJ02Yjasu9Wid8LN3mQ9SfGKn8UyIeGWg352u87S4zpRz2Z TDOKUYp9yAIoRChUtuUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqV5a-00GXkd-C1; Thu, 03 Nov 2022 07:56:38 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqV5W-00GXk7-Jt for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 07:56:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667462194; x=1698998194; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4rMyZKhdzBeKXWl6bAxi/bEUKKop1w5kLjUHDIwa0/w=; b=qdsRSl5oSfSyLLBSgj7GwYuPSb9EVIcVPRuvSXTW+AOTslS22RVNzJS8 9cusOK4iw8BzqKv5a71yrBWFhX8Q22GCDSDJXsnbmeTUQfSHPs3iTWmzd 5LWnvreojWkMxF1+fpPuuF+rXK0glcgHH++DKrKfVYgKBqLNO5TdF5H2J Q3sFo8kKi5K8JVCZr+ZC1xlFmZZ6I1U/MKhj2SUqHhIFXBxsWAg2y80W6 7yIZeJmyaPgJKcnkvbsV4gCaV3/8KpuQqw4hZvuhX/Y1LmQnYVWAeGBbB QXdy3CBYmINfImzcNCXPbQeICyfUsMYhr16ydSEk+n2RDc9f/rgKM8WPB g==; X-IronPort-AV: E=Sophos;i="5.95,235,1661810400"; d="scan'208";a="27125816" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 03 Nov 2022 08:56:32 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 03 Nov 2022 08:56:32 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 03 Nov 2022 08:56:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667462192; x=1698998192; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4rMyZKhdzBeKXWl6bAxi/bEUKKop1w5kLjUHDIwa0/w=; b=SyA92538cSUzLHLMyMCP/7xcPBsWHElHuA6m+FPSCk+WyPP7azkKtUbd aN7xG+y9kfEIDYyjJjNmifthN731mHCxNRS2Pbb/JuJTF7qs/9HPwteyd tSV8gBzoAiTlGtyI9WpTywtEfnW24ZTJuUPXbq6pzTxpkuM8VWRyvrWSJ 0AgoYOGXKyMZ8r8N57YrqqrcxH9VCABcH31RdLWXaUHLzMNahfFs3Pk5M r8TFSG+aRHjN2PBJap70lkRovNDVi8XTrBnq4/QEEKBF2CXTV2a9GUfzL bB7eplZZudwjdfkY7VSMlFkBETRKa0zTLD5nON13O+c61vGpagSYraGlG A==; X-IronPort-AV: E=Sophos;i="5.95,235,1661810400"; d="scan'208";a="27125815" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 03 Nov 2022 08:56:32 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 023C9280056; Thu, 3 Nov 2022 08:56:31 +0100 (CET) From: Alexander Stein To: linux-arm-kernel@lists.infradead.org, Marek Vasut Cc: Fabio Estevam , Peng Fan , Richard Zhu , Shawn Guo , NXP Linux Team , Marek Vasut Subject: Re: [PATCH 3/3] arm64: dts: imx8mq: Deduplicate PCIe clock-names property Date: Thu, 03 Nov 2022 08:56:30 +0100 Message-ID: <4937041.GXAFRqVoOG@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221102212248.138284-3-marex@denx.de> References: <20221102212248.138284-1-marex@denx.de> <20221102212248.138284-3-marex@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_005635_069611_30FB41A7 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, Am Mittwoch, 2. November 2022, 22:22:48 CET schrieb Marek Vasut: > Move the PCIe clock-names property from various DTs into SoC dtsi to > reduce duplication. In case of a couple of boards, reorder the clock > so they match the order in yaml DT bindings. > > Signed-off-by: Marek Vasut > --- > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Richard Zhu > Cc: Shawn Guo > Cc: NXP Linux Team > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 10 ++++------ > .../boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 10 ++++------ > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts | 5 ++--- > .../arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts | 10 ++++------ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 + > 5 files changed, 15 insertions(+), 21 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts index > 2102e9b57697c..0e095bb176c5f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > @@ -355,10 +355,9 @@ &pcie0 { > pinctrl-0 = <&pinctrl_pcie0>; > reset-gpio = <&gpio5 28 GPIO_ACTIVE_LOW>; > clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>, > - <&clk IMX8MQ_CLK_PCIE1_AUX>, > + <&pcie0_refclk>, > <&clk IMX8MQ_CLK_PCIE1_PHY>, > - <&pcie0_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE1_AUX>; > vph-supply = <&vgen5_reg>; > status = "okay"; > }; > @@ -368,10 +367,9 @@ &pcie1 { > pinctrl-0 = <&pinctrl_pcie1>; > reset-gpio = <&gpio5 12 GPIO_ACTIVE_LOW>; > clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>, > - <&clk IMX8MQ_CLK_PCIE2_AUX>, > + <&pcie0_refclk>, > <&clk IMX8MQ_CLK_PCIE2_PHY>, > - <&pcie0_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE2_AUX>; > vpcie-supply = <®_pcie1>; > vph-supply = <&vgen5_reg>; > status = "okay"; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts index > a91c136797f60..6376417e918c2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > @@ -245,20 +245,18 @@ &pcie0 { > pinctrl-0 = <&pinctrl_pcie0>; > reset-gpio = <&gpio1 9 GPIO_ACTIVE_LOW>; > clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>, > - <&clk IMX8MQ_CLK_PCIE1_AUX>, > + <&pcie0_refclk>, > <&clk IMX8MQ_CLK_PCIE1_PHY>, > - <&pcie0_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE1_AUX>; > status = "okay"; > }; > > /* Intel Ethernet Controller I210/I211 */ > &pcie1 { > clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>, > - <&clk IMX8MQ_CLK_PCIE2_AUX>, > + <&pcie1_refclk>, > <&clk IMX8MQ_CLK_PCIE2_PHY>, > - <&pcie1_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE2_AUX>; > fsl,max-link-speed = <1>; > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts > b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts index > 055031bba8c4b..200268660518d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts > @@ -197,10 +197,9 @@ &pcie1 { > pinctrl-0 = <&pinctrl_pcie1>; > reset-gpio = <&gpio3 23 GPIO_ACTIVE_LOW>; > clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>, > - <&clk IMX8MQ_CLK_PCIE2_AUX>, > + <&pcie1_refclk>, > <&clk IMX8MQ_CLK_PCIE2_PHY>, > - <&pcie1_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE2_AUX>; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts > b/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts index > d7660eab68b94..344cfdaeb1d59 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dts > @@ -105,10 +105,9 @@ &led2 { > &pcie0 { > reset-gpio = <&expander0 14 GPIO_ACTIVE_LOW>; > clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>, > - <&clk IMX8MQ_CLK_PCIE1_AUX>, > + <&pcie0_refclk>, > <&clk IMX8MQ_CLK_PCIE1_PHY>, > - <&pcie0_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE1_AUX>; > epdev_on-supply = <®_vcc_3v3>; > hard-wired = <1>; > status = "okay"; > @@ -120,10 +119,9 @@ &pcie0 { > */ > &pcie1 { > clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>, > - <&clk IMX8MQ_CLK_PCIE2_AUX>, > + <&pcie1_refclk>, > <&clk IMX8MQ_CLK_PCIE2_PHY>, > - <&pcie1_refclk>; > - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + <&clk IMX8MQ_CLK_PCIE2_AUX>; > epdev_on-supply = <®_vcc_3v3>; > hard-wired = <1>; > status = "okay"; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index > c6530e5c7fef5..c47e2d7235d3e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -1529,6 +1529,7 @@ pcie0: pcie@33800000 { > <0 0 0 4 &gic GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; > fsl,max-link-speed = <2>; > linux,pci-domain = <0>; > + clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux"; > power-domains = <&pgc_pcie>; > resets = <&src IMX8MQ_RESET_PCIEPHY>, > <&src IMX8MQ_RESET_PCIE_CTRL_APPS_EN>, For imx8mq.dtsi and imx8mq-tqma8mq-mba8mx.dts: Reviewed-by: Alexander Stein Thanks Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel