Re: [PATCH v3 0/3] x86,fs/resctrl,arm_mpam: Factor MBA parse-time conversion to be per-arch

[Ben Horgan <ben.horgan@arm.com>]

Hi Reinette,

On 6/5/26 19:41, Reinette Chatre wrote:
> Hi Ben,
> 
> On 5/15/26 7:06 AM, Ben Horgan wrote:
>> This is a new version of Dave Martin's patch [1] to delegate rounding of
>> bandwidth control user values to the arch code. As there is now more than one
>> architecture using resctrl, I split the original patch into two, a core resctrl
>> patch and an x86 patch, and added an MPAM patch. Please let me know if the patch
>> break down and ordering is sensible and whether the pattern should be followed
>> for any future similar changes.
> 
> This ordering is sensible to me. I find the patch breakdown a bit fragmented since
> the logical resctrl fs change is split yet I also find that you did what was best
> to ensure bisectability. I find small changes that are local to subsystems easier to
> consider and believe it would be ideal to only have patches touching multiple
> subsystems when it cannot be avoided, for example when doing otherwise would break
> bisect. Even so, we may learn of better ways to do this when this series is considered
> for x86 inclusion.

Thanks for giving me your view on this, the review and the R-b's. I find
all your proposed changes reasonable and have included them (and only
those changes) in a v4 which I will post shortly.

Thanks,

Ben

> 
> Reinette
>