public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-vpu: Fix imx8qm VPU IRQs
Date: Mon, 12 Aug 2024 11:11:51 +0200	[thread overview]
Message-ID: <4944000.31r3eYUQgx@steina-w> (raw)
In-Reply-To: <PAXPR04MB8459C55F49C08A6B6A0239E988852@PAXPR04MB8459.eurprd04.prod.outlook.com>

Am Montag, 12. August 2024, 10:45:54 CEST schrieb Peng Fan:
> > Subject: [PATCH 1/1] arm64: dts: imx8-ss-vpu: Fix imx8qm VPU IRQs
> > 
> > imx8-ss-vpu only contained imx8qxp IRQ numbers, only mu2_m0 uses
> > the correct imx8qm IRQ number, as imx8qxp lacks this MU.
> > Fix this by providing imx8qm IRQ numbers in the main imx8-ss-vpu.dtsi
> > and override the IRQ numbers in SoC-specific imx8qxp-ss-vpu.dtsi,
> > similar to reg property for VPU core devices.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > I did not include a Fixes tag as adding support for imx8qxp and imx8qm
> > is split into several commits. It's at lease the combination of the
> > following commits:
> > 
> > 0d9968d98467d ("arm64: dts: freescale: imx8q: add imx vpu codec
> > entries") b4efce453f0ca ("arm64: dts: imx8qm: add vpu decoder and
> > encoder")
> 
> If you are using one patch to try to fix upper two commits, I think
> it would be better to separate the patch to fix the error of
> each upper commit and include Fixes tag.

Commit 0d9968d98467d ("arm64: dts: freescale: imx8q: add imx vpu codec
entries") is talking about imx8q. This is most probably i.MX8 family, while
I confused imx8q with imx8qxp, which is i.MX8X family...
The naming scheme is so confusing :(

For that reason I'll just add a Fixes for 0d9968d98467d.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/




      reply	other threads:[~2024-08-12  9:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08  9:03 [PATCH 1/1] arm64: dts: imx8-ss-vpu: Fix imx8qm VPU IRQs Alexander Stein
2024-08-12  8:45 ` Peng Fan
2024-08-12  9:11   ` Alexander Stein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4944000.31r3eYUQgx@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox