From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398AAC48BDF for ; Thu, 24 Jun 2021 07:33:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 095A26023B for ; Thu, 24 Jun 2021 07:33:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 095A26023B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A3VP1xruD7dszGbIu6oJY8d6ZAhYWhpIE3BnCOsJtxs=; b=F1JUu4YUj47buNLdifXisfpnS5 zifyblXc9Er2YWAB9BpjyD50Of4Uq9/g+Agr2iZLeWoJ0y7NFveCRm5ULiHJ4LeU0paEnvSFr4V3d ABCHeCPQZkJUYAQ1pYicaup8E9iAuupZ9O4e1d4NGSMuyQbog6Em2KwLRUfUxAsOgUsouF1Bh0ek7 H7LCOu1VmHsWMEO6swzccf6eG4bjbKM7v3KIaD1wX2E7JXuCA7QIK8a2KkXu3txk/kSw844Q3A//C 9STFvIRSx/kGLZgUounMbaHy8TWd7AkMt9s/X0IlvSR+1wNAH8aVCVgIGTQneyOT7JuwHT+SpACe4 DAHjB9sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwJqA-00DEPO-Ua; Thu, 24 Jun 2021 07:31:59 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwJpV-00DDft-JK for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 07:31:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624519876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ummzXLEBVOW6zJVjd9RvyjdRwJ4z9g5ls7IEU8SqM4=; b=Y9EN46vlYv8dx7xo7zo/N+e35jQUwxm54WbN9oZLJcohYJhlj7Q1ZduFrIayWMoLH36Nfe Wy5E1JNH8nsLqI8kl6vAKJt8wDohtFajnpjH1JDCrZZVTRblOiNC5l/OsFBu8N8+fqfOKi o4CxUIcp2TEPRJNbIXsOftpxLma+YCw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-qdzZQi1ZN3OARb4VIythFg-1; Thu, 24 Jun 2021 03:31:14 -0400 X-MC-Unique: qdzZQi1ZN3OARb4VIythFg-1 Received: by mail-wr1-f72.google.com with SMTP id d9-20020adffbc90000b029011a3b249b10so1851208wrs.3 for ; Thu, 24 Jun 2021 00:31:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1ummzXLEBVOW6zJVjd9RvyjdRwJ4z9g5ls7IEU8SqM4=; b=Cyjh9WeW9ctZeRfdjofdaoeSQsBLY+GYT61nIPuzBxFEysm05Lt85vdbN/lSjQciZZ J9V8DG1Ssby7CT1UK1fqniMsC4tLfJ6hu97y5xdcfOTE3AQvKsdsosihBI/gkCu9bTUP dxnHst28jyvnX63boHXamvgLzQRMCpMxDBrGUtAZxkgQRD/FP5Bo4jx6IHnOP8i4wM/I X868mKGKQeKxH1YgrcPEwtHDQSTqC7gm0f/V+HbfRT2tLtZ6bhHP0UF3V1kUphqF07qA 4ecoWaEaRD8xGUgez8SDgKQxL4jTBDMX5tTK/5mX7hahr8ZI3Y34d4np3a82c+EPUfsC x3/w== X-Gm-Message-State: AOAM530fvpbW+19Gjbgc4GKDppHSisRczJ9Xc8QeNzmgz2zhvSwfY/ai 8lTiur+KvwXzQhenjj1St+zzm7gRZf/grW8m2qury3f0sDzUx3dAgvrT9MVvCZg8IonDENktrIk rUtxxfQQkz+pkbwjOYXOOSgyYqtFqv3OTQdM= X-Received: by 2002:adf:f88e:: with SMTP id u14mr2674300wrp.391.1624519873867; Thu, 24 Jun 2021 00:31:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmU2A8muf7XixWmRWMn8O50eJCa1GKEjZYZIlN1VsKBfgiuuBfyX9v0BcxFt1KFEfxAoHypw== X-Received: by 2002:adf:f88e:: with SMTP id u14mr2674272wrp.391.1624519873717; Thu, 24 Jun 2021 00:31:13 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id f19sm2269746wre.48.2021.06.24.00.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 00:31:13 -0700 (PDT) Subject: Re: [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU To: David Stevens , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Zhenyu Wang , Zhi Wang Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Will Deacon , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-4-stevensd@google.com> From: Paolo Bonzini Message-ID: <49504c79-2cd4-1707-a0a5-79b679a4b214@redhat.com> Date: Thu, 24 Jun 2021 09:31:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210624035749.4054934-4-stevensd@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_003117_763788_B87EF084 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/21 05:57, David Stevens wrote: > static int __direct_map(struct kvm_vcpu *vcpu, gpa_t gpa, u32 error_code, > - int map_writable, int max_level, kvm_pfn_t pfn, > + int map_writable, int max_level, > + const struct kvm_pfn_page *pfnpg, > bool prefault, bool is_tdp) > { > bool nx_huge_page_workaround_enabled = is_nx_huge_pa So the main difference with my tentative patches is that here I was passing the struct by value. I'll try to clean this up for 5.15, but for now it's all good like this. Thanks again! Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel