Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number

Lee Jones
2023-12-21T15:26:31Z

On Wed, 20 Dec 2023, Andre Przywara wrote:

> On Wed, 20 Dec 2023 15:23:17 +0800
> fuyao <fuyao1697@cyg.com> wrote:
>
> Hi,
>
> > __platform_get_irq_byname determinies whether the interrupt
> > number is 0 and returns EINVAL.
>
> can you please say what this fixes, exactly? Is something not working at
> the moment? Can you please provide parts of the error message?
>
> And maybe expand the explanation a bit more? For instance mention that the
> identifiers are used as IRQ resource numbers, where 0 is treated specially.
>
> Cheers,
> Andre
>
> >
> > Signed-off-by: fuyao <fuyao1697@cyg.com>

You have to use your full real name as well.

> > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > ---
> > include/linux/mfd/sun4i-gpadc.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h
> > index ea0ccf33a459..021f820f9d52 100644
> > --- a/include/linux/mfd/sun4i-gpadc.h
> > +++ b/include/linux/mfd/sun4i-gpadc.h
> > @@ -81,8 +81,8 @@
> > #define SUN4I_GPADC_TEMP_DATA 0x20
> > #define SUN4I_GPADC_DATA 0x24
> >
> > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0
> > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1
> > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1
> > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2
> >
> > /* 10s delay before suspending the IP */
> > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000
>

--
Lee Jones [李琼斯]