Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number

Lee Jones
2024-01-09T08:56:36Z

On Fri, 22 Dec 2023, Jernej Škrabec wrote:

> Dne četrtek, 21. december 2023 ob 16:25:53 CET je Lee Jones napisal(a):
> > On Wed, 20 Dec 2023, Andre Przywara wrote:
> >
> > > On Wed, 20 Dec 2023 15:23:17 +0800
> > > fuyao <fuyao1697@cyg.com> wrote:
> > >
> > > Hi,
> > >
> > > > __platform_get_irq_byname determinies whether the interrupt
> > > > number is 0 and returns EINVAL.
> > >
> > > can you please say what this fixes, exactly? Is something not working at
> > > the moment? Can you please provide parts of the error message?
> > >
> > > And maybe expand the explanation a bit more? For instance mention that the
> > > identifiers are used as IRQ resource numbers, where 0 is treated specially.
> > >
> > > Cheers,
> > > Andre
> > >
> > > >
> > > > Signed-off-by: fuyao <fuyao1697@cyg.com>
> >
> > You have to use your full real name as well.
>
> Isn't that enough after
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 ?

I believe that change in stance is to be more accepting of people who
are universally known by their pseudonyms, like Tixy, Wookey or Piglet,
to name a few that I'm aware of. If fuyao is universally known by that
name then sure, it's enough. It just doesn't look very name-like in its
current guise, due to the shortness and lack of capitalisation. It
looks to me more like a username, which is not as generally acceptable
AFAIA.

--
Lee Jones [李琼斯]