From: Krzysztof Kozlowski <krzk@kernel.org>
To: Henrik Grimler <henrik@grimler.se>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank memory map
Date: Sat, 6 Sep 2025 14:24:21 +0200 [thread overview]
Message-ID: <4959ce59-84aa-40a5-aa07-f2dfa856d9b2@kernel.org> (raw)
In-Reply-To: <20250904-smdk5250-sromc-v1-1-b360c6ab01c6@grimler.se>
On 04/09/2025 08:10, Henrik Grimler wrote:
> According to public user manual for Exynos 5250 [1], the SROM
> controller has 4 banks, at same addresses as for example Exynos
> 5410. Describe the bank memory map of the SoC.
>
> [1] https://web.archive.org/web/20130921194458/http://www.samsung.com/global/business/semiconductor/file/product/Exynos_5_Dual_User_Manaul_Public_REV100-0.pdf
>
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> arch/arm/boot/dts/samsung/exynos5250.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/samsung/exynos5250.dtsi b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> index b9e7c493881804647534b1d7395f6eb62a07fb92..741cc693f5d8f6b33772d7819c965c590571f305 100644
> --- a/arch/arm/boot/dts/samsung/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> @@ -1214,6 +1214,15 @@ &serial_3 {
> dma-names = "rx", "tx";
> };
>
> +&sromc {
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges = <0 0 0x04000000 0x20000
These should be separate tupples, so
<0 0 0x04000000 0x20000>,
<....>,
<....>,
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-06 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:10 [PATCH 0/2] exynos5250-smdk5250: describe SROM controller and ethernet port Henrik Grimler
2025-09-04 6:10 ` [PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank memory map Henrik Grimler
2025-09-06 12:24 ` Krzysztof Kozlowski [this message]
2025-09-06 14:39 ` Henrik Grimler
2025-09-04 6:10 ` [PATCH 2/2] ARM: dts: samsung: smdk5250: add sromc node Henrik Grimler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4959ce59-84aa-40a5-aa07-f2dfa856d9b2@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox