[PATCH 0/5] TQMa8Xx update

[PATCH 0/5] TQMa8Xx update

[Alexander Stein]

Hi,

this small series updates the TQMa8Xx support:
* Add vcc-supply for spi-nor
* Enable JPEG decoder/encoder
* Remove obsolete TODO
* Add PCIe support on Mini-PCIe slot

The first patch is not necessary for PCIe support, but fixes the warning
> imx6q-pcie 5f010000.pcie: Invalid eDMA IRQs found

Best regards,
Alexander

Alexander Stein (5):
  arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe
  arm64: dts: tqma8xx: Add vcc-supply for spi-nor
  arm64: dts: tqma8xx: enable jpeg encode and decode
  arm64: dts: tqma8xx: Remove GPU TODO
  arm64: dts: mba8xx: Add PCIe support

 .../boot/dts/freescale/imx8-ss-hsio.dtsi      |  5 +--
 arch/arm64/boot/dts/freescale/mba8xx.dtsi     | 32 ++++++++++++++++---
 arch/arm64/boot/dts/freescale/tqma8xx.dtsi    | 12 +++++--
 3 files changed, 40 insertions(+), 9 deletions(-)

-- 
2.34.1

[PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

[Alexander Stein]

IRQ mapping is already present. Add the missing DMA interrupt.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
index 70a8aa1a67911..4bdfc15487cbc 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
@@ -57,8 +57,9 @@ pcieb: pcie@5f010000 {
 		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
 			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
 		#interrupt-cells = <1>;
-		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-names = "msi";
+		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "msi", "dma";
 		#address-cells = <3>;
 		#size-cells = <2>;
 		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
-- 
2.34.1

[PATCH 2/5] arm64: dts: tqma8xx: Add vcc-supply for spi-nor

[Alexander Stein]

(Q)SPI NOR flash is supplied by 1.8V. Add the corresponding supply.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/tqma8xx.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/tqma8xx.dtsi b/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
index 366912bf3d5e5..86b4e2b75adba 100644
--- a/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
@@ -65,6 +65,7 @@ flash0: flash@0 {
 		spi-max-frequency = <66000000>;
 		spi-tx-bus-width = <1>;
 		spi-rx-bus-width = <4>;
+		vcc-supply = <&reg_1v8>;
 
 		partitions {
 			compatible = "fixed-partitions";
-- 
2.34.1

[PATCH 3/5] arm64: dts: tqma8xx: enable jpeg encode and decode

[Alexander Stein]

Enable jpeg encode and decode.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/tqma8xx.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/tqma8xx.dtsi b/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
index 86b4e2b75adba..50aa41e3b6d51 100644
--- a/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
@@ -115,6 +115,15 @@ m24c64: eeprom@57 {
 	};
 };
 
+&jpegdec {
+	status = "okay";
+};
+
+&jpegenc {
+	status = "okay";
+};
+
+
 &mu_m0 {
 	status = "okay";
 };
-- 
2.34.1

[PATCH 4/5] arm64: dts: tqma8xx: Remove GPU TODO

[Alexander Stein]

Since commit 6196fe777513b ("arm64: dts: imx8qxp: add GPU nodes") GPUs
are supported.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/tqma8xx.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/tqma8xx.dtsi b/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
index 50aa41e3b6d51..58693b774d4c8 100644
--- a/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/tqma8xx.dtsi
@@ -75,8 +75,6 @@ partitions {
 	};
 };
 
-/* TODO GPU */
-
 &i2c1 {
 	#address-cells = <1>;
 	#size-cells = <0>;
-- 
2.34.1

[PATCH 5/5] arm64: dts: mba8xx: Add PCIe support

[Alexander Stein]

Add PCIe support for TQMa8Xx on MBa8Xx board.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/mba8xx.dtsi | 32 +++++++++++++++++++----
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
index 276d1683b03bb..117f657283191 100644
--- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
@@ -36,6 +36,13 @@ chosen {
 		stdout-path = &lpuart1;
 	};
 
+	/* Non-controllable PCIe reference clock generator */
+	pcie_refclk: clock-pcie-ref {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <100000000>;
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 		pinctrl-names = "default";
@@ -208,6 +215,12 @@ &flexcan2 {
 	status = "okay";
 };
 
+&hsio_phy {
+	fsl,hsio-cfg = "pciea-x2-pcieb";
+	fsl,refclk-pad-mode = "input";
+	status = "okay";
+};
+
 &i2c1 {
 	tlv320aic3x04: audio-codec@18 {
 		compatible = "ti,tlv320aic32x4";
@@ -309,7 +322,16 @@ &lsio_gpio3 {
 			  "", "", "", "";
 };
 
-/* TODO: Mini-PCIe */
+&pcieb {
+	phys = <&hsio_phy 0 PHY_TYPE_PCIE 0>;
+	phy-names = "pcie-phy";
+	pinctrl-0 = <&pinctrl_pcieb>;
+	pinctrl-names = "default";
+	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
+	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
+	vpcie-supply = <&reg_pcie_1v5>;
+	status = "okay";
+};
 
 &sai1 {
 	assigned-clocks = <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_PLL>,
@@ -467,10 +489,10 @@ pinctrl_pca9538: pca9538grp {
 		fsl,pins = <IMX8QXP_USDHC1_RESET_B_LSIO_GPIO4_IO19	0x00000020>;
 	};
 
-	pinctrl_pcieb: pcieagrp {
-		fsl,pins = <IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00	0x06000041>,
-			   <IMX8QXP_PCIE_CTRL0_CLKREQ_B_LSIO_GPIO4_IO01	0x06000041>,
-			   <IMX8QXP_PCIE_CTRL0_WAKE_B_LSIO_GPIO4_IO02	0x04000041>;
+	pinctrl_pcieb: pciebgrp {
+		fsl,pins = <IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00		0x06000041>,
+			   <IMX8QXP_PCIE_CTRL0_CLKREQ_B_HSIO_PCIE0_CLKREQ_B	0x06000041>,
+			   <IMX8QXP_PCIE_CTRL0_WAKE_B_LSIO_GPIO4_IO02		0x04000041>;
 	};
 
 	pinctrl_reg_pcie_1v5: regpcie1v5grp {
-- 
2.34.1

Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

[Frank Li]

On Tue, Jan 07, 2025 at 03:01:06PM +0100, Alexander Stein wrote:
> IRQ mapping is already present. Add the missing DMA interrupt.

PCI host side have not use bridge's DMA yet although hardware support it.

Frank

>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> index 70a8aa1a67911..4bdfc15487cbc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> @@ -57,8 +57,9 @@ pcieb: pcie@5f010000 {
>  		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
>  			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
>  		#interrupt-cells = <1>;
> -		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> -		interrupt-names = "msi";
> +		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "msi", "dma";
>  		#address-cells = <3>;
>  		#size-cells = <2>;
>  		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
> --
> 2.34.1
>

Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

[Alexander Stein]

Hi Frank,

Am Dienstag, 7. Januar 2025, 16:39:25 CET schrieb Frank Li:
> On Tue, Jan 07, 2025 at 03:01:06PM +0100, Alexander Stein wrote:
> > IRQ mapping is already present. Add the missing DMA interrupt.
> 
> PCI host side have not use bridge's DMA yet although hardware support it.

So this is a driver limitation, right? So IMHO the device description is
independent from that and still correct, right?

Best regards,
Alexander

> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > index 70a8aa1a67911..4bdfc15487cbc 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > @@ -57,8 +57,9 @@ pcieb: pcie@5f010000 {
> >  		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
> >  			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
> >  		#interrupt-cells = <1>;
> > -		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> > -		interrupt-names = "msi";
> > +		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> > +		interrupt-names = "msi", "dma";
> >  		#address-cells = <3>;
> >  		#size-cells = <2>;
> >  		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
> > --
> > 2.34.1
> >
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

[Frank Li]

On Wed, Jan 08, 2025 at 10:58:18AM +0100, Alexander Stein wrote:
> Hi Frank,
>
> Am Dienstag, 7. Januar 2025, 16:39:25 CET schrieb Frank Li:
> > On Tue, Jan 07, 2025 at 03:01:06PM +0100, Alexander Stein wrote:
> > > IRQ mapping is already present. Add the missing DMA interrupt.
> >
> > PCI host side have not use bridge's DMA yet although hardware support it.
>
> So this is a driver limitation, right? So IMHO the device description is
> independent from that and still correct, right?

Yes, but dma register space may missed also. I suggest add later after
EP side support merged, which can verify informaiton is correct.

Anyway, I don't block this change.

Frank

>
> Best regards,
> Alexander
>
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > > index 70a8aa1a67911..4bdfc15487cbc 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > > @@ -57,8 +57,9 @@ pcieb: pcie@5f010000 {
> > >  		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
> > >  			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
> > >  		#interrupt-cells = <1>;
> > > -		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> > > -		interrupt-names = "msi";
> > > +		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> > > +			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> > > +		interrupt-names = "msi", "dma";
> > >  		#address-cells = <3>;
> > >  		#size-cells = <2>;
> > >  		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
> > > --
> > > 2.34.1
> > >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>

Re: [PATCH 0/5] TQMa8Xx update

[Shawn Guo]

On Tue, Jan 07, 2025 at 03:01:05PM +0100, Alexander Stein wrote:
> Alexander Stein (5):
>   arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe
>   arm64: dts: tqma8xx: Add vcc-supply for spi-nor
>   arm64: dts: tqma8xx: enable jpeg encode and decode
>   arm64: dts: tqma8xx: Remove GPU TODO
>   arm64: dts: mba8xx: Add PCIe support

Applied all, thanks!

Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

[Frank Li]

On Wed, Jan 08, 2025 at 11:33:35AM -0500, Frank Li wrote:
> On Wed, Jan 08, 2025 at 10:58:18AM +0100, Alexander Stein wrote:
> > Hi Frank,
> >
> > Am Dienstag, 7. Januar 2025, 16:39:25 CET schrieb Frank Li:
> > > On Tue, Jan 07, 2025 at 03:01:06PM +0100, Alexander Stein wrote:
> > > > IRQ mapping is already present. Add the missing DMA interrupt.
> > >
> > > PCI host side have not use bridge's DMA yet although hardware support it.
> >
> > So this is a driver limitation, right? So IMHO the device description is
> > independent from that and still correct, right?
>
> Yes, but dma register space may missed also. I suggest add later after
> EP side support merged, which can verify informaiton is correct.
>
> Anyway, I don't block this change.


Did you run DTB_CHECK? I found new warning was added

/home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-aster.dtb: pcie@5f010000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
        from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
/home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-aster.dtb: pcie@5f010000: interrupt-names: ['msi', 'dma'] is too long
        from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
/home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-eval-v3.dtb: pcie@5f010000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
        from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
/home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-eval-v3.dtb: pcie@5f010000: interrupt-names: ['msi', 'dma'] is too long
        from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
/home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-iris.dtb: pcie@5f010000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
        from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
/home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-iris.dtb: pcie@5f010000: interrupt-names: ['msi', 'dma'] is too long

...

Frank

>
> Frank
>
> >
> > Best regards,
> > Alexander
> >
> > > >
> > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 5 +++--
> > > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > > > index 70a8aa1a67911..4bdfc15487cbc 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
> > > > @@ -57,8 +57,9 @@ pcieb: pcie@5f010000 {
> > > >  		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
> > > >  			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
> > > >  		#interrupt-cells = <1>;
> > > > -		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> > > > -		interrupt-names = "msi";
> > > > +		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> > > > +			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		interrupt-names = "msi", "dma";
> > > >  		#address-cells = <3>;
> > > >  		#size-cells = <2>;
> > > >  		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
> > > > --
> > > > 2.34.1
> > > >
> > >
> >
> >
> > --
> > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > Amtsgericht München, HRB 105018
> > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > http://www.tq-group.com/
> >
> >

Re: [PATCH 5/5] arm64: dts: mba8xx: Add PCIe support

[Frank Li]

On Tue, Jan 07, 2025 at 03:01:10PM +0100, Alexander Stein wrote:
> Add PCIe support for TQMa8Xx on MBa8Xx board.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/mba8xx.dtsi | 32 +++++++++++++++++++----
>  1 file changed, 27 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index 276d1683b03bb..117f657283191 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -36,6 +36,13 @@ chosen {
>  		stdout-path = &lpuart1;
>  	};
>
> +	/* Non-controllable PCIe reference clock generator */
> +	pcie_refclk: clock-pcie-ref {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <100000000>;
> +	};
> +
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  		pinctrl-names = "default";
> @@ -208,6 +215,12 @@ &flexcan2 {
>  	status = "okay";
>  };
>
> +&hsio_phy {
> +	fsl,hsio-cfg = "pciea-x2-pcieb";
> +	fsl,refclk-pad-mode = "input";
> +	status = "okay";
> +};
> +
>  &i2c1 {
>  	tlv320aic3x04: audio-codec@18 {
>  		compatible = "ti,tlv320aic32x4";
> @@ -309,7 +322,16 @@ &lsio_gpio3 {
>  			  "", "", "", "";
>  };
>
> -/* TODO: Mini-PCIe */
> +&pcieb {
> +	phys = <&hsio_phy 0 PHY_TYPE_PCIE 0>;
> +	phy-names = "pcie-phy";
> +	pinctrl-0 = <&pinctrl_pcieb>;
> +	pinctrl-names = "default";
> +	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> +	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;

"disable-gpio" is undocument property.

Frank Li

> +	vpcie-supply = <&reg_pcie_1v5>;
> +	status = "okay";
> +};
>
>  &sai1 {
>  	assigned-clocks = <&clk IMX_SC_R_AUDIO_PLL_0 IMX_SC_PM_CLK_PLL>,
> @@ -467,10 +489,10 @@ pinctrl_pca9538: pca9538grp {
>  		fsl,pins = <IMX8QXP_USDHC1_RESET_B_LSIO_GPIO4_IO19	0x00000020>;
>  	};
>
> -	pinctrl_pcieb: pcieagrp {
> -		fsl,pins = <IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00	0x06000041>,
> -			   <IMX8QXP_PCIE_CTRL0_CLKREQ_B_LSIO_GPIO4_IO01	0x06000041>,
> -			   <IMX8QXP_PCIE_CTRL0_WAKE_B_LSIO_GPIO4_IO02	0x04000041>;
> +	pinctrl_pcieb: pciebgrp {
> +		fsl,pins = <IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00		0x06000041>,
> +			   <IMX8QXP_PCIE_CTRL0_CLKREQ_B_HSIO_PCIE0_CLKREQ_B	0x06000041>,
> +			   <IMX8QXP_PCIE_CTRL0_WAKE_B_LSIO_GPIO4_IO02		0x04000041>;
>  	};
>
>  	pinctrl_reg_pcie_1v5: regpcie1v5grp {
> --
> 2.34.1
>

Re: [PATCH 5/5] arm64: dts: mba8xx: Add PCIe support

[Alexander Stein]

Hi Frank,

Am Montag, 24. Februar 2025, 20:04:40 CET schrieb Frank Li:
> On Tue, Jan 07, 2025 at 03:01:10PM +0100, Alexander Stein wrote:
> > Add PCIe support for TQMa8Xx on MBa8Xx board.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  arch/arm64/boot/dts/freescale/mba8xx.dtsi | 32 +++++++++++++++++++----
> >  1 file changed, 27 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> > index 276d1683b03bb..117f657283191 100644
> > --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> > @@ -36,6 +36,13 @@ chosen {
> >  		stdout-path = &lpuart1;
> >  	};
> >
> > +	/* Non-controllable PCIe reference clock generator */
> > +	pcie_refclk: clock-pcie-ref {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <100000000>;
> > +	};
> > +
> >  	gpio-keys {
> >  		compatible = "gpio-keys";
> >  		pinctrl-names = "default";
> > @@ -208,6 +215,12 @@ &flexcan2 {
> >  	status = "okay";
> >  };
> >
> > +&hsio_phy {
> > +	fsl,hsio-cfg = "pciea-x2-pcieb";
> > +	fsl,refclk-pad-mode = "input";
> > +	status = "okay";
> > +};
> > +
> >  &i2c1 {
> >  	tlv320aic3x04: audio-codec@18 {
> >  		compatible = "ti,tlv320aic32x4";
> > @@ -309,7 +322,16 @@ &lsio_gpio3 {
> >  			  "", "", "", "";
> >  };
> >
> > -/* TODO: Mini-PCIe */
> > +&pcieb {
> > +	phys = <&hsio_phy 0 PHY_TYPE_PCIE 0>;
> > +	phy-names = "pcie-phy";
> > +	pinctrl-0 = <&pinctrl_pcieb>;
> > +	pinctrl-names = "default";
> > +	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> > +	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
> 
> "disable-gpio" is undocument property.

Thanks for noticing, old downstream property slipped through. Will remove it.

Best regards
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

[Alexander Stein]

Hi Frank,

Am Montag, 24. Februar 2025, 18:49:01 CET schrieb Frank Li:
> On Wed, Jan 08, 2025 at 11:33:35AM -0500, Frank Li wrote:
> > On Wed, Jan 08, 2025 at 10:58:18AM +0100, Alexander Stein wrote:
> > > Hi Frank,
> > >
> > > Am Dienstag, 7. Januar 2025, 16:39:25 CET schrieb Frank Li:
> > > > On Tue, Jan 07, 2025 at 03:01:06PM +0100, Alexander Stein wrote:
> > > > > IRQ mapping is already present. Add the missing DMA interrupt.
> > > >
> > > > PCI host side have not use bridge's DMA yet although hardware support it.
> > >
> > > So this is a driver limitation, right? So IMHO the device description is
> > > independent from that and still correct, right?
> >
> > Yes, but dma register space may missed also. I suggest add later after
> > EP side support merged, which can verify informaiton is correct.
> >
> > Anyway, I don't block this change.
> 
> 
> Did you run DTB_CHECK? I found new warning was added
> 
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-aster.dtb: pcie@5f010000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-aster.dtb: pcie@5f010000: interrupt-names: ['msi', 'dma'] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-eval-v3.dtb: pcie@5f010000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-eval-v3.dtb: pcie@5f010000: interrupt-names: ['msi', 'dma'] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-iris.dtb: pcie@5f010000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-iris.dtb: pcie@5f010000: interrupt-names: ['msi', 'dma'] is too long

I think I did, but I see the same warnings.
I've prepared a series which addresses schema and imx8qm dtsi.

Best regards
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/