From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09E12C4332F for ; Tue, 8 Nov 2022 18:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RctxtheFCSy3g12kx0pthQWkuS0g4haOJbxw1gTEY4w=; b=E4jjbQ4MmB7/Pj hWWnuygIllKheHvJPEiA4+QScrNO7jaSIaMjrxKF7d/w0jEDis0yu+cZjHGjWpTDejchgXLsdQkcd barxfhcMJjk1lOWFyi3kIkEQfLERH8xcGVevEdBiyTMGLAdIZ9TCOmBq+StQY+1578fFjlUogCBP0 +w/b4X4QNZbqROnXz3aNlVeaE6dxVcBee6yrJBqBpR/L2w14g8Oxg128GbzKkpXXSOz92koNxF8aG mDviU/af/86/yV0UQp2OEO2AP285Vpto+2P6bH/8WMnJWpoGQ8AMIqselkbbqc+73NynxJ/zjtehS ZkITaEFQ/3dP5yWvFWog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osTIT-007SyI-06; Tue, 08 Nov 2022 18:26:05 +0000 Received: from mickerik.phytec.de ([91.26.50.163]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osTIE-007SqE-2X for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2022 18:25:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=phytec.de; s=a4; c=relaxed/simple; q=dns/txt; i=@phytec.de; t=1667931947; x=1670523947; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TBq5LL6mwgk8nSL0XzqtoYsstTPMBbtwYQWsea5cKdc=; b=A3oOpx9A2d2ha+V9WgJ/LTn0Zn9dVVG9LuUxdQKDGayzwiVRIPvFIe/Dgvtghiaw lvCZHVXRzYl29SUgeKLGEagMG8wxQ0DgaGoIwchtPAqkGrKyLLlnKyLW/2+x5uvr vLgzFTIHXOQXnQGoHWPWVTYiWGmdEj+5P7t+FgluZng=; X-AuditID: ac14000a-833f270000003940-da-636a9f2b44f6 Received: from berlix.phytec.de (Unknown_Domain [172.25.0.12]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mickerik.phytec.de (PHYTEC Mail Gateway) with SMTP id 5E.26.14656.B2F9A636; Tue, 8 Nov 2022 19:25:47 +0100 (CET) Received: from Berlix.phytec.de (172.25.0.12) by Berlix.phytec.de (172.25.0.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Tue, 8 Nov 2022 19:25:47 +0100 Received: from Berlix.phytec.de ([fe80::61cc:ebf0:7375:8768]) by berlix.phytec.de ([fe80::197e:d26b:2ca:c7b4%4]) with mapi id 15.01.2375.018; Tue, 8 Nov 2022 19:25:47 +0100 From: Wadim Egorov To: Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "upstream@phytec.de" , "nm@ti.com" , "vigneshr@ti.com" , "kristo@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Subject: Re: [PATCH v2 2/2] arm64: dts: ti: Add support for phyBOARD-Electra-AM642 Thread-Topic: [PATCH v2 2/2] arm64: dts: ti: Add support for phyBOARD-Electra-AM642 Thread-Index: AQHY85sVvT0/Blv6VUa3KTQm0eF4Aa41QFsAgAAGtYA= Date: Tue, 8 Nov 2022 18:25:47 +0000 Message-ID: <4963de6e-275b-e1d2-859c-7c7364b4599b@phytec.de> References: <20221108175050.285340-1-w.egorov@phytec.de> <20221108175050.285340-2-w.egorov@phytec.de> <414f8281-80ba-dd2c-e5f9-9e9cde1ad1e0@linaro.org> In-Reply-To: <414f8281-80ba-dd2c-e5f9-9e9cde1ad1e0@linaro.org> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.0.11] Content-ID: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsWyRpKBR1d7flaywfIufYv5R86xWiz/PJvd ou/FQ2aLva+3sltsenyN1eLyrjlsFm9+nGWyaN17hN3i/9kP7A6cHptWdbJ53Lm2h81j85J6 j+M3tjN5fN4kF8AaxWWTkpqTWZZapG+XwJXxecdq5oIJdhVzlkxgbmA8YtPFyMkhIWAi8WrJ I5YuRi4OIYHFTBLLVz1lBkkICdxnlOj/rA2R2MAo8WdWKxNIgk1AXWLi3xOsIAkRgU4mia99 u5lAHGaBPiaJQy9msIFUCQuESHw7vhisQ0QgVOJ5+xlGCNtKYuOPZWBxFgEViZcNE1lBbF4B G4npH/6xQKyezSixc18diM0pYCfRtXQHWC+jgKzEhg3nwc5jFhCX2PTsOyvEDwISS/ZAxCUE RCVePv4HFZeXOHFrGtAuDqB6TYn1u/QhWi0kNk68BjVGUWJK90N2iBMEJU7OfMIygVF8FpIN sxC6ZyHpnoWkexaS7gWMrKsYhXIzk7NTizKz9QoyKktSk/VSUjcxgmJZhIFrB2PfHI9DjEwc jIcYJTiYlUR4RWoyk4V4UxIrq1KL8uOLSnNSiw8xSnOwKInz3u9hShQSSE8sSc1OTS1ILYLJ MnFwSjUw7tlgqxolkx1VNW3hE/0VCx2/S7yaMG2bNt/c5Q9VBH5WGZ/ufKhbHfdhuuQZ1tsi GXZGYpzf+t5oePWnz2xKSd90ocovOc4jhrNn+96Uv5mytXtEM60W7HN9tdLl39UHt78t+bNq Rk/NlD1f4lscZ9xO4xaYs/bN3x1LmV/HuQutfJtefTxnlhJLcUaioRZzUXEiAHa0pEHTAgAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_102550_304901_21A368FA X-CRM114-Status: GOOD ( 27.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 08.11.22 um 19:01 schrieb Krzysztof Kozlowski: > On 08/11/2022 18:50, Wadim Egorov wrote: >> Add basic support for phyCORE-AM64x SoM & phyBOARD-Electra-AM642 CB. >> >> The phyCORE-AM64x [1] is a SoM (System on Module) featuring TI's AM64x SoC. >> It can be used in combination with different carrier boards. >> This module can come with different sizes and models for >> DDR, eMMC, SPI NOR Flash and various SoCs from the AM64x family. >> >> A development Kit, called phyBOARD-Electra [2] is used as a carrier board >> reference design around the AM64x SoM. >> >> Supported features: >> * Debug UART >> * Heartbeat LED >> * GPIO buttons & LEDs >> * SPI NOR flash >> * SPI TPM Chip >> * eMMC >> * CAN >> * Ethernet >> * Micro SD card >> * I2C EEPROM >> * I2C RTC >> * I2C LED Dimmer >> * USB >> >> For more details, see: >> >> [1] Product page SoM: https://www.phytec.com/product/phycore-am64x >> [2] Product page CB: https://www.phytec.com/product/phyboard-am64x >> >> Signed-off-by: Wadim Egorov >> --- >> v2: >> - Update commit message >> - Add links to product pages for SoM & CB >> - Drop "fixed" from regulator node names >> - Use generic node names for pmic, tpm, leds & keys >> - Update compatible of som.dtsi >> - Remove not needed node labels for pmic, tpm >> - Remove not needed R5 core mailbox & reserved memory definitions >> This is use case specific and should not be defined in the som.dtsi >> - Provide aliases for used devices by SoM & CB >> - Fixed led definition: Provide proper default-trigger, function & color >> - Renamed rtc label to i2c_som_rtc >> --- >> arch/arm64/boot/dts/ti/Makefile | 1 + >> .../boot/dts/ti/k3-am64-phycore-som.dtsi | 286 ++++++++++++++++ >> .../dts/ti/k3-am642-phyboard-electra-rdk.dts | 321 ++++++++++++++++++ >> 3 files changed, 608 insertions(+) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi >> create mode 100644 arch/arm64/boot/dts/ti/k3-am642-phyboard-electra-rdk.dts >> >> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile >> index 4555a5be2257..79331f16cd4b 100644 >> --- a/arch/arm64/boot/dts/ti/Makefile >> +++ b/arch/arm64/boot/dts/ti/Makefile >> @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb >> dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb >> >> dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb >> +dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb >> dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb >> >> dtb-$(CONFIG_ARCH_K3) += k3-am625-sk.dtb >> diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi >> new file mode 100644 >> index 000000000000..86e6b87b826a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi >> @@ -0,0 +1,286 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2021 PHYTEC America, LLC - https://www.phytec.com >> + * Author: Matt McKee >> + * >> + * Copyright (C) 2022 PHYTEC Messtechnik GmbH >> + * Author: Wadim Egorov >> + * >> + * Product homepage: >> + * https://www.phytec.com/product/phycore-am64x >> + */ >> + >> +#include >> +#include >> +#include >> + >> +/ { >> + model = "PHYTEC phyCORE-AM64x"; >> + compatible = "phytec,am64-phycore-som", "ti,am642"; >> + >> + aliases { >> + ethernet0 = &cpsw_port1; >> + mmc0 = &sdhci0; >> + rtc0 = &i2c_som_rtc; >> + }; >> + >> + memory@80000000 { >> + device_type = "memory"; >> + reg = <0x00000000 0x80000000 0x00000000 0x80000000>; >> + }; >> + >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + secure_ddr: optee@9e800000 { >> + reg = <0x00 0x9e800000 0x00 0x01800000>; /* for OP-TEE */ >> + alignment = <0x1000>; >> + no-map; >> + }; >> + }; >> + >> + leds { >> + compatible = "gpio-leds"; >> + >> + led-0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&leds_pins_default>; >> + color = ; >> + gpios = <&main_gpio0 12 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "heartbeat"; >> + function = LED_FUNCTION_HEARTBEAT; >> + }; >> + }; >> + >> + vcc_5v0_som: vcc-5v0-som { > I asked to drop "fixed", not other generic parts. > > Node names should be generic. > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Hey Krzysztof, oh, I see I removed to much here. Will fix it. ... >> + leds { >> + compatible = "gpio-leds"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&user_leds_pins_default>; >> + >> + led-1 { >> + color = ; >> + gpios = <&main_gpio0 15 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "mmc0"; >> + function = LED_FUNCTION_DISK; >> + }; >> + >> + led-2 { >> + color = ; >> + gpios = <&main_gpio0 16 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "mmc1"; >> + function = LED_FUNCTION_DISK; >> + }; >> + }; >> + >> + vcc_3v3_mmc: regulator-sd { > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. But what is wrong with the "regulator-sd" node name? Regards, Wadim > > Thank you. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel