From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status
Date: Fri, 17 Jun 2016 17:27:31 +0200 [thread overview]
Message-ID: <4994764.3nf9fUrla1@wuerfel> (raw)
In-Reply-To: <1466175913-19067-2-git-send-email-ben.dooks@codethink.co.uk>
On Friday, June 17, 2016 4:05:05 PM CEST Ben Dooks wrote:
> The function pcibios_report_status() needs a declaration to avoid
> the following warning, so declare it in <asm/pci.h>.
>
> /home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> ---
> arch/arm/include/asm/pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h
> index 057d381..4b5ea93 100644
> --- a/arch/arm/include/asm/pci.h
> +++ b/arch/arm/include/asm/pci.h
> @@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
> return channel ? 15 : 14;
> }
>
> +extern void pcibios_report_status(unsigned int status_mask, int warn);
> +
> #endif /* __KERNEL__ */
> #endif
>
Should we remove the declaration in arch/arm/mach-footbridge/dc21285.c
at the same time?
Another option would be to move the function to that file and make
it static, since nothing else uses it.
Arnd
next prev parent reply other threads:[~2016-06-17 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1466175913-19067-1-git-send-email-ben.dooks@codethink.co.uk>
2016-06-17 15:05 ` [PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status Ben Dooks
2016-06-17 15:27 ` Arnd Bergmann [this message]
2016-06-17 15:05 ` [PATCH 2/9] ARM: fix missing include of <asm/insn.h> in arch/arm/kernel/insn.c Ben Dooks
2016-06-17 15:05 ` [PATCH 3/9] ARM: add missing <asm/prom.h> Ben Dooks
2016-06-17 15:08 ` Arnd Bergmann
2016-06-17 15:05 ` [PATCH 4/9] ARM: fix missing <asm/vga.h> in arch/arm/mm/iomap.c Ben Dooks
2016-06-17 15:05 ` [PATCH 5/9] ARM: fix missing <linux/elf-randomize.h> in arch/arm/mm/mmap.c Ben Dooks
2016-06-17 15:05 ` [PATCH 6/9] ARM: fix missing <asm/cacheflush.h> in arch/arm/mm/pageattr.c Ben Dooks
2016-06-17 15:05 ` [PATCH 7/9] ARM: probes: fix warning on NULL/0 substitution Ben Dooks
2016-06-17 15:05 ` [PATCH 9/9] [RFC] pci: include <asm/dma.h> for isa_dma_bridge_buggy Ben Dooks
2016-07-19 22:05 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4994764.3nf9fUrla1@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).