From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 17 Jun 2016 17:27:31 +0200 Subject: [PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status In-Reply-To: <1466175913-19067-2-git-send-email-ben.dooks@codethink.co.uk> References: <1466175913-19067-1-git-send-email-ben.dooks@codethink.co.uk> <1466175913-19067-2-git-send-email-ben.dooks@codethink.co.uk> Message-ID: <4994764.3nf9fUrla1@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday, June 17, 2016 4:05:05 PM CEST Ben Dooks wrote: > The function pcibios_report_status() needs a declaration to avoid > the following warning, so declare it in . > > /home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- > Cc: linux-arm-kernel at lists.infradead.org > Cc: Russell King > Cc: Bjorn Helgaas > --- > arch/arm/include/asm/pci.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h > index 057d381..4b5ea93 100644 > --- a/arch/arm/include/asm/pci.h > +++ b/arch/arm/include/asm/pci.h > @@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) > return channel ? 15 : 14; > } > > +extern void pcibios_report_status(unsigned int status_mask, int warn); > + > #endif /* __KERNEL__ */ > #endif > Should we remove the declaration in arch/arm/mach-footbridge/dc21285.c at the same time? Another option would be to move the function to that file and make it static, since nothing else uses it. Arnd