From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5925EC61DA4 for ; Sat, 11 Mar 2023 17:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B+g1ETKufRnk/1UHm7k5D86wTIgnUyCt2yFcVfZXAP4=; b=yMB0N/3QczSgg3 dticMOr2u7ClklGKwLZg4Uf1QAoL380pKWN7G/oF+uzRPdmtjBeBSd60bRbGX6k7BF3fpXzXUYiS7 jOhY2eF52boSvupHhOeoxJS4pMzGCJvYVfZHKfVoSPiW9kpOdSszU+ehN9njNeoRi06Hvm0zTZgBV zgdj8Yt0BoUBHhOVvZxWKEvMzluP2/f0l7vpDcH+Z3VNdGhkzA0Hh6K4qQ3wdSKdoizExHeql64HK uLVopzVANirN6B/5F0Q6rld7UStXJ4BFQlaqPf0IdUpt9bjvCkjDZt8yTlwthN19eSWbhmBDzil/4 kuztJ4uypEBmHQ/BFWhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb35Z-000y0n-Qc; Sat, 11 Mar 2023 17:33:01 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb35X-000y0E-4O; Sat, 11 Mar 2023 17:33:00 +0000 Received: by mail-wr1-x42f.google.com with SMTP id t15so7796404wrz.7; Sat, 11 Mar 2023 09:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678555976; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BS/U63CP8kyc4s3+ndFwYv3c/IbBKEKDtQ8znLZINo4=; b=RX+BkKj+x9TiMv3r/lL//tQpdeczI/eIoOk8GNW2B997wf/HecmbDllwY2uelEG6SW NFzKMG9Y8UUTaOLQdyxRPlkDNP1u2gbO2I6JCDlC9f8n0tVMzUtVmkPrYMQ/5gTTvIex B7MpIpXwFxRMt4Za9+FOvX04zp7uhkrZF+ENEt6FiCUbmO97P3IiIUFHVUKwj/V2aZEO ubZie3KLAa3d3xuXS3uikY5XNveSErnSmyofgMAptn+7YChpYU7HHwVPbpFGXsb5GHU8 pN427twy0g9FmB350c4j7aDVbOSqRrNc7uvq+AaCQtSGNScLHq5tbsThpFh3D5t1SlDX SKgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678555976; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BS/U63CP8kyc4s3+ndFwYv3c/IbBKEKDtQ8znLZINo4=; b=uxpegqa5dKZF2/TEyVDYpUzYQ/CtbTW5RwG2cttA1Se97LhFmEeG9kLfiBZoNOUalC 8iSbm3ZHgeLQ3FhU69qLZulnhYM22dS1I58iI4HmvYofkoJue8pPQR7rLBCwh1RW35lE VQt2pVS0VD7K7qy1wcT7eV2NtsRyzCF48tJ68oVhePMkRZSsvQ3NIcxQndaZxy/F046D z7tCCRY7HfbohZyrb+YyDW6pSw7HD7lXFWZgNvVudxSeAV+oi+vjrqMIFuYVmXDyvtIL P2dxj9IeAXJ692DtIycf7ZFVuyx0VkOJ51fJv1IihuxbARw03gMeJRI4Saw0t/dNvflm WcjA== X-Gm-Message-State: AO0yUKW/gy+Dv6RMvFUuN3yfrYtZc1DTTB85CfZv/X0IsNYqMkLYwE6O fg69xNEZC4EBY3iXa9rZouM= X-Google-Smtp-Source: AK7set9ukWzDo0xy6J7gbHp7jIKCnz8dTe9J/CWuuqUqxE+n+q/r8zAWdbMSQuUV7O2FnpyIFohiiA== X-Received: by 2002:a5d:5145:0:b0:2c7:a0e:347b with SMTP id u5-20020a5d5145000000b002c70a0e347bmr19984098wrt.8.1678555976064; Sat, 11 Mar 2023 09:32:56 -0800 (PST) Received: from ?IPv6:2a02:168:6806:0:cb1:a328:ee29:2bd6? ([2a02:168:6806:0:cb1:a328:ee29:2bd6]) by smtp.gmail.com with ESMTPSA id a10-20020adfe5ca000000b002cde25fba30sm3059307wrn.1.2023.03.11.09.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 09:32:55 -0800 (PST) Message-ID: <49a9154ae4e2b3e6bc85e560368f6474f97cea88.camel@gmail.com> Subject: Re: [PATCH net-next v2 4/6] net: mdio: scan bus based on bus capabilities for C22 and C45 From: Klaus Kudielka To: Andrew Lunn Cc: Michael Walle , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , Bryan Whitehead , UNGLinuxDriver@microchip.com, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Joel Stanley , Andrew Jeffery , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-aspeed@lists.ozlabs.org, Jesse Brandeburg Date: Sat, 11 Mar 2023 18:32:54 +0100 In-Reply-To: <2f64385a350359c5755eb4d2479e2efef7a96216.camel@gmail.com> References: <100c439a-2a4d-4cb2-96f2-5bf273e2121a@lunn.ch> <712bc92ca6d576f33f63f1e9c2edf0030b10d3ae.camel@gmail.com> <0e10aa8492eadb587949d8744b56fccaabbd183b.camel@gmail.com> <72530e86-9ba9-4a01-9cd2-68835ecae7a0@lunn.ch> <09d65e1ee0679e1e74b4f3a5a4c55bd48332f043.camel@gmail.com> <70f5bca0-322c-4bae-b880-742e56365abe@lunn.ch> <10da10caea22a8f5da8f1779df3e13b948e8a363.camel@gmail.com> <4abd56aa-5b9f-4e16-b0ca-11989bb8c764@lunn.ch> <2f64385a350359c5755eb4d2479e2efef7a96216.camel@gmail.com> User-Agent: Evolution 3.46.4-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230311_093259_206825_9DCD52AB X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2023-03-11 at 17:11 +0100, Klaus Kudielka wrote: > On Sat, 2023-03-11 at 16:39 +0100, Andrew Lunn wrote: > > > If there is no DT node, by default, all 32 addresses on the bus are > > scanned. However, DSA makes another assumption. There is a one to one > > mapping between port number and PHY address on the MDIO bus. Port 0 > > uses MDIO address 0. Port 7 uses MDIO address 7 etc. If you have an 8 > > port switch, there is no point scanning addresses 8 to 31, they will > > never be used. > > > > The mdio bus structure has a member phy_mask. This is a bitmap. If bit > > N is set, address N is not scanned. So i suggest you extend > > mv88e6xxx_mdio_register() to set phy_mask based on > > mv88e6xxx_num_ports(chip). > > > > What you are proposing here would not show any improvement on the > Omnia, as only the 6 ports would be scanned - right? > Well, maybe I misunderstood the argument with DT completely, so I gave it a try: --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3797,6 +3797,7 @@ static int mv88e6xxx_mdio_register(struct mv88e6xxx_chip *chip, bus->read_c45 = mv88e6xxx_mdio_read_c45; bus->write_c45 = mv88e6xxx_mdio_write_c45; bus->parent = chip->dev; + bus->phy_mask = GENMASK(31, mv88e6xxx_num_ports(chip)); if (!external) { err = mv88e6xxx_g2_irq_mdio_setup(chip, bus); > Now THAT one makes a difference! With this on top, I'm back at normal boot time! I hope this is what you had in mind? Best regards, Klaus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel