From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26677C433E3 for ; Mon, 13 Jul 2020 14:04:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE09A206F4 for ; Mon, 13 Jul 2020 14:04:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q/wTKrxr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE09A206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5n+cNarwWZ9ND3PihL+BZ/X3kKfT7ntydq36jRAbKz4=; b=q/wTKrxrwtoR1BoAoA1djEuDs 9bW4qcFi8jUjmPMTnWERLM6XzmvKZ+fWPGjxGNM5ZmNKf8Y8tvmXd0YE6Nfb5z3tGdkHD2KFzBvBc S9N5bvaqGBYlyoGDAm7wmey/orclVmTcp0yME6d+0C4Dk80tRjsX4NUEaNJFgDra1oG85VPt6k+9s OWHh8pvvkVPm4mTRo4BkgzaMRlWcp3mf6RQ3L6DKORfY8Lgdi+vZp60tlPiphvGSX2RFn67KyHYjr 5K32dEsOhnRctKG8wWOyRZvAxUbnLrm6HUDJZ8kSfEz8PT1G55fWE/AhEdF8INu8oNweKtwcGVHCT 6fiIlurfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juz2V-0006MY-8R; Mon, 13 Jul 2020 14:02:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juz2S-0006LK-Li for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 14:02:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE97530E; Mon, 13 Jul 2020 07:02:31 -0700 (PDT) Received: from [10.57.62.178] (unknown [10.57.62.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 08FA73F7BB; Mon, 13 Jul 2020 07:02:28 -0700 (PDT) Subject: Re: [PATCH v10 2/5] iommu/arm-smmu: ioremap smmu mmio region before implementation init To: Krishna Reddy , joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, treding@nvidia.com, jonathanh@nvidia.com References: <20200708050017.31563-1-vdumpa@nvidia.com> <20200708050017.31563-3-vdumpa@nvidia.com> From: Robin Murphy Message-ID: <49c222ce-e889-937a-6f05-eb1b46739306@arm.com> Date: Mon, 13 Jul 2020 15:02:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200708050017.31563-3-vdumpa@nvidia.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_100236_764362_75ED3DB9 X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: snikam@nvidia.com, devicetree@vger.kernel.org, nicoleotsuka@gmail.com, mperttunen@nvidia.com, bhuntsman@nvidia.com, yhsu@nvidia.com, linux-kernel@vger.kernel.org, talho@nvidia.com, iommu@lists.linux-foundation.org, nicolinc@nvidia.com, linux-tegra@vger.kernel.org, praithatha@nvidia.com, linux-arm-kernel@lists.infradead.org, bbiswas@nvidia.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-07-08 06:00, Krishna Reddy wrote: > ioremap smmu mmio region before calling into implementation init. > This is necessary to allow mapped address available during vendor > specific implementation init. Reviewed-by: Robin Murphy > Signed-off-by: Krishna Reddy > --- > drivers/iommu/arm-smmu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index d2054178df35..e03e873d3bca 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2120,10 +2120,6 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > if (err) > return err; > > - smmu = arm_smmu_impl_init(smmu); > - if (IS_ERR(smmu)) > - return PTR_ERR(smmu); > - > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > ioaddr = res->start; > smmu->base = devm_ioremap_resource(dev, res); > @@ -2135,6 +2131,10 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > */ > smmu->numpage = resource_size(res); > > + smmu = arm_smmu_impl_init(smmu); > + if (IS_ERR(smmu)) > + return PTR_ERR(smmu); > + > num_irqs = 0; > while ((res = platform_get_resource(pdev, IORESOURCE_IRQ, num_irqs))) { > num_irqs++; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel