From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1000C47DDB for ; Mon, 29 Jan 2024 16:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CRqKlrmCph2/cxlbefiAsBiwL8LZmiEEH7odTiYCbCI=; b=3wdBKaYpLaZs6d lhQJci2oM9PeRK0RF9ASt4aEZ+PoHmCnZlaIl7S3NxxSZGpUsgHgHJC+5JGBB6wBpOemqJgCjC4Sr S/WkDYiLplcYJ1BWr61gtvuUvwefHEtVsk5jsREdlHqTHmLtgtd8lYUAzbcXdsfCCZTVtkqsPXgyw +Nw8T2rbHLCO5de/T2IcJm8vORQ/YFxbPc3ZbjeHtMpaaab+6bT7rWgmAWdzqZrqO3bcqmNBMmlmz AW+ZEhW4ppo7TsjflfwrPWyvfjRwAXnZ7Nz/Zm3YNb9omdZZueP18ckQtzGlPDeueGhGD0sXWfUfl jkZ8/5KrNYx21M6wo2ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUUZa-0000000DWMw-3nUA; Mon, 29 Jan 2024 16:33:26 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUUZY-0000000DWLP-1z0o for linux-arm-kernel@lists.infradead.org; Mon, 29 Jan 2024 16:33:25 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2cf328885b4so33555381fa.3 for ; Mon, 29 Jan 2024 08:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706546000; x=1707150800; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yYsUavmWV+6BfBH3yu3ngTFUF3L9esmHz5FzVfYvcmg=; b=dNwrAKTyk605nUYsz5JpNjWMwyNNMSMPtYwxJy2bV+x0aJKFyzQD0dbbJy7D6tr6nb FOg7r3e1kOzpuhvFU0kamNR5+3Ca9uAbVts1tnRznFHU/Iyf8AQpGVdYhMlw9iTp1Nj5 UyoAiwjlAcVhBWPcfKVRPoLT2aZIagdSyyikM3p3lXnN6jt8vdbbAP5K2gtc9E6cjJZC u5expv839Hl7hqMOo3tWSwYf5kNNtMy0lpeQUcRQy9jzbZ1qebUXBwB02C9pYrbdbxz6 i5umlM3k/hPIThZrXDC23lvj5m00iz3et4xGSBGd/OQIF5OS1AEzmCVaJi5x5u9masLU dJ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706546000; x=1707150800; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yYsUavmWV+6BfBH3yu3ngTFUF3L9esmHz5FzVfYvcmg=; b=s/uTblb3MSQLw8G2KauOiEn3S28pPyB6KzO9QXTMFb22BnWvenJYvSgRle7iuG7CZs RitOQYAuire/BPgd//EIhWm2Iz5uPzDWZ+FnayPobEN5MtwaVqaeXvqvaQxgv0NVSX6Q 0NgRuhwoZyyMnqhvAHqLs9vAR+cphyApxMjAK3IxpfZYFmDol+jcivS9exP8fGgDzQfA QCh7rL6U+O6MAho5iOyTi8V3XNQYTmCx0ahSp4XIwGGVzcYPqSc84VPfi0A/b8GGY6s6 Wg7kYvn+oKwGYvIojSyCQiEtE5KVdkcrDvHdjt6OXtD1hgnM1WsyvR7EiYf+C7BVWVO0 Rw3w== X-Gm-Message-State: AOJu0Yy3WsrpnHvcSlVC9vMawKYrkv/7YFnPeR0Xz/6edKkn1Z/FXtb/ EKuHVybkl8ov4hWf49xMtihh03I81OUPOR/3ab0PW4K3mguE6CdfGQgosALD0T4= X-Google-Smtp-Source: AGHT+IH+05/t+GD++Fm4xFiAjxPfYadf/7tiraj4U+n+W6gTozYIsXgXGJnWAj6dePSqJIAtmsSeVQ== X-Received: by 2002:a2e:740d:0:b0:2d0:417a:80f2 with SMTP id p13-20020a2e740d000000b002d0417a80f2mr2809772ljc.2.1706546000074; Mon, 29 Jan 2024 08:33:20 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id em2-20020a056402364200b0055ec051ab49sm2642169edb.6.2024.01.29.08.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 08:33:19 -0800 (PST) Message-ID: <49d187f5-3c37-4c3b-a2f5-52dd805e84ee@linaro.org> Date: Mon, 29 Jan 2024 16:33:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 Content-Language: en-US From: Tudor Ambarus To: Sam Protsenko , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski Cc: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, willmcvicker@google.com, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20240127003607.501086-1-andre.draszik@linaro.org> <20240127003607.501086-4-andre.draszik@linaro.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_083324_565135_2E9B4F6B X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/27/24 04:00, Tudor Ambarus wrote: >>> Wrong pclk clocks have been used in this usi8 instance here. For USI >>> and I2C, we need the ipclk and pclk, where pclk is the bus clock. >>> Without it, nothing can work. >> Empty line is missing here? >> >>> It is unclear what exactly is using USI8_USI_CLK, but it is not >>> required for the IP to be operational at this stage, while pclk is. >> From [1] it looks like DIV_CLK_PERIC0_USI8_USI is a common parrent for >> these two leaf gate clocks: >> 1. GOUT_BLK_PERIC0_UID_RSTNSYNC_CLK_PERIC0_USI8_USI_IPCLKPORT_CLK >> 2. GOUT_BLK_PERIC0_UID_PERIC0_TOP0_IPCLKPORT_IPCLK_7 >> >> So IIUC, you replace clock #1 with clock #2 in this patch? If so, I > No, GOUT_BLK_PERIC0_UID_PERIC0_TOP0_IPCLKPORT_IPCLK_7 is already used by > IPCLK, the one that controls the clock frequency. > > So I understand Andre' replaces a child of the USI8 with something else. > > I don't think this works. We shall at least test it. I tested my usi8 > patches with the eeprom that's populated on the battery connector. I'll > sync with Andre' offline and redo the tests on Monday. Andre' is right, I messed up the bus clocks for USI. I tested the IPCLK, the one that feeds USI clients, but I failed to correctly test the bus clock. I retested by removing the clk_ignore_unused bootargs param and verified that the patch is correct. Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel