From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED2D6EB64D9 for ; Thu, 6 Jul 2023 11:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1nZQqsrSlU49OTU/ewLo0fDQJ2R4ZkdutX4XU3Ko+Eo=; b=Mmwv7zcjc6Kvvrfn+FRtT5wKZd n1yHs3idlQuLZMEyTmKBzovbENonelax9s4H8SFK/Jz1++tsySDocZkbp1Jz1SPO5g6cJ/FtoQzky v+MHVXmr41rBcDEQ8t3jDf32dPblCFz3pLH0AkUpnYa9oBwi5XN1K7lWGH7WyfkqszyLXd7WF/5ux vORN+dr8OEQennX3WUpCaRzah75PtnmjWM79VtVeiS9rAluvA8JvtHsQBWRz3uZCpC9JDAktPBbV+ 2HtVcypIfVbPrN1d3/x/wiCm073aSXKYTY3B0VR3JcbuO7ScRcycjzI3WWGDN87cMSYnlMTvimQHb SL8t5ryw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHMon-001RLQ-15; Thu, 06 Jul 2023 11:06:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHMoj-001RKL-23 for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2023 11:06:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38B3B1480; Thu, 6 Jul 2023 04:07:12 -0700 (PDT) Received: from [10.57.27.160] (unknown [10.57.27.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C21363F663; Thu, 6 Jul 2023 04:06:26 -0700 (PDT) Message-ID: <49ef52b7-0269-898c-7cc2-096f2f1037fc@arm.com> Date: Thu, 6 Jul 2023 12:06:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: remove arm, primecell-periphid at etm nodes Content-Language: en-GB To: Lucas Stach , Alexander Stein , suzuki.poulose@arm.com, coresight@lists.linaro.org, imx@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marek Vasut , Peng Fan , Adam Ford , Laurent Pinchart , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list , Frank Li References: <20230705205954.4159781-1-Frank.Li@nxp.com> <9405224.NyiUUSuA9g@steina-w> <0125c54fd1617f3f945bc3f4bbef5b914b701c24.camel@pengutronix.de> From: Robin Murphy In-Reply-To: <0125c54fd1617f3f945bc3f4bbef5b914b701c24.camel@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_040633_767806_B0C21EA8 X-CRM114-Status: GOOD ( 19.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-07-06 09:23, Lucas Stach wrote: > Hi Alexander, > > Am Donnerstag, dem 06.07.2023 um 07:06 +0200 schrieb Alexander Stein: >> Hi Frank, >> >> Am Mittwoch, 5. Juli 2023, 22:59:53 CEST schrieb Frank Li: >>> The reg size of etm nodes is incorrectly set to 64k instead of 4k. This >>> leads to a crash when calling amba_read_periphid(). After corrected reg >>> size, amba_read_periphid() retrieve the correct periphid. >>> arm,primecell-periphid were removed from the etm nodes. >> >> So this means the reference manual is wrong here? It clearly states the size >> is 64kiB. Reference Manual i.MX8MP Rev 1. 06/2021 >> On a side note: Is imx8mq affected by this as well? The DAP memory table lists >> similar sizes in the RM . >> > Note that the 64K MMIO space per device is really an alignment thing. > It's a recommendation from ARM to allow individual device MMIO regions > to be mapped on kernels with 64K page size. Most of the time the real > MMIO space occupied by the device is actually much smaller than 64K. Indeed, it's quite common for TRM memory maps to be written in terms of the interconnect configuration, i.e. from the point of view of the interconnect itself, that whole range of address space is assigned to that peripheral, and it may even be true that the entire range is routed to the port where that peripheral is connected. However what's of more interest for DT is how much of that range the peripheral itself actually decodes. Robin. > > Regards, > Lucas > >> Best regards, >> Alexander >> >>> Signed-off-by: Frank Li >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++-------- >>> 1 file changed, 4 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index >>> cc406bb338fe..e0ca82ff6f15 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -306,8 +306,7 @@ soc: soc@0 { >>> >>> etm0: etm@28440000 { >>> compatible = "arm,coresight-etm4x", >> "arm,primecell"; >>> - reg = <0x28440000 0x10000>; >>> - arm,primecell-periphid = <0xbb95d>; >>> + reg = <0x28440000 0x1000>; >>> cpu = <&A53_0>; >>> clocks = <&clk IMX8MP_CLK_MAIN_AXI>; >>> clock-names = "apb_pclk"; >>> @@ -323,8 +322,7 @@ etm0_out_port: endpoint { >>> >>> etm1: etm@28540000 { >>> compatible = "arm,coresight-etm4x", >> "arm,primecell"; >>> - reg = <0x28540000 0x10000>; >>> - arm,primecell-periphid = <0xbb95d>; >>> + reg = <0x28540000 0x1000>; >>> cpu = <&A53_1>; >>> clocks = <&clk IMX8MP_CLK_MAIN_AXI>; >>> clock-names = "apb_pclk"; >>> @@ -340,8 +338,7 @@ etm1_out_port: endpoint { >>> >>> etm2: etm@28640000 { >>> compatible = "arm,coresight-etm4x", >> "arm,primecell"; >>> - reg = <0x28640000 0x10000>; >>> - arm,primecell-periphid = <0xbb95d>; >>> + reg = <0x28640000 0x1000>; >>> cpu = <&A53_2>; >>> clocks = <&clk IMX8MP_CLK_MAIN_AXI>; >>> clock-names = "apb_pclk"; >>> @@ -357,8 +354,7 @@ etm2_out_port: endpoint { >>> >>> etm3: etm@28740000 { >>> compatible = "arm,coresight-etm4x", >> "arm,primecell"; >>> - reg = <0x28740000 0x10000>; >>> - arm,primecell-periphid = <0xbb95d>; >>> + reg = <0x28740000 0x1000>; >>> cpu = <&A53_3>; >>> clocks = <&clk IMX8MP_CLK_MAIN_AXI>; >>> clock-names = "apb_pclk"; >> >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel