[at91sam9g45] DMA driver for AC97 and MCI

[at91sam9g45] DMA driver for AC97 and MCI

[Yegor Yefremov]

I try to get sound and SD card working on at91sam9g45-ekes development board using linux-next tree. As far as I understand AT_HDMAC is the appropriate DMA driver for ARCH_AT91SAM9G45. I resolved dependencies with this patch, so I could activate it for my platform.

--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -48,7 +48,7 @@ config DW_DMAC

 config AT_HDMAC
        tristate "Atmel AHB DMA support"
-       depends on ARCH_AT91SAM9RL
+       depends on ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
        select DMA_ENGINE
        help
          Support the Atmel AHB DMA controller.  This can be integrated in

Should this driver be also used for sound driver and MCI? 

Best regards,
Yegor

[at91sam9g45] DMA driver for AC97 and MCI

[Nicolas Ferre]

Hi,

Yegor Yefremov :

> I try to get sound and SD card working on at91sam9g45-ekes development
> board using linux-next tree. As far as I understand AT_HDMAC is the
> appropriate DMA driver for ARCH_AT91SAM9G45.

Correct.

> I resolved dependencies with this patch, so I could activate it for
> my platform.
>
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -48,7 +48,7 @@ config DW_DMAC
> 
>  config AT_HDMAC
>         tristate "Atmel AHB DMA support"
> -       depends on ARCH_AT91SAM9RL
> +       depends on ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
>         select DMA_ENGINE
>         help
>           Support the Atmel AHB DMA controller.  This can be integrated in

Well, this patch was waiting for this other to reach mainline:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5621/1

It is true that you will need it.

> Should this driver be also used for sound driver and MCI?

Sure. For sound, maybe we will have to conform to the dma cyclic API
introduced by dw_dmac driver.

For MCI, here is a patch series that goes before the patch that will do
the link between atmel_mci, at_hdmac and at91sam9g45.

http://lkml.org/lkml/2009/9/17/224

This last patch is not posted to the mailing list yet, I am waiting for
the others to reach mainline.

I you are interested in it, you can have a preview here:
ftp://ftp.linux4sam.org/devel/linux/2630_lnx4sam_patchset-tmp_20090828.tgz
patch named :
"at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and
board" aka:
2630_lnx4sam_patchset-tmp/2.6.30-at91-exp-0033-at91-atmel-mci-inclusion-of-sd-mmc-driver-in-at91sa.patch

Hope this helps,

Best regards,
-- 
Nicolas Ferre

[at91sam9g45] DMA driver for AC97 and MCI

[Russell King - ARM Linux]

On Fri, Sep 25, 2009 at 05:36:15PM +0200, Nicolas Ferre wrote:
> Well, this patch was waiting for this other to reach mainline:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5621/1

... which finally got through last night.

[at91sam9g45] DMA driver for AC97 and MCI

[Yegor Yefremov]

>> I try to get sound and SD card working on at91sam9g45-ekes development
>> board using linux-next tree. As far as I understand AT_HDMAC is the
>> appropriate DMA driver for ARCH_AT91SAM9G45.
> 
> Correct.
> 
>> I resolved dependencies with this patch, so I could activate it for
>> my platform.
>>
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -48,7 +48,7 @@ config DW_DMAC
>>
>>  config AT_HDMAC
>>         tristate "Atmel AHB DMA support"
>> -       depends on ARCH_AT91SAM9RL
>> +       depends on ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
>>         select DMA_ENGINE
>>         help
>>           Support the Atmel AHB DMA controller.  This can be integrated in
> 
> Well, this patch was waiting for this other to reach mainline:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5621/1
> 
> It is true that you will need it.
> 
>> Should this driver be also used for sound driver and MCI?
> 
> Sure. For sound, maybe we will have to conform to the dma cyclic API
> introduced by dw_dmac driver.
> 
> For MCI, here is a patch series that goes before the patch that will do
> the link between atmel_mci, at_hdmac and at91sam9g45.
> 
> http://lkml.org/lkml/2009/9/17/224
> 
> This last patch is not posted to the mailing list yet, I am waiting for
> the others to reach mainline.
> 
> I you are interested in it, you can have a preview here:
> ftp://ftp.linux4sam.org/devel/linux/2630_lnx4sam_patchset-tmp_20090828.tgz
> patch named :
> "at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and
> board" aka:
> 2630_lnx4sam_patchset-tmp/2.6.30-at91-exp-0033-at91-atmel-mci-inclusion-of-sd-mmc-driver-in-at91sa.patch

Thanks for the patches. I could get the stuff working. I applied 

2.6.30-at91-exp-0031-atmel-mci-change-use-of-dma-slave-interface.patch
2.6.30-at91-exp-0032-mmc-atmel-mci-New-MCI2-module-support-in-atmel-mci.patch
2.6.30-at91-exp-0033-at91-atmel-mci-inclusion-of-sd-mmc-driver-in-at91sa.patch

to Linus tree (2.6.32-rc2)

As to 2.6.30-at91-exp-0033-at91-atmel-mci-inclusion-of-sd-mmc-driver-in-at91sa.patch I've only changed
DW_DMA_SLAVE_WIDTH_32BIT to AT_DMA_SLAVE_WIDTH_32BIT

I couldn't apply 2.6.30-at91-exp-0032-mmc-atmel-mci-New-MCI2-module-support-in-atmel-mci.patch with quilt at once, so I had to make it manually. Here is applicable version:

[at91sam9g45] DMA driver for AC97 and MCI

[Nicolas Ferre]

Yegor Yefremov :
> I try to get sound and SD card working on at91sam9g45-ekes development board using linux-next tree. As far as I understand AT_HDMAC is the appropriate DMA driver for ARCH_AT91SAM9G45. I resolved dependencies with this patch, so I could activate it for my platform.
> 
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -48,7 +48,7 @@ config DW_DMAC
> 
>  config AT_HDMAC
>         tristate "Atmel AHB DMA support"
> -       depends on ARCH_AT91SAM9RL
> +       depends on ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
>         select DMA_ENGINE
>         help
>           Support the Atmel AHB DMA controller.  This can be integrated in
> 

Yegor,

As the preceding patch is now in mainline, maybe you can submit this one
to Russell patch tracking system (or tell me to do so).

Anyway, you can add my:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Best regards,
-- 
Nicolas Ferre

[at91sam9g45] DMA driver for AC97 and MCI

[Yegor Yefremov]

>> I try to get sound and SD card working on at91sam9g45-ekes development board using linux-next tree. As far as I understand AT_HDMAC is the appropriate DMA driver for ARCH_AT91SAM9G45. I resolved dependencies with this patch, so I could activate it for my platform.
>>
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -48,7 +48,7 @@ config DW_DMAC
>>
>>  config AT_HDMAC
>>         tristate "Atmel AHB DMA support"
>> -       depends on ARCH_AT91SAM9RL
>> +       depends on ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
>>         select DMA_ENGINE
>>         help
>>           Support the Atmel AHB DMA controller.  This can be integrated in
>>
> 
> Yegor,
> 
> As the preceding patch is now in mainline, maybe you can submit this one
> to Russell patch tracking system (or tell me to do so).
> 
> Anyway, you can add my:
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

I've just submitted this patch (http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5770/1)

Regards,
Yegor