From: aaro.koskinen@nokia.com (Aaro Koskinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] n2100: reduce power button timer to 1 Hz
Date: Mon, 28 Sep 2009 13:44:26 +0300 [thread overview]
Message-ID: <4AC0938A.1040009@nokia.com> (raw)
In-Reply-To: <19136.36934.791249.535941@pilspetsen.it.uu.se>
Hello,
Mikael Pettersson wrote:
> Aaro Koskinen writes:
> > Mikael Pettersson wrote:
> > > 10 Hz seems excessive, so this patch adds a compile-time option
> > > to reduce the polling frequency to 1 Hz.
> > >
> > > (This change could possibly be handled via a kernel boot option,
> > > or even be made unconditional, but I opted for a compile-time
> > > option for now.)
> >
> > I don't think there is need to have an option for this. With HZ also
> > round_jiffies() could be used, it doesn't need to be exact.
>
> I don't quite follow you here. Can you elaborate?
round_jiffies() rounds the time up or down to a full second. It's useful for
timers that expire every N seconds. This way timeouts can be grouped, so there
is less wakeups.
A.
next prev parent reply other threads:[~2009-09-28 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 19:53 [PATCH 2/2] n2100: reduce power button timer to 1 Hz Mikael Pettersson
2009-09-28 8:06 ` Aaro Koskinen
2009-09-28 10:30 ` Mikael Pettersson
2009-09-28 10:44 ` Aaro Koskinen [this message]
2009-09-28 11:26 ` Mikael Pettersson
2009-09-28 9:52 ` Lennert Buytenhek
2009-09-28 10:25 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC0938A.1040009@nokia.com \
--to=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).