From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ep93xx: update i2c support
Date: Thu, 01 Oct 2009 14:55:29 +1300 [thread overview]
Message-ID: <4AC40C11.4060401@bluewatersys.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901D42C7C@mi8nycmail19.Mi8.com>
H Hartley Sweeten wrote:
> Update the ep93xx i2c support:
>
> 1) The platform init code passes the configuration data for the
> i2c-gpio driver. This allows any gpio pin do be used for the
> sda and scl pins. It also allows the platform to specify the
> udelay and timeout.
> 2) Program the gpio configuration register to enable/disable the
> open drain drivers. Note that this really only works if the
> sda and scl pins are set to EP93XX_GPIO_LINE_EEDAT and
> EP93XX_GPIO_LINE_EECLK.
> 3) Update the edb93xx.c platform init to use the new support.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> ---
>
> -void __init ep93xx_register_i2c(struct i2c_board_info *devices, int num)
> +void __init ep93xx_register_i2c(struct i2c_gpio_platform_data *data,
> + struct i2c_board_info *devices, int num)
> {
> + ep93xx_i2c_data = *data;
> +
> + /*
> + * Set the EEPROM interface pin drive type control.
> + * Defines the driver type for the EECLK and EEDAT pins as either
> + * open drain, which will require an external pull-up, or a normal
> + * CMOS driver.
> + */
> + if (data->sda_is_open_drain && data->sda_pin != EP93XX_GPIO_LINE_EEDAT)
> + printk("ep93xx: sda != EEDAT, open drain has no effect\n");
> + if (data->scl_is_open_drain && data->scl_pin != EP93XX_GPIO_LINE_EECLK)
> + printk("ep93xx: scl != EECLK, open drain has no effect\n");
pr_warning on these. Otherwise:
Acked-by: Ryan Mallon <ryan@bluewatersys.com>
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2009-10-01 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 19:18 [PATCH] ep93xx: update i2c support H Hartley Sweeten
2009-09-18 19:29 ` H Hartley Sweeten
2009-09-30 20:10 ` Ryan Mallon
2009-09-30 20:18 ` H Hartley Sweeten
2009-09-30 21:01 ` H Hartley Sweeten
2009-09-30 21:08 ` Ryan Mallon
2009-09-30 21:24 ` H Hartley Sweeten
2009-10-01 1:55 ` Ryan Mallon [this message]
2009-10-01 21:41 ` H Hartley Sweeten
2009-10-01 22:18 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC40C11.4060401@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).