* [PATCH] s3c2440: mini2440 buildfix
@ 2009-10-01 13:31 Anand Gadiyar
2009-10-01 13:34 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Anand Gadiyar @ 2009-10-01 13:31 UTC (permalink / raw)
To: linux-arm-kernel
s3c2440: mini2440 buildfix
Fix the following two build errors seen with mini2440_defconfig:
CC arch/arm/plat-s3c24xx/cpu.o
arch/arm/plat-s3c24xx/cpu.c:84: error: 's3c2410a_init' undeclared here (not in a function)
make[1]: *** [arch/arm/plat-s3c24xx/cpu.o] Error 1
make: *** [arch/arm/plat-s3c24xx] Error 2
LD .tmp_vmlinux1
arch/arm/mach-s3c2440/built-in.o:(.init.data+0x724): undefined reference to `s3c_device_usb'
make: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
CC: Gaye Abdoulaye Walsimou <walsimou@walsimou.com>
CC: Ben Dooks <ben-linux@fluff.org>
---
The latter error was reported by Gaye Abdoulaye Walsimou.
I hit the former error while attempting to fix it.
I don't have this board, so I do not know if this is correct.
Build-tested only.
- Anand
diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
index d7bba91..64f9e6d 100644
--- a/arch/arm/mach-s3c2440/Kconfig
+++ b/arch/arm/mach-s3c2440/Kconfig
@@ -102,6 +102,7 @@ config MACH_MINI2440
select EEPROM_AT24
select LEDS_TRIGGER_BACKLIGHT
select SND_S3C24XX_SOC_S3C24XX_UDA134X
+ select S3C_DEV_USB_HOST
select S3C_DEV_NAND
help
Say Y here to select support for the MINI2440. Is a 10cm x 10cm board
diff --git a/arch/arm/plat-s3c24xx/include/plat/s3c2410.h b/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
index b6deeef..82ab4aa 100644
--- a/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
+++ b/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
@@ -27,6 +27,7 @@ extern void s3c2410_init_clocks(int xtal);
#define s3c2410_init_uarts NULL
#define s3c2410_map_io NULL
#define s3c2410_init NULL
+#define s3c2410a_init NULL
#endif
extern int s3c2410_baseclk_add(void);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] s3c2440: mini2440 buildfix
2009-10-01 13:31 [PATCH] s3c2440: mini2440 buildfix Anand Gadiyar
@ 2009-10-01 13:34 ` Ben Dooks
2009-10-02 21:52 ` Gaye Abdoulaye Walsimou
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2009-10-01 13:34 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 01, 2009 at 07:01:34PM +0530, Anand Gadiyar wrote:
> s3c2440: mini2440 buildfix
>
> Fix the following two build errors seen with mini2440_defconfig:
>
> CC arch/arm/plat-s3c24xx/cpu.o
> arch/arm/plat-s3c24xx/cpu.c:84: error: 's3c2410a_init' undeclared here (not in a function)
> make[1]: *** [arch/arm/plat-s3c24xx/cpu.o] Error 1
> make: *** [arch/arm/plat-s3c24xx] Error 2
>
> LD .tmp_vmlinux1
> arch/arm/mach-s3c2440/built-in.o:(.init.data+0x724): undefined reference to `s3c_device_usb'
> make: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> CC: Gaye Abdoulaye Walsimou <walsimou@walsimou.com>
> CC: Ben Dooks <ben-linux@fluff.org>
> ---
> The latter error was reported by Gaye Abdoulaye Walsimou.
> I hit the former error while attempting to fix it.
>
> I don't have this board, so I do not know if this is correct.
> Build-tested only.
>
> - Anand
>
> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
> index d7bba91..64f9e6d 100644
> --- a/arch/arm/mach-s3c2440/Kconfig
> +++ b/arch/arm/mach-s3c2440/Kconfig
> @@ -102,6 +102,7 @@ config MACH_MINI2440
> select EEPROM_AT24
> select LEDS_TRIGGER_BACKLIGHT
> select SND_S3C24XX_SOC_S3C24XX_UDA134X
> + select S3C_DEV_USB_HOST
> select S3C_DEV_NAND
> help
> Say Y here to select support for the MINI2440. Is a 10cm x 10cm board
Yes, this is the fix for this one.
> diff --git a/arch/arm/plat-s3c24xx/include/plat/s3c2410.h b/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
> index b6deeef..82ab4aa 100644
> --- a/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
> +++ b/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
> @@ -27,6 +27,7 @@ extern void s3c2410_init_clocks(int xtal);
> #define s3c2410_init_uarts NULL
> #define s3c2410_map_io NULL
> #define s3c2410_init NULL
> +#define s3c2410a_init NULL
> #endif
this one we've already got a fix queued, awaiting feedback on the
s3c64xx fixes before pushing upstream.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] s3c2440: mini2440 buildfix
2009-10-01 13:34 ` Ben Dooks
@ 2009-10-02 21:52 ` Gaye Abdoulaye Walsimou
0 siblings, 0 replies; 3+ messages in thread
From: Gaye Abdoulaye Walsimou @ 2009-10-02 21:52 UTC (permalink / raw)
To: linux-arm-kernel
Ben Dooks wrote:
> On Thu, Oct 01, 2009 at 07:01:34PM +0530, Anand Gadiyar wrote:
>
>> s3c2440: mini2440 buildfix
>>
>> Fix the following two build errors seen with mini2440_defconfig:
>>
>> CC arch/arm/plat-s3c24xx/cpu.o
>> arch/arm/plat-s3c24xx/cpu.c:84: error: 's3c2410a_init' undeclared here (not in a function)
>> make[1]: *** [arch/arm/plat-s3c24xx/cpu.o] Error 1
>> make: *** [arch/arm/plat-s3c24xx] Error 2
>>
>> LD .tmp_vmlinux1
>> arch/arm/mach-s3c2440/built-in.o:(.init.data+0x724): undefined reference to `s3c_device_usb'
>> make: *** [.tmp_vmlinux1] Error 1
>>
>> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
>> CC: Gaye Abdoulaye Walsimou <walsimou@walsimou.com>
>> CC: Ben Dooks <ben-linux@fluff.org>
>> ---
>> The latter error was reported by Gaye Abdoulaye Walsimou.
>> I hit the former error while attempting to fix it.
>>
>> I don't have this board, so I do not know if this is correct.
>> Build-tested only.
>>
>> - Anand
>>
>> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
>> index d7bba91..64f9e6d 100644
>> --- a/arch/arm/mach-s3c2440/Kconfig
>> +++ b/arch/arm/mach-s3c2440/Kconfig
>> @@ -102,6 +102,7 @@ config MACH_MINI2440
>> select EEPROM_AT24
>> select LEDS_TRIGGER_BACKLIGHT
>> select SND_S3C24XX_SOC_S3C24XX_UDA134X
>> + select S3C_DEV_USB_HOST
>> select S3C_DEV_NAND
>> help
>> Say Y here to select support for the MINI2440. Is a 10cm x 10cm board
>>
>
> Yes, this is the fix for this one.
>
>
>> diff --git a/arch/arm/plat-s3c24xx/include/plat/s3c2410.h b/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
>> index b6deeef..82ab4aa 100644
>> --- a/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
>> +++ b/arch/arm/plat-s3c24xx/include/plat/s3c2410.h
>> @@ -27,6 +27,7 @@ extern void s3c2410_init_clocks(int xtal);
>> #define s3c2410_init_uarts NULL
>> #define s3c2410_map_io NULL
>> #define s3c2410_init NULL
>> +#define s3c2410a_init NULL
>> #endif
>>
>
> this one we've already got a fix queued, awaiting feedback on the
> s3c64xx fixes before pushing upstream.
>
>
Thanks for these fix!
I didn't notice the second one, but I've already submitted similar
patch for the first!
Regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-02 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-01 13:31 [PATCH] s3c2440: mini2440 buildfix Anand Gadiyar
2009-10-01 13:34 ` Ben Dooks
2009-10-02 21:52 ` Gaye Abdoulaye Walsimou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).