From: valentin.longchamp@epfl.ch (Valentin Longchamp)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fix pcm037_eet compilation with the new SPI driver
Date: Mon, 05 Oct 2009 16:01:17 +0200 [thread overview]
Message-ID: <4AC9FC2D.6000200@epfl.ch> (raw)
In-Reply-To: <20091005121936.GD23986@pengutronix.de>
Hi Sascha,
Sascha Hauer wrote:
>
> On Mon, Oct 05, 2009 at 10:04:51AM +0200, Guennadi Liakhovetski wrote:
>> At some point the SPI device name in arch/arm/mach-mx3/devices.c has
>> changed, which then broke compilation of pcm037_eet with the new SPI
>> driver. Use the correct name.
>
> It didn't change, it was merged with imx_spi_device0. Can we change the
> name in devices.[ch] instead? All other devices start with mxc_. Sorry,
> my bad.
I don't really where it is changed ... mxc seems better so devices.[ch]
is more logical.
But I have sent the exact same patch on Friday and received no comment
... I hope mine or Guennadi's (I don't really care) can get its way to -rc4.
Val
>
> Sascha
>
>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> ---
>> diff --git a/arch/arm/mach-mx3/pcm037_eet.c b/arch/arm/mach-mx3/pcm037_eet.c
>> index 8d38600..dc6baf3 100644
>> --- a/arch/arm/mach-mx3/pcm037_eet.c
>> +++ b/arch/arm/mach-mx3/pcm037_eet.c
>> @@ -184,7 +184,7 @@ static int eet_init_devices(void)
>> /* SPI */
>> spi_register_board_info(pcm037_spi_dev, ARRAY_SIZE(pcm037_spi_dev));
>> #if defined(CONFIG_SPI_IMX) || defined(CONFIG_SPI_IMX_MODULE)
>> - mxc_register_device(&mxc_spi_device0, &pcm037_spi1_master);
>> + mxc_register_device(&imx_spi_device0, &pcm037_spi1_master);
>> #endif
>>
>> platform_device_register(&pcm037_gpio_keys_device);
>>
>
next prev parent reply other threads:[~2009-10-05 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 8:04 [PATCH] fix pcm037_eet compilation with the new SPI driver Guennadi Liakhovetski
2009-10-05 12:19 ` Sascha Hauer
2009-10-05 14:01 ` Valentin Longchamp [this message]
2009-10-05 14:49 ` [PATCH v2] " Guennadi Liakhovetski
2009-10-05 15:34 ` Valentin Longchamp
2009-10-06 6:48 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC9FC2D.6000200@epfl.ch \
--to=valentin.longchamp@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).