linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2.6.32] hwmon: Disable s3c-hwmon build for S3C64xx
@ 2009-10-07 13:39 Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2009-10-07 13:39 UTC (permalink / raw)
  To: linux-arm-kernel

The s3c-hwmon driver depends on the arch/arm implementation of the core
ADC support for the chip.  Since the S3C64xx version has not yet been
merged disable building of the driver on S3C64xx for now.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/hwmon/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 4d0d0cd..87184b5 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -684,7 +684,7 @@ config SENSORS_SHT15
 
 config SENSORS_S3C
 	tristate "S3C24XX/S3C64XX Inbuilt ADC"
-	depends on ARCH_S3C2410 || ARCH_S3C64XX
+	depends on ARCH_S3C2410
 	help
 	  If you say yes here you get support for the on-board ADCs of
 	  the Samsung S3C24XX or S3C64XX series of SoC
-- 
1.6.4.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2.6.32] hwmon: Disable s3c-hwmon build for S3C64xx
       [not found] <mailman.3211.1254922769.2256.linux-arm-kernel@lists.infradead.org>
@ 2009-10-07 14:22 ` Maurus Cuelenaere
  2009-10-07 14:30   ` [lm-sensors] " Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Maurus Cuelenaere @ 2009-10-07 14:22 UTC (permalink / raw)
  To: linux-arm-kernel

Op 07-10-09 15:39, linux-arm-kernel-request at lists.infradead.org schreef:
> The s3c-hwmon driver depends on the arch/arm implementation of the core
> ADC support for the chip.  Since the S3C64xx version has not yet been
> merged disable building of the driver on S3C64xx for now.
>
> Signed-off-by: Mark Brown<broonie@opensource.wolfsonmicro.com>
> ---
>   drivers/hwmon/Kconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 4d0d0cd..87184b5 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -684,7 +684,7 @@ config SENSORS_SHT15
>
>   config SENSORS_S3C
>   	tristate "S3C24XX/S3C64XX Inbuilt ADC"
> -	depends on ARCH_S3C2410 || ARCH_S3C64XX
> +	depends on ARCH_S3C2410
>   	help
>   	  If you say yes here you get support for the on-board ADCs of
>   	  the Samsung S3C24XX or S3C64XX series of SoC
> -- 1.6.4.3

Have you seen this?

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-October/001787.html

Regards,

Maurus Cuelenaere

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [lm-sensors] [PATCH 2.6.32] hwmon: Disable s3c-hwmon build for S3C64xx
  2009-10-07 14:22 ` [PATCH 2.6.32] hwmon: Disable s3c-hwmon build for S3C64xx Maurus Cuelenaere
@ 2009-10-07 14:30   ` Mark Brown
  2009-10-07 14:55     ` Jean Delvare
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2009-10-07 14:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 07, 2009 at 04:22:34PM +0200, Maurus Cuelenaere wrote:

> Have you seen this?

> http://lists.infradead.org/pipermail/linux-arm-kernel/2009-October/001787.html

Yes, but it doesn't look like 2.6.32 material at this point (and the fix
patch was originally posted in August).

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [lm-sensors] [PATCH 2.6.32] hwmon: Disable s3c-hwmon build  for S3C64xx
  2009-10-07 14:30   ` [lm-sensors] " Mark Brown
@ 2009-10-07 14:55     ` Jean Delvare
  2009-10-07 15:02       ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2009-10-07 14:55 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Mark,

On Wed, 7 Oct 2009 15:30:07 +0100, Mark Brown wrote:
> On Wed, Oct 07, 2009 at 04:22:34PM +0200, Maurus Cuelenaere wrote:
> 
> > Have you seen this?
> 
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2009-October/001787.html
> 
> Yes, but it doesn't look like 2.6.32 material at this point (and the fix
> patch was originally posted in August).

I thought it'd be merged into the patch adding the driver, that's why I
didn't pick it back then. But it did not happen, so I've applied your
patch now and will send it to Linus soon.

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [lm-sensors] [PATCH 2.6.32] hwmon: Disable s3c-hwmon build for S3C64xx
  2009-10-07 14:55     ` Jean Delvare
@ 2009-10-07 15:02       ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2009-10-07 15:02 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 07, 2009 at 04:55:37PM +0200, Jean Delvare wrote:

> I thought it'd be merged into the patch adding the driver, that's why I
> didn't pick it back then. But it did not happen, so I've applied your
> patch now and will send it to Linus soon.

Thanks.  The driver patch had already been applied at the time I posted
(I noticed the issue through running -next rather than code review).

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-10-07 15:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <mailman.3211.1254922769.2256.linux-arm-kernel@lists.infradead.org>
2009-10-07 14:22 ` [PATCH 2.6.32] hwmon: Disable s3c-hwmon build for S3C64xx Maurus Cuelenaere
2009-10-07 14:30   ` [lm-sensors] " Mark Brown
2009-10-07 14:55     ` Jean Delvare
2009-10-07 15:02       ` Mark Brown
2009-10-07 13:39 Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).