[PATCH] ep93xx: introduce clk parent

[cgagneraud@techworks.ie (Christian Gagneraud)]

H Hartley Sweeten wrote:
> On Thursday, October 08, 2009 2:29 PM, Christian Gagneraud wrote:
>> Hi,
>>
>> What's the status of this patch? It does not appear on the patch 
>> tracker, and it's not in linus tree (or I'm missing something).
>>
>> I'm currently working on adding ADC support (no touchscreen for now) 
>> and the problem is that touchscreen (ADC) and keypad use the same 
>> clock. With this patch applied it would be possible to define the 
>> shared ep93xx-keytch clock and add ep93xx-keypad and 
>> ep93xx-touchscreen as children.
> 
> Christian,
> 
> I have a patch for clock.c that adds the keypad clock.  This will
> also give you what you need to configure the adc clock.  Hopefully
> I will get a chance to post that patch in the next couple days.
> 
> As Russell already mentioned, the clk parent patch does not effect
> the adc clock.  The common clock between them is actually the external
> crystal.
> 
> The only thing they share is the configuration register used to set
> the clock divisor and to enable the clock.  For the adc clock you
> will just need to add:
> 
> +static struct clk clk_adc = {
> +	.parent		= &clk_xtali,
> +	.sw_locked	= 1,
> +	.enable_reg	= EP93XX_SYSCON_KEYTCHCLKDIV,
> +	.enable_mask	= EP93XX_SYSCON_KEYTCHCLKDIV_TSEN,
> +	.set_rate	= set_keytchclk_rate,
> +};
> 
> And of course the proper INIT_CK() for clk_adc.  The set_rate
> callback will be the same one used for the keypad, which will
> be in my coming patch.

Hartley,

The keypad clock is already in as is the et_keytchclk_rate too.

Can you explain me by the way why the keypad declares the clock with 
dev_id="ep93xx-keypad" and no con_id, but the pwm declares the clock 
with no dev_id and with con_id="clk_pwm"
Which of dev and con is the consumer and which one is the producer?
I'm a bit confuse between the platform_driver.name, the clock.dev_id 
and the clock.con_id

As well I've noticed that the EP93XX keypad input driver does a 
clock_get("clk_key"), but this clock doesn't exist. or did I miss 
something.


Regards,
Chris

> 
> Regards,
> Hartley