linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ep93xx: fix build error in edb93xx.c
@ 2009-10-13 23:05 H Hartley Sweeten
  2009-10-14  0:41 ` Ryan Mallon
  0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2009-10-13 23:05 UTC (permalink / raw)
  To: linux-arm-kernel

Fix a build error due to a typo (missing comma) in:

	ARM: 5754/1: ep93xx: update i2c support

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>

---

diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c
index ca71cf1..a4a7be3 100644
--- a/arch/arm/mach-ep93xx/edb93xx.c
+++ b/arch/arm/mach-ep93xx/edb93xx.c
@@ -112,7 +112,7 @@ static void __init edb93xx_register_i2c(void)
 				    ARRAY_SIZE(edb93xxa_i2c_board_info));
 	} else if (machine_is_edb9307() || machine_is_edb9312() ||
 		   machine_is_edb9315()) {
-		ep93xx_register_i2c(&edb93xx_i2c_gpio_data
+		ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
 				    edb93xx_i2c_board_info,
 				    ARRAY_SIZE(edb93xx_i2c_board_info));
 	} 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ep93xx: fix build error in edb93xx.c
  2009-10-13 23:05 [PATCH] ep93xx: fix build error in edb93xx.c H Hartley Sweeten
@ 2009-10-14  0:41 ` Ryan Mallon
  2009-10-14  0:54   ` H Hartley Sweeten
  0 siblings, 1 reply; 3+ messages in thread
From: Ryan Mallon @ 2009-10-14  0:41 UTC (permalink / raw)
  To: linux-arm-kernel

H Hartley Sweeten wrote:
> Fix a build error due to a typo (missing comma) in:
> 
> 	ARM: 5754/1: ep93xx: update i2c support
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
> 
> ---
> 
> diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c
> index ca71cf1..a4a7be3 100644
> --- a/arch/arm/mach-ep93xx/edb93xx.c
> +++ b/arch/arm/mach-ep93xx/edb93xx.c
> @@ -112,7 +112,7 @@ static void __init edb93xx_register_i2c(void)
>  				    ARRAY_SIZE(edb93xxa_i2c_board_info));
>  	} else if (machine_is_edb9307() || machine_is_edb9312() ||
>  		   machine_is_edb9315()) {
> -		ep93xx_register_i2c(&edb93xx_i2c_gpio_data
> +		ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
>  				    edb93xx_i2c_board_info,
>  				    ARRAY_SIZE(edb93xx_i2c_board_info));
>  	} 
> 

Acked-by: Ryan Mallon <ryan@bluewatersys.com>

How did it slip through?

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ep93xx: fix build error in edb93xx.c
  2009-10-14  0:41 ` Ryan Mallon
@ 2009-10-14  0:54   ` H Hartley Sweeten
  0 siblings, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2009-10-14  0:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Tuesday, October 13, 2009 5:41 PM, Ryan Mallon wrote:
>> Fix a build error due to a typo (missing comma) in:
>> 
>> 	ARM: 5754/1: ep93xx: update i2c support
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Ryan Mallon <ryan@bluewatersys.com>
>> 
>> ---
>> 
>> diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c
>> index ca71cf1..a4a7be3 100644
>> --- a/arch/arm/mach-ep93xx/edb93xx.c
>> +++ b/arch/arm/mach-ep93xx/edb93xx.c
>> @@ -112,7 +112,7 @@ static void __init edb93xx_register_i2c(void)
>>  				    ARRAY_SIZE(edb93xxa_i2c_board_info));
>>  	} else if (machine_is_edb9307() || machine_is_edb9312() ||
>>  		   machine_is_edb9315()) {
>> -		ep93xx_register_i2c(&edb93xx_i2c_gpio_data
>> +		ep93xx_register_i2c(&edb93xx_i2c_gpio_data,
>>  				    edb93xx_i2c_board_info,
>>  				    ARRAY_SIZE(edb93xx_i2c_board_info));
>>  	} 
>> 
>
> Acked-by: Ryan Mallon <ryan@bluewatersys.com>
>
> How did it slip through?

My screw up somewhere... Tested in my build/devel tree then moved the
change over to my clean git tree to create the patch.  Sorry about that.

Regards,
Hartley

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-10-14  0:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-13 23:05 [PATCH] ep93xx: fix build error in edb93xx.c H Hartley Sweeten
2009-10-14  0:41 ` Ryan Mallon
2009-10-14  0:54   ` H Hartley Sweeten

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).