linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler()
Date: Wed, 21 Oct 2009 14:00:41 +1300	[thread overview]
Message-ID: <4ADE5D39.3080005@bluewatersys.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901DB8071@mi8nycmail19.Mi8.com>

H Hartley Sweeten wrote:
> Remove unnecessary code in ep93xx_gpio_ab_irq_handler().
> 
> The desc calculation for gpio port B was left in when the following
> commit was merged.
> 
> commit d8aa0251f12546e9bd1e9ee1d9782d6492819a04
> Author: Dmitry Baryshkov <dbaryshkov@gmail.com>
> Date:   Thu Oct 9 13:36:24 2008 +0100
> 
>     [ARM] 5298/1: Drop desc_handle_irq()
> 
> It's not needed so remove it.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
> 
> ---
> 
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index f95dc16..b4357c3 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -206,7 +206,6 @@ static void ep93xx_gpio_ab_irq_handler(unsigned int irq, struct irq_desc *desc)
>  	for (i = 0; i < 8; i++) {
>  		if (status & (1 << i)) {
>  			int gpio_irq = gpio_to_irq(EP93XX_GPIO_LINE_B(0)) + i;
> -			desc = irq_desc + gpio_irq;
>  			generic_handle_irq(gpio_irq);
>  		}
>  	} 
> 

Acked-by: Ryan Mallon <ryan@bluewatersys.com>

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

      reply	other threads:[~2009-10-21  1:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 21:55 [PATCH] ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler() H Hartley Sweeten
2009-10-21  1:00 ` Ryan Mallon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADE5D39.3080005@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).